Xin Long
2df0d6de5e
sctp: set frag_point in sctp_setsockopt_maxseg correctly
...
commit ecca8f88da upstream.
Now in sctp_setsockopt_maxseg user_frag or frag_point can be set with
val >= 8 and val <= SCTP_MAX_CHUNK_LEN. But both checks are incorrect.
val >= 8 means frag_point can even be less than SCTP_DEFAULT_MINSEGMENT.
Then in sctp_datamsg_from_user(), when it's value is greater than cookie
echo len and trying to bundle with cookie echo chunk, the first_len will
overflow.
The worse case is when it's value is equal as cookie echo len, first_len
becomes 0, it will go into a dead loop for fragment later on. In Hangbin
syzkaller testing env, oom was even triggered due to consecutive memory
allocation in that loop.
Besides, SCTP_MAX_CHUNK_LEN is the max size of the whole chunk, it should
deduct the data header for frag_point or user_frag check.
This patch does a proper check with SCTP_DEFAULT_MINSEGMENT subtracting
the sctphdr and datahdr, SCTP_MAX_CHUNK_LEN subtracting datahdr when
setting frag_point via sockopt. It also improves sctp_setsockopt_maxseg
codes.
Suggested-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com >
Reported-by: Hangbin Liu <liuhangbin@gmail.com >
Signed-off-by: Xin Long <lucien.xin@gmail.com >
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2018-02-25 11:07:47 +01:00
..
2017-07-11 06:08:58 -04:00
2017-09-01 22:49:47 +02:00
2015-02-20 17:35:14 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-04-05 10:15:20 +02:00
2016-02-11 03:54:14 -05:00
2018-02-25 11:07:47 +01:00
2017-11-02 11:10:55 +01:00
2017-04-12 22:02:36 +02:00
2017-11-09 10:03:09 +09:00
2017-11-02 11:10:55 +01:00
2015-09-17 13:20:05 +02:00
2017-08-29 10:55:20 +01:00
2017-11-02 11:10:55 +01:00
2017-04-24 12:35:56 -04:00
2017-11-02 11:10:55 +01:00
2018-01-31 14:03:44 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2016-02-09 04:45:49 -05:00
2014-11-10 13:27:49 -05:00
2017-05-27 18:51:41 -04:00
2017-08-11 14:21:42 -07:00
2017-08-11 14:59:24 -07:00
2017-07-04 22:35:16 +01:00
2018-02-25 11:07:45 +01:00
2016-07-08 12:20:57 +02:00
2017-01-20 12:12:13 -05:00
2017-07-04 01:29:04 -07:00
2016-04-19 20:09:25 -04:00
2016-04-25 16:44:27 -04:00
2016-06-25 12:19:35 -04:00
2016-04-25 16:44:27 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2013-12-06 12:37:56 -05:00
2015-03-06 21:50:02 -05:00
2017-08-31 14:42:19 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2013-09-20 14:49:32 -04:00
2014-02-09 17:32:49 -08:00
2017-11-02 11:10:55 +01:00
2017-09-05 11:53:34 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-08-22 14:29:30 -07:00
2017-11-02 11:10:55 +01:00
2015-09-23 15:33:15 -07:00
2017-09-01 20:33:42 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-18 09:40:35 +02:00
2016-09-30 13:29:21 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2016-04-27 22:48:25 -04:00
2017-01-25 16:00:33 +01:00
2016-01-04 20:40:41 +01:00
2017-07-04 01:29:04 -07:00
2017-11-02 11:10:55 +01:00
2015-12-15 23:25:20 -05:00
2017-01-18 13:04:28 -05:00
2017-08-07 11:39:22 -07:00
2017-11-02 11:10:55 +01:00
2017-06-15 12:12:40 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-08-07 11:39:21 -07:00
2018-02-22 15:42:23 +01:00
2018-02-22 15:42:23 +01:00
2017-11-02 11:10:55 +01:00
2016-03-13 23:55:13 -04:00
2017-09-01 17:42:05 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-08-03 15:35:59 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-01-02 20:31:06 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-01-31 14:03:44 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2016-08-17 19:36:23 -04:00
2016-10-13 12:05:26 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2013-09-21 14:01:38 -04:00
2013-09-21 14:01:38 -04:00
2014-12-10 15:21:24 -05:00
2015-05-11 10:50:17 -04:00
2013-09-21 14:01:38 -04:00
2014-01-01 22:22:43 -05:00
2013-09-21 14:01:38 -04:00
2013-09-21 14:01:38 -04:00
2014-12-10 15:21:24 -05:00
2013-09-21 14:01:38 -04:00
2017-07-04 22:35:15 +01:00
2017-11-02 11:10:55 +01:00
2018-02-03 17:39:03 +01:00
2016-07-08 13:23:12 +02:00
2013-12-06 12:37:56 -05:00
2017-11-02 11:10:55 +01:00
2017-04-01 20:21:44 -07:00
2016-10-03 02:00:22 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-01-31 14:03:45 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-07-01 07:39:09 -07:00
2017-11-02 11:10:55 +01:00
2015-12-08 22:02:33 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2016-07-08 12:20:57 +02:00
2017-08-29 15:16:52 -07:00
2017-11-02 11:10:55 +01:00
2016-03-23 22:09:58 -04:00
2017-11-09 10:03:09 +09:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-01 03:55:47 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-08-07 11:39:21 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2014-12-17 11:49:55 +01:00
2017-07-01 07:39:08 -07:00
2017-11-02 11:10:55 +01:00
2017-10-01 03:55:47 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 10:04:46 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2016-11-09 20:40:06 -05:00
2017-08-25 17:10:23 -07:00
2017-11-02 11:10:55 +01:00
2016-04-28 11:49:45 -04:00
2017-11-02 11:10:55 +01:00
2018-02-22 15:42:23 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-25 10:37:11 +09:00
2017-08-07 14:48:48 -07:00
2015-03-12 22:58:12 -04:00
2018-01-02 20:31:09 +01:00
2015-07-09 15:12:20 -07:00
2018-01-31 14:03:45 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-08-29 15:16:52 -07:00
2017-11-02 11:10:55 +01:00
2017-10-01 03:55:47 +01:00
2017-11-02 11:10:55 +01:00
2013-07-27 22:14:06 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2014-09-05 17:35:28 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00