Files
linux/include/linux
NeilBrown 1c28b206ae SUNRPC: always free ctxt when freeing deferred request
[ Upstream commit 948f072ada ]

Since the ->xprt_ctxt pointer was added to svc_deferred_req, it has not
been sufficient to use kfree() to free a deferred request.  We may need
to free the ctxt as well.

As freeing the ctxt is all that ->xpo_release_rqst() does, we repurpose
it to explicit do that even when the ctxt is not stored in an rqst.
So we now have ->xpo_release_ctxt() which is given an xprt and a ctxt,
which may have been taken either from an rqst or from a dreq.  The
caller is now responsible for clearing that pointer after the call to
->xpo_release_ctxt.

We also clear dr->xprt_ctxt when the ctxt is moved into a new rqst when
revisiting a deferred request.  This ensures there is only one pointer
to the ctxt, so the risk of double freeing in future is reduced.  The
new code in svc_xprt_release which releases both the ctxt and any
rq_deferred depends on this.

Fixes: 773f91b2cf ("SUNRPC: Fix NFSD's request deferral on RDMA transports")
Signed-off-by: NeilBrown <neilb@suse.de>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-05-24 17:36:51 +01:00
..
2021-07-21 19:54:21 -07:00
2021-02-02 00:16:57 +01:00
2021-09-20 12:43:34 +01:00
2021-01-23 14:57:21 +01:00
2023-05-24 17:36:47 +01:00
2021-08-29 14:47:42 +03:00
2022-08-17 14:23:11 +02:00
2021-05-06 19:24:11 -07:00
2021-04-14 16:30:30 +03:00
2022-10-26 12:35:12 +02:00
2022-08-31 17:16:34 +02:00
2021-05-24 21:13:05 -07:00
2021-08-16 10:50:32 -06:00
2021-01-24 14:27:17 +01:00
2021-02-26 09:41:03 -08:00
2021-04-08 16:04:20 -07:00
2021-01-21 14:06:00 -07:00
2021-08-26 16:52:03 -07:00
2021-12-14 10:57:11 +01:00
2021-11-25 09:48:41 +01:00
2021-07-20 09:20:49 -07:00
2021-09-07 21:17:28 +02:00
2021-03-22 03:57:39 +01:00
2023-03-30 12:47:50 +02:00
2021-08-26 15:32:28 -04:00
2020-12-10 12:42:59 -06:00
2021-07-27 11:00:36 +02:00
2021-09-06 07:20:56 -04:00
2021-04-12 15:04:23 +02:00
2020-11-16 16:31:41 +01:00
2021-06-25 19:57:01 -04:00
2021-07-26 15:09:44 +02:00
2021-07-27 20:11:45 +01:00
2021-07-27 20:11:44 +01:00
2021-09-03 09:58:13 -07:00
2020-07-24 17:12:41 -07:00
2021-02-11 13:24:44 -08:00
2021-08-05 11:46:42 +01:00
2020-08-04 21:02:38 -04:00
2020-12-02 22:10:35 -08:00
2021-04-30 11:20:40 -07:00
2020-11-23 14:16:55 +00:00
2022-10-26 12:35:26 +02:00
2020-09-16 08:54:53 -05:00
2022-04-13 20:59:03 +02:00
2020-11-24 16:47:48 +01:00
2021-07-27 17:05:06 +01:00
2021-07-27 09:29:15 +02:00
2021-01-21 16:16:10 +00:00
2022-08-17 14:24:08 +02:00
2021-06-01 10:29:21 +01:00
2021-02-26 09:41:03 -08:00
2020-09-04 09:25:20 -07:00
2022-07-12 16:35:08 +02:00
2021-05-12 20:11:17 +02:00
2021-06-17 13:09:27 -04:00
2021-06-15 17:46:57 +02:00
2021-06-29 10:53:53 -07:00
2021-07-01 11:06:05 -07:00
2022-06-09 10:23:32 +02:00
2021-09-17 13:52:17 +01:00
2021-02-26 09:40:59 -08:00
2021-02-03 19:05:50 +01:00
2023-03-17 08:49:02 +01:00
2021-06-16 17:20:40 -05:00
2021-07-06 10:37:46 -05:00
2020-08-31 12:52:33 -07:00
2022-11-03 23:59:15 +09:00
2021-06-07 14:11:47 -07:00
2022-07-02 16:41:17 +02:00
2021-08-18 22:08:24 +02:00
2021-09-02 21:38:56 +02:00
2021-10-07 16:51:57 +02:00
2020-12-03 11:20:52 +01:00
2021-01-16 23:19:26 +01:00
2021-08-17 17:50:51 +02:00
2021-03-18 12:58:27 -04:00
2022-07-12 16:35:08 +02:00
2020-12-10 16:17:15 +01:00
2020-12-10 10:45:36 +01:00
2021-05-10 16:03:35 -07:00
2021-08-06 13:41:48 -07:00
2021-08-19 09:02:55 +09:00
2021-06-24 15:49:32 +02:00
2021-11-21 13:44:12 +01:00
2021-07-01 11:06:03 -07:00
2020-10-30 21:57:04 +01:00
2021-07-27 12:17:21 +02:00
2022-07-29 17:25:32 +02:00
2021-07-27 12:12:08 +02:00
2021-02-13 17:17:53 +01:00
2022-09-15 11:30:05 +02:00
2020-11-09 18:39:36 +01:00
2020-09-10 14:03:31 -07:00
2020-08-19 14:13:20 +02:00
2021-01-21 16:16:10 +00:00
2021-02-09 12:15:07 +01:00
2021-08-11 06:44:24 -04:00
2021-01-21 14:06:00 -07:00
2021-03-30 13:42:33 -04:00
2021-01-24 14:27:17 +01:00
2021-02-08 22:58:55 +01:00