Aleksa Sarai 316a4a329a procfs: block chmod on /proc/thread-self/comm ...

commit ccf61486fe upstream.

Due to an oversight in commit 1b3044e39a ("procfs: fix pthread
cross-thread naming if !PR_DUMPABLE") in switching from REG to NOD,
chmod operations on /proc/thread-self/comm were no longer blocked as
they are on almost all other procfs files.

A very similar situation with /proc/self/environ was used to as a root
exploit a long time ago, but procfs has SB_I_NOEXEC so this is simply a
correctness issue.

Ref: https://lwn.net/Articles/191954/
Ref: 6d76fa58b0 ("Don't allow chmod() on the /proc/<pid>/ files")
Fixes: 1b3044e39a ("procfs: fix pthread cross-thread naming if !PR_DUMPABLE")
Cc: stable@vger.kernel.org # v4.7+
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Message-Id: <20230713141001.27046-1-cyphar@cyphar.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2023-09-13 09:43:02 +02:00

..

array.c

Merge tag 'ucount-rlimits-cleanups-for-v5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace

2022-10-09 16:24:05 -07:00

base.c

procfs: block chmod on /proc/thread-self/comm

2023-09-13 09:43:02 +02:00

bootconfig.c

proc: bootconfig: Add null pointer check

2022-04-02 08:40:09 -04:00

cmdline.c

proc: introduce proc_create_single{,_data}

2018-05-16 07:23:35 +02:00

consoles.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 191

2019-05-30 11:29:21 -07:00

cpuinfo.c

x86/aperfmperf: Replace aperfmperf_get_khz()

2022-04-27 20:22:19 +02:00

devices.c

proc: mark more files as permanent

2022-10-03 14:21:45 -07:00

fd.c

procfs: prevent unprivileged processes accessing fdinfo dir

2022-05-09 17:34:28 -07:00

fd.h

fs: make helpers idmap mount aware

2021-01-24 14:27:20 +01:00

generic.c

proc: fix dentry/inode overinstantiating under /proc/${pid}/net

2022-05-09 18:29:19 -07:00

inode.c

take care to handle NULL ->proc_lseek()

2022-08-14 15:16:18 -04:00

internal.h

Merge tag 'mm-nonmm-stable-2022-10-11' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

2022-10-12 11:00:22 -07:00

interrupts.c

proc: introduce proc_create_seq{,_data}

2018-05-16 07:23:35 +02:00

Kconfig

proc: make config PROC_CHILDREN depend on PROC_FS

2022-10-03 14:21:43 -07:00

kcore.c

fs/proc/kcore.c: remove check of list iterator against head past the loop body

2022-04-29 14:37:59 -07:00

kmsg.c

Merge tag 'printk-for-6.1' of git://git.kernel.org/pub/scm/linux/kernel/git/printk/linux

2022-10-10 11:24:19 -07:00

loadavg.c

proc: mark more files as permanent

2022-10-03 14:21:45 -07:00

Makefile

proc: bootconfig: Add /proc/bootconfig to show boot config list

2020-01-13 13:19:39 -05:00

meminfo.c

proc/meminfo: fix spacing in SecPageTables

2022-11-22 18:50:44 -08:00

namespaces.c

Merge branch 'work.openat2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2020-01-29 11:20:24 -08:00

nommu.c

proc: delete unused <linux/uaccess.h> includes

2022-07-17 17:31:39 -07:00

page.c

proc: mark more files as permanent

2022-10-03 14:21:45 -07:00

proc_net.c

proc: add some (hopefully) insightful comments

2022-07-29 18:12:35 -07:00

proc_sysctl.c

sysctl: clarify register_sysctl_init() base directory order

2023-05-17 11:53:46 +02:00

proc_tty.c

proc: delete unused <linux/uaccess.h> includes

2022-07-17 17:31:39 -07:00

root.c

proc: add some (hopefully) insightful comments

2022-07-29 18:12:35 -07:00

self.c

Revert "proc: don't allow async path resolution of /proc/self components"

2021-02-23 20:32:11 -07:00

softirqs.c

proc: mark more files as permanent

2022-10-03 14:21:45 -07:00

stat.c

fs/proc/uptime.c: Fix idle time reporting in /proc/uptime

2021-10-05 15:51:35 +02:00

task_mmu.c

mm: hugetlb: proc: check for hugetlb shared PMD in /proc/PID/smaps

2023-02-09 11:28:20 +01:00

task_nommu.c

proc: remove VMA rbtree use from nommu

2022-09-26 19:46:16 -07:00

thread_self.c

Revert "proc: don't allow async path resolution of /proc/thread-self components"

2021-02-23 20:32:11 -07:00

uptime.c

proc: mark more files as permanent

2022-10-03 14:21:45 -07:00

util.c

fs/proc/util.c: include fs/proc/internal.h for name_to_int()

2019-01-04 13:13:45 -08:00

version.c

proc: mark more files as permanent

2022-10-03 14:21:45 -07:00

vmcore.c

proc/vmcore: fix signedness bug in read_from_oldmem()

2023-08-03 10:24:14 +02:00