Files
linux/drivers/rtc
Colin Ian King cf4c7b3ab6 rtc: tx4939: avoid unintended sign extension on a 24 bit shift
[ Upstream commit 347876ad47 ]

The shifting of buf[5] by 24 bits to the left will be promoted to
a 32 bit signed int and then sign-extended to an unsigned long. If
the top bit of buf[5] is set then all then all the upper bits sec
end up as also being set because of the sign-extension. Fix this by
casting buf[5] to an unsigned long before the shift.

Detected by CoverityScan, CID#1465292 ("Unintended sign extension")

Fixes: 0e1492330c ("rtc: add rtc-tx4939 driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-05-30 07:49:14 +02:00
..
2015-09-05 19:37:31 +02:00
2015-09-05 19:37:18 +02:00
2015-06-25 01:13:44 +02:00
2015-09-05 13:19:06 +02:00
2015-08-05 20:03:56 +08:00
2016-05-04 14:48:52 -07:00
2013-04-19 13:51:25 +02:00
2015-09-05 19:37:19 +02:00