Hangbin Liu
6e9334436d
net: use struct_group to copy ip/ipv6 header addresses
...
[ Upstream commit 58e0be1ef6 ]
kernel test robot reported warnings when build bonding module with
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/bonding/:
from ../drivers/net/bonding/bond_main.c:35:
In function ‘fortify_memcpy_chk’,
inlined from ‘iph_to_flow_copy_v4addrs’ at ../include/net/ip.h:566:2,
inlined from ‘bond_flow_ip’ at ../drivers/net/bonding/bond_main.c:3984:3:
../include/linux/fortify-string.h:413:25: warning: call to ‘__read_overflow2_field’ declared with attribute warning: detected read beyond size of f
ield (2nd parameter); maybe use struct_group()? [-Wattribute-warning]
413 | __read_overflow2_field(q_size_field, size);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘fortify_memcpy_chk’,
inlined from ‘iph_to_flow_copy_v6addrs’ at ../include/net/ipv6.h:900:2,
inlined from ‘bond_flow_ip’ at ../drivers/net/bonding/bond_main.c:3994:3:
../include/linux/fortify-string.h:413:25: warning: call to ‘__read_overflow2_field’ declared with attribute warning: detected read beyond size of f
ield (2nd parameter); maybe use struct_group()? [-Wattribute-warning]
413 | __read_overflow2_field(q_size_field, size);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This is because we try to copy the whole ip/ip6 address to the flow_key,
while we only point the to ip/ip6 saddr. Note that since these are UAPI
headers, __struct_group() is used to avoid the compiler warnings.
Reported-by: kernel test robot <lkp@intel.com >
Fixes: c3f8324188 ("net: Add full IPv6 addresses to flow_keys")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com >
Link: https://lore.kernel.org/r/20221115142400.1204786-1-liuhangbin@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com >
Signed-off-by: Sasha Levin <sashal@kernel.org >
2022-11-25 17:45:55 +01:00
..
2020-07-15 20:34:11 -07:00
2022-08-03 12:00:43 +02:00
2021-06-10 13:39:24 +02:00
2020-05-19 12:50:14 -07:00
2022-08-31 17:15:18 +02:00
2022-05-25 09:17:58 +02:00
2021-11-26 10:39:18 +01:00
2019-06-05 17:37:07 +02:00
2022-01-05 12:40:30 +01:00
2022-05-18 10:23:44 +02:00
2020-02-28 14:51:30 +01:00
2021-04-14 08:42:05 +02:00
2022-08-03 12:00:46 +02:00
2019-05-30 11:26:41 -07:00
2020-08-20 18:21:28 +01:00
2020-02-28 12:12:53 -08:00
2022-03-23 09:13:27 +01:00
2017-11-02 11:10:55 +01:00
2022-04-13 21:00:57 +02:00
2017-11-02 11:10:55 +01:00
2022-04-20 09:23:31 +02:00
2019-06-19 17:09:55 +02:00
2020-07-21 18:30:47 -07:00
2022-09-28 11:10:31 +02:00
2021-12-14 11:32:36 +01:00
2019-07-04 12:30:48 -07:00
2022-09-28 11:10:31 +02:00
2020-09-25 13:58:01 -07:00
2022-08-31 17:15:20 +02:00
2019-05-21 11:28:45 +02:00
2019-06-19 17:09:55 +02:00
2021-11-02 19:48:20 +01:00
2020-02-29 14:39:08 +01:00
2022-03-02 11:42:50 +01:00
2020-07-15 07:45:24 -07:00
2020-03-27 19:40:38 -07:00
2016-04-25 16:44:27 -04:00
2016-06-25 12:19:35 -04:00
2016-04-25 16:44:27 -04:00
2020-07-19 18:16:40 -07:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:29:52 -07:00
2019-05-30 11:29:52 -07:00
2020-10-09 12:06:53 -07:00
2017-11-02 11:10:55 +01:00
2020-02-29 21:52:20 -08:00
2017-11-02 11:10:55 +01:00
2019-05-21 11:52:39 +02:00
2019-05-21 11:52:39 +02:00
2017-11-04 09:26:51 +09:00
2020-10-05 05:56:48 -07:00
2019-12-16 16:09:44 -08:00
2021-12-08 09:03:22 +01:00
2022-02-16 12:54:26 +01:00
2020-05-08 21:33:33 -07:00
2021-03-30 14:32:05 +02:00
2020-05-05 13:23:29 -07:00
2022-04-27 13:53:48 +02:00
2020-04-20 07:34:16 +02:00
2019-06-19 17:09:55 +02:00
2018-05-28 22:59:54 -04:00
2019-12-24 22:37:30 -08:00
2021-12-08 09:03:21 +01:00
2017-11-02 11:10:55 +01:00
2022-04-20 09:23:11 +02:00
2022-06-14 18:32:40 +02:00
2022-06-09 10:21:09 +02:00
2017-11-02 11:10:55 +01:00
2020-07-31 09:24:24 +02:00
2020-07-31 09:24:24 +02:00
2019-12-09 10:36:44 -08:00
2019-11-05 18:20:55 -08:00
2020-10-05 18:40:01 -07:00
2019-03-22 12:09:31 -07:00
2018-12-10 15:53:04 -08:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-06-22 21:12:44 -07:00
2019-10-25 16:24:32 -07:00
2021-03-04 11:38:46 +01:00
2020-07-31 09:27:00 +02:00
2022-10-26 13:25:55 +02:00
2022-06-09 10:20:50 +02:00
2019-04-22 21:50:53 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2022-08-21 15:15:51 +02:00
2020-05-09 00:48:20 +02:00
2022-08-03 12:00:45 +02:00
2020-12-01 17:16:54 -08:00
2022-01-27 10:54:33 +01:00
2022-08-21 15:15:51 +02:00
2022-08-21 15:15:51 +02:00
2019-09-27 12:05:02 +02:00
2019-02-08 21:50:15 -08:00
2020-06-20 17:47:53 -07:00
2022-02-01 17:25:44 +01:00
2021-08-12 13:22:07 +02:00
2022-05-09 09:05:04 +02:00
2021-12-08 09:03:26 +01:00
2022-05-09 09:05:04 +02:00
2020-08-31 23:06:51 +02:00
2022-11-25 17:45:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2022-01-27 10:54:33 +01:00
2021-12-01 09:19:05 +01:00
2022-11-25 17:45:55 +01:00
2020-02-05 14:28:09 +01:00
2018-03-27 09:51:23 +02:00
2019-06-19 17:09:55 +02:00
2020-06-20 17:22:22 -07:00
2018-07-11 23:10:19 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-25 12:06:25 +09:00
2019-10-08 13:23:05 -07:00
2021-08-04 12:46:43 +02:00
2021-11-18 14:04:27 +01:00
2020-03-29 22:30:57 -07:00
2021-06-23 14:42:52 +02:00
2019-05-30 11:26:41 -07:00
2021-07-14 16:56:28 +02:00
2020-03-02 11:16:27 -08:00
2020-02-29 21:52:20 -08:00
2020-02-28 12:08:37 -08:00
2020-05-29 21:20:20 -07:00
2020-09-24 20:17:01 -07:00
2019-12-09 10:36:44 -08:00
2017-11-02 11:10:55 +01:00
2020-08-24 06:40:07 -07:00
2021-11-18 14:04:29 +01:00
2018-05-28 22:59:54 -04:00
2021-06-23 14:42:44 +02:00
2017-11-02 11:10:55 +01:00
2018-08-01 09:52:30 -07:00
2019-05-21 11:28:45 +02:00
2020-10-09 20:22:32 -07:00
2019-11-12 08:18:03 -08:00
2019-04-11 13:59:49 -07:00
2021-10-06 15:55:53 +02:00
2021-12-01 09:19:03 +01:00
2017-11-08 16:12:33 +09:00
2017-11-02 11:10:55 +01:00
2021-05-19 10:13:17 +02:00
2020-03-04 13:25:55 -08:00
2019-05-30 11:26:32 -07:00
2021-06-03 09:00:51 +02:00
2021-10-17 10:43:33 +02:00
2017-11-02 11:10:55 +01:00
2022-11-10 18:14:26 +01:00
2021-08-18 08:59:11 +02:00
2017-11-02 11:10:55 +01:00
2022-07-21 21:20:10 +02:00
2017-11-02 11:10:55 +01:00
2021-04-14 08:42:07 +02:00
2020-07-31 09:24:23 +02:00
2020-08-24 14:35:00 -07:00
2018-05-16 07:23:35 +02:00
2022-06-09 10:21:09 +02:00
2020-06-23 20:27:09 -07:00
2018-03-13 18:37:02 +02:00
2021-03-30 14:32:08 +02:00
2019-04-22 21:47:25 -07:00
2022-10-30 09:41:17 +01:00
2020-07-13 11:03:44 -07:00
2022-05-30 09:33:23 +02:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-06-04 15:39:32 -07:00
2018-04-11 10:33:46 -04:00
2020-09-28 15:19:03 -07:00
2019-10-05 16:29:00 -07:00
2022-10-30 09:41:19 +01:00
2022-10-26 13:25:56 +02:00
2018-03-01 21:21:36 -05:00
2017-11-02 11:10:55 +01:00
2021-11-18 14:04:27 +01:00
2021-02-17 11:02:29 +01:00
2019-05-30 11:26:32 -07:00
2022-11-10 18:14:26 +01:00
2019-05-30 11:26:32 -07:00
2018-05-08 00:02:41 -04:00
2019-10-04 14:07:07 -07:00
2022-07-21 21:20:13 +02:00
2020-06-23 20:10:15 -07:00
2020-06-18 20:46:23 -07:00
2017-08-29 15:16:52 -07:00
2022-04-08 14:39:54 +02:00
2022-11-10 18:14:26 +01:00
2018-02-16 15:57:42 -05:00
2019-11-14 18:12:17 -08:00
2020-09-14 16:49:39 -07:00
2018-01-24 19:13:45 -05:00
2020-07-15 20:34:02 -07:00
2019-12-09 10:28:43 -08:00
2017-11-02 11:10:55 +01:00
2019-11-16 12:39:10 -08:00
2020-08-31 21:15:04 +02:00
2021-01-17 14:17:05 +01:00
2020-12-09 16:27:42 +01:00
2022-05-25 09:17:58 +02:00
2022-10-15 07:55:51 +02:00