Files
linux/include/net
Florian Westphal fe20f21e5b netfilter: nf_tables: fix destination register zeroing
[ Upstream commit 1e105e6afa ]

Following bug was reported via irc:
nft list ruleset
   set knock_candidates_ipv4 {
      type ipv4_addr . inet_service
      size 65535
      elements = { 127.0.0.1 . 123,
                   127.0.0.1 . 123 }
      }
 ..
   udp dport 123 add @knock_candidates_ipv4 { ip saddr . 123 }
   udp dport 123 add @knock_candidates_ipv4 { ip saddr . udp dport }

It should not have been possible to add a duplicate set entry.

After some debugging it turned out that the problem is the immediate
value (123) in the second-to-last rule.

Concatenations use 32bit registers, i.e. the elements are 8 bytes each,
not 6 and it turns out the kernel inserted

inet firewall @knock_candidates_ipv4
        element 0100007f ffff7b00  : 0 [end]
        element 0100007f 00007b00  : 0 [end]

Note the non-zero upper bits of the first element.  It turns out that
nft_immediate doesn't zero the destination register, but this is needed
when the length isn't a multiple of 4.

Furthermore, the zeroing in nft_payload is broken.  We can't use
[len / 4] = 0 -- if len is a multiple of 4, index is off by one.

Skip zeroing in this case and use a conditional instead of (len -1) / 4.

Fixes: 49499c3e6e ("netfilter: nf_tables: switch registers to 32 bit addressing")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-05-16 09:04:25 +09:00
..
2023-05-15 12:38:05 +09:00
2023-05-15 08:24:46 +09:00
2023-05-15 12:05:35 +09:00
2014-09-18 10:54:36 +02:00
2023-05-15 11:43:44 +09:00
2023-05-15 09:01:44 +09:00
2015-11-18 16:17:38 -05:00
2016-06-27 15:06:17 -04:00
2016-07-08 12:20:57 +02:00
2016-04-25 16:44:27 -04:00
2016-04-25 16:44:27 -04:00
2016-06-09 23:41:03 -07:00
2015-03-06 21:50:02 -05:00
2016-08-26 11:55:18 -07:00
2015-09-17 17:18:37 -07:00
2016-09-23 08:38:50 -04:00
2016-02-16 20:21:48 -05:00
2013-11-07 19:28:58 -05:00
2016-05-20 18:03:16 -04:00
2023-05-15 14:57:24 +09:00
2023-05-16 08:30:10 +09:00
2023-05-15 11:50:01 +09:00
2016-10-14 10:59:15 -04:00
2016-05-20 18:03:17 -04:00
2016-08-17 19:36:23 -04:00
2023-05-15 15:09:01 +09:00
2015-10-23 06:26:42 -07:00
2016-10-03 02:00:22 -04:00
2016-10-04 02:11:51 -04:00
2016-06-15 20:41:23 -07:00
2018-05-16 10:08:41 +02:00
2016-07-08 12:20:57 +02:00
2016-03-23 22:09:58 -04:00
2016-04-07 16:53:30 -04:00
2018-02-25 11:05:48 +01:00
2018-05-30 13:19:56 +02:00
2014-06-02 11:00:41 -07:00
2015-03-12 22:58:12 -04:00
2023-05-15 17:22:55 +09:00
2016-05-03 16:08:14 -04:00
2015-10-26 22:24:22 -07:00
2017-07-21 07:42:18 +02:00
2023-05-15 14:29:05 +09:00