Files
linux/fs
Josef Bacik bf67802453 btrfs: set cache_block_group_error if we find an error
commit 92fb94b69c upstream.

We set cache_block_group_error if btrfs_cache_block_group() returns an
error, this is because we could end up not finding space to allocate and
mistakenly return -ENOSPC, and which could then abort the transaction
with the incorrect errno, and in the case of ENOSPC result in a
WARN_ON() that will trip up tests like generic/475.

However there's the case where multiple threads can be racing, one
thread gets the proper error, and the other thread doesn't actually call
btrfs_cache_block_group(), it instead sees ->cached ==
BTRFS_CACHE_ERROR.  Again the result is the same, we fail to allocate
our space and return -ENOSPC.  Instead we need to set
cache_block_group_error to -EIO in this case to make sure that if we do
not make our allocation we get the appropriate error returned back to
the caller.

CC: stable@vger.kernel.org # 4.14+
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-08-16 18:27:30 +02:00
..
2023-08-11 12:08:24 +02:00
2022-05-09 16:21:45 -04:00
2022-09-24 07:00:00 +02:00
2023-07-19 16:21:03 +02:00
2023-07-27 08:50:32 +02:00
2022-05-09 16:21:46 -04:00
2023-05-11 23:03:05 +09:00
2022-09-11 20:26:07 -07:00
2023-02-22 12:59:46 +01:00
2022-09-24 07:00:00 +02:00
2022-08-20 11:34:33 -04:00
2023-07-19 16:22:15 +02:00
2023-01-04 11:29:01 +01:00
2022-06-28 13:58:05 -04:00