Files
linux/fs
Al Viro 5772d851bc ecryptfs_lookup_interpose(): lower_dentry->d_parent is not stable either
commit 762c69685f upstream.

We need to get the underlying dentry of parent; sure, absent the races
it is the parent of underlying dentry, but there's nothing to prevent
losing a timeslice to preemtion in the middle of evaluation of
lower_dentry->d_parent->d_inode, having another process move lower_dentry
around and have its (ex)parent not pinned anymore and freed on memory
pressure.  Then we regain CPU and try to fetch ->d_inode from memory
that is freed by that point.

dentry->d_parent *is* stable here - it's an argument of ->lookup() and
we are guaranteed that it won't be moved anywhere until we feed it
to d_add/d_splice_alias.  So we safely go that way to get to its
underlying dentry.

Cc: stable@vger.kernel.org # since 2009 or so
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-11-25 09:51:57 +01:00
..
2019-08-06 18:29:38 +02:00
2016-05-20 17:58:30 -07:00
2019-05-31 06:48:13 -07:00
2018-12-17 09:38:35 +01:00
2017-11-30 08:39:04 +00:00
2019-03-13 14:04:52 -07:00
2018-12-21 14:11:31 +01:00
2016-09-27 21:20:53 -04:00
2016-06-21 09:23:11 +10:00
2018-02-17 13:21:15 +01:00
2017-06-14 15:06:01 +02:00