Anand Jain
40554fa41a
btrfs: replace: drop assert for suspended replace
...
commit 59a3991984 upstream.
If the filesystem mounts with the replace-operation in a suspended state
and try to cancel the suspended replace-operation, we hit the assert. The
assert came from the commit fe97e2e173 ("btrfs: dev-replace: replace's
scrub must not be running in suspended state") that was actually not
required. So just remove it.
$ mount /dev/sda5 /btrfs
BTRFS info (device sda5): cannot continue dev_replace, tgtdev is missing
BTRFS info (device sda5): you may cancel the operation after 'mount -o degraded'
$ mount -o degraded /dev/sda5 /btrfs <-- success.
$ btrfs replace cancel /btrfs
kernel: assertion failed: ret != -ENOTCONN, in fs/btrfs/dev-replace.c:1131
kernel: ------------[ cut here ]------------
kernel: kernel BUG at fs/btrfs/ctree.h:3750!
After the patch:
$ btrfs replace cancel /btrfs
BTRFS info (device sda5): suspended dev_replace from /dev/sda5 (devid 1) to <missing disk> canceled
Fixes: fe97e2e173 ("btrfs: dev-replace: replace's scrub must not be running in suspended state")
CC: stable@vger.kernel.org # 5.0+
Signed-off-by: Anand Jain <anand.jain@oracle.com >
Signed-off-by: David Sterba <dsterba@suse.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2022-09-05 10:27:43 +02:00
..
2022-06-22 14:11:02 +02:00
2019-07-19 11:33:22 -07:00
2021-03-04 10:26:48 +01:00
2022-06-29 08:58:46 +02:00
2019-10-25 00:03:11 -04:00
2019-08-30 07:27:17 -07:00
2021-01-06 14:48:39 +01:00
2022-09-05 10:27:43 +02:00
2020-11-05 11:43:36 +01:00
2022-06-14 18:12:01 +02:00
2022-08-25 11:18:38 +02:00
2019-09-19 09:42:37 -07:00
2022-03-02 11:41:10 +01:00
2019-11-23 21:44:49 -05:00
2021-09-12 08:56:38 +02:00
2022-01-27 09:19:36 +01:00
2022-02-01 17:24:34 +01:00
2022-07-29 17:14:16 +02:00
2021-05-26 12:05:19 +02:00
2020-12-02 08:49:53 +01:00
2019-08-30 07:27:17 -07:00
2022-08-25 11:17:36 +02:00
2019-11-10 11:56:05 -05:00
2022-08-25 11:17:28 +02:00
2022-08-25 11:18:35 +02:00
2022-08-25 11:18:38 +02:00
2022-06-14 18:11:30 +02:00
2019-08-30 07:27:17 -07:00
2021-09-22 12:26:25 +02:00
2022-08-25 11:18:05 +02:00
2022-05-18 09:47:26 +02:00
2021-07-31 08:19:38 +02:00
2021-05-19 10:08:29 +02:00
2021-04-14 08:24:14 +02:00
2019-08-30 08:11:25 -07:00
2022-05-09 09:03:28 +02:00
2022-06-14 18:11:36 +02:00
2021-11-12 14:43:03 +01:00
2022-08-25 11:18:00 +02:00
2022-06-14 18:11:55 +02:00
2022-06-14 18:11:29 +02:00
2022-06-14 18:12:00 +02:00
2021-09-22 12:26:34 +02:00
2022-04-15 14:18:35 +02:00
2022-08-25 11:18:22 +02:00
2020-12-30 11:51:22 +01:00
2022-06-06 08:33:51 +02:00
2022-07-21 20:59:18 +02:00
2022-06-14 18:11:34 +02:00
2022-08-03 11:59:37 +02:00
2022-06-14 18:11:46 +02:00
2019-08-30 08:11:25 -07:00
2019-07-19 10:42:02 -07:00
2022-01-20 09:19:17 +01:00
2022-08-25 11:17:23 +02:00
2022-06-14 18:11:41 +02:00
2021-03-04 10:26:45 +01:00
2021-09-30 10:09:26 +02:00
2019-08-30 07:27:17 -07:00
2022-02-23 11:59:55 +01:00
2020-10-29 09:57:53 +01:00
2021-08-12 13:21:05 +02:00
2020-08-26 10:40:51 +02:00
2021-05-19 10:08:29 +02:00
2021-03-07 12:20:48 +01:00
2019-08-30 07:27:18 -07:00
2022-03-02 11:41:13 +01:00
2022-04-15 14:18:31 +02:00
2022-02-01 17:24:34 +01:00
2020-08-21 13:05:37 +02:00
2019-09-17 11:48:24 -04:00
2021-10-06 15:42:30 +02:00
2022-07-12 16:30:48 +02:00
2021-12-14 14:49:02 +01:00
2019-07-19 10:42:02 -07:00
2022-08-25 11:17:21 +02:00
2021-10-06 15:42:35 +02:00
2022-06-14 18:11:23 +02:00
2021-03-17 17:03:57 +01:00
2021-05-22 11:38:29 +02:00
2020-11-05 11:43:24 +01:00
2020-01-14 20:08:18 +01:00
2022-06-22 14:11:03 +02:00
2020-12-11 13:23:30 +01:00
2020-10-29 09:57:45 +01:00
2022-06-14 18:11:41 +02:00
2020-10-01 13:17:19 +02:00
2021-04-14 08:24:11 +02:00
2020-01-12 12:21:37 +01:00
2020-02-11 04:35:37 -08:00
2022-08-25 11:17:28 +02:00
2022-06-06 08:33:50 +02:00
2021-09-15 09:47:28 +02:00
2019-08-07 21:51:47 -04:00
2022-05-25 09:14:34 +02:00
2022-03-02 11:41:18 +01:00
2020-04-17 10:50:21 +02:00
2022-02-08 18:24:29 +01:00
2019-09-12 21:06:14 -04:00
2019-07-16 22:52:37 -04:00
2022-06-14 18:11:44 +02:00
2019-07-19 10:42:02 -07:00
2020-03-25 08:25:58 +01:00
2021-07-31 08:19:37 +02:00
2022-04-15 14:18:41 +02:00
2019-12-17 19:55:30 +01:00
2019-09-18 16:59:14 -07:00
2020-11-24 13:29:19 +01:00
2020-03-25 08:25:41 +01:00
2019-09-18 16:59:14 -07:00
2019-07-16 22:52:37 -04:00
2020-01-17 19:48:21 +01:00
2022-08-25 11:17:22 +02:00
2021-08-26 08:36:22 -04:00
2020-03-18 07:17:51 +01:00
2021-08-12 13:21:02 +02:00
2020-05-02 08:48:44 +02:00
2021-03-17 17:03:33 +01:00
2019-09-06 21:28:49 +02:00
2020-02-11 04:35:23 -08:00
2021-04-21 12:56:16 +02:00
2022-01-29 10:25:11 +01:00
2021-07-20 16:10:54 +02:00
2021-12-14 14:49:02 +01:00
2022-08-25 11:17:44 +02:00
2022-04-27 13:50:48 +02:00
2019-10-03 14:21:35 -07:00
2022-02-23 11:59:55 +01:00
2019-08-01 20:51:23 +02:00
2021-09-22 12:26:26 +02:00
2020-02-11 04:35:12 -08:00
2020-08-11 15:33:39 +02:00