Ma Wupeng
93df6da64b
hwpoison, memory_hotplug: lock folio before unmap hwpoisoned folio
commit af288a426c3e3552b62595c6138ec6371a17dbba upstream.
Commit b15c87263a ("hwpoison, memory_hotplug: allow hwpoisoned pages to
be offlined) add page poison checks in do_migrate_range in order to make
offline hwpoisoned page possible by introducing isolate_lru_page and
try_to_unmap for hwpoisoned page. However folio lock must be held before
calling try_to_unmap. Add it to fix this problem.
Warning will be produced if folio is not locked during unmap:
------------[ cut here ]------------
kernel BUG at ./include/linux/swapops.h:400!
Internal error: Oops - BUG: 00000000f2000800 [#1] PREEMPT SMP
Modules linked in:
CPU: 4 UID: 0 PID: 411 Comm: bash Tainted: G W 6.13.0-rc1-00016-g3c434c7ee82a-dirty #41
Tainted: [W]=WARN
Hardware name: QEMU QEMU Virtual Machine, BIOS 0.0.0 02/06/2015
pstate: 40400005 (nZcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : try_to_unmap_one+0xb08/0xd3c
lr : try_to_unmap_one+0x3dc/0xd3c
Call trace:
try_to_unmap_one+0xb08/0xd3c (P)
try_to_unmap_one+0x3dc/0xd3c (L)
rmap_walk_anon+0xdc/0x1f8
rmap_walk+0x3c/0x58
try_to_unmap+0x88/0x90
unmap_poisoned_folio+0x30/0xa8
do_migrate_range+0x4a0/0x568
offline_pages+0x5a4/0x670
memory_block_action+0x17c/0x374
memory_subsys_offline+0x3c/0x78
device_offline+0xa4/0xd0
state_store+0x8c/0xf0
dev_attr_store+0x18/0x2c
sysfs_kf_write+0x44/0x54
kernfs_fop_write_iter+0x118/0x1a8
vfs_write+0x3a8/0x4bc
ksys_write+0x6c/0xf8
__arm64_sys_write+0x1c/0x28
invoke_syscall+0x44/0x100
el0_svc_common.constprop.0+0x40/0xe0
do_el0_svc+0x1c/0x28
el0_svc+0x30/0xd0
el0t_64_sync_handler+0xc8/0xcc
el0t_64_sync+0x198/0x19c
Code: f9407be0 b5fff320 d4210000 17ffff97 (d4210000)
---[ end trace 0000000000000000 ]---
Link: https://lkml.kernel.org/r/20250217014329.3610326-4-mawupeng1@huawei.com
Fixes: b15c87263a ("hwpoison, memory_hotplug: allow hwpoisoned pages to be offlined")
Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
Acked-by: David Hildenbrand <david@redhat.com>
Acked-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Naoya Horiguchi <nao.horiguchi@gmail.com>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Xiangyu Chen <xiangyu.chen@windriver.com>
Signed-off-by: He Zhe <zhe.he@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-05-22 14:12:25 +02:00
..
2024-12-14 20:00:21 +01:00
2024-12-14 19:59:57 +01:00
2025-02-17 09:40:32 +01:00
2025-03-13 12:58:27 +01:00
2024-02-23 09:25:16 +01:00
2024-06-16 13:47:42 +02:00
2025-03-13 12:58:27 +01:00
2023-06-09 16:25:23 -07:00
2024-08-19 06:04:31 +02:00
2023-06-09 16:25:31 -07:00
2023-06-09 16:25:17 -07:00
2023-06-09 16:25:56 -07:00
2023-06-23 16:59:31 -07:00
2023-06-09 16:25:23 -07:00
2025-04-25 10:45:48 +02:00
2023-07-24 18:04:30 -04:00
2023-06-23 16:58:19 -07:00
2025-04-25 10:45:48 +02:00
2023-06-19 16:19:25 -07:00
2023-08-21 13:07:20 -07:00
2024-11-17 15:08:59 +01:00
2023-08-18 10:12:14 -07:00
2025-04-25 10:45:32 +02:00
2023-08-21 13:37:46 -07:00
2024-12-09 10:32:59 +01:00
2023-08-18 10:12:36 -07:00
2024-10-10 11:58:02 +02:00
2023-05-29 16:14:28 +01:00
2024-11-01 01:58:26 +01:00
2025-02-17 09:40:35 +01:00
2024-06-16 13:47:41 +02:00
2025-02-27 04:10:52 -08:00
2023-08-29 14:25:26 -07:00
2023-08-24 16:20:30 -07:00
2025-05-22 14:12:25 +02:00
2025-02-27 04:10:45 -08:00
2023-09-05 11:11:52 -07:00
2025-05-22 14:12:25 +02:00
2025-04-25 10:45:31 +02:00
2023-08-18 10:12:38 -07:00
2025-04-25 10:45:48 +02:00
2024-12-14 20:00:18 +01:00
2024-04-03 15:28:33 +02:00
2023-08-31 12:20:12 -07:00
2025-05-22 14:12:25 +02:00
2023-08-21 13:07:20 -07:00
2023-08-21 14:26:20 -07:00
2024-01-31 16:18:56 -08:00
2024-08-03 08:54:12 +02:00
2025-03-22 12:50:48 -07:00
2023-08-24 16:20:30 -07:00
2023-08-18 10:12:41 -07:00
2024-11-22 15:38:37 +01:00
2025-04-25 10:45:31 +02:00
2025-03-22 12:50:44 -07:00
2025-02-27 04:10:45 -08:00
2025-05-22 14:12:24 +02:00
2023-08-18 10:12:31 -07:00
2023-08-21 13:37:27 -07:00
2023-08-18 10:12:39 -07:00
2023-08-21 13:37:27 -07:00
2023-08-21 13:37:30 -07:00
2024-05-02 16:32:41 +02:00
2024-08-19 06:04:29 +02:00
2025-04-25 10:45:31 +02:00
2024-07-11 12:49:16 +02:00
2023-09-02 08:39:21 -07:00
2023-06-19 16:19:29 -07:00
2024-02-16 19:10:52 +01:00
2024-06-16 13:47:40 +02:00
2023-06-09 16:25:25 -07:00
2023-06-19 16:19:24 -07:00
2025-01-09 13:32:08 +01:00
2025-04-25 10:45:31 +02:00
2024-10-17 15:24:37 +02:00
2024-04-03 15:28:54 +02:00
2025-02-01 18:37:54 +01:00
2024-05-02 16:32:41 +02:00
2023-06-19 13:19:34 -07:00
2024-11-17 15:08:58 +01:00
2023-07-18 10:07:47 +02:00
2024-12-09 10:33:06 +01:00
2024-12-09 10:33:06 +01:00
2023-08-18 10:12:53 -07:00
2024-09-12 11:11:25 +02:00
2023-08-24 16:20:28 -07:00
2024-12-14 19:59:51 +01:00
2024-03-01 13:35:00 +01:00
2024-10-22 15:46:21 +02:00
2024-09-04 13:28:23 +02:00
2024-09-12 11:11:27 +02:00
2024-10-04 16:30:02 +02:00
2025-03-13 12:58:28 +01:00
2023-08-16 12:21:32 +01:00
2025-04-25 10:45:31 +02:00
2024-12-09 10:33:05 +01:00
2024-06-16 13:47:31 +02:00
2023-08-21 13:37:51 -07:00
2023-06-19 16:19:27 -07:00
2023-06-19 16:19:27 -07:00
2023-08-21 14:26:20 -07:00
2024-03-01 13:35:10 +01:00