Liu Shixin via Jfs-discussion
4de3a60301
jfs: fix invalid free of JFS_IP(ipimap)->i_imap in diUnmount
[ Upstream commit 6e2bda2c19 ]
syzbot found an invalid-free in diUnmount:
BUG: KASAN: double-free in slab_free mm/slub.c:3661 [inline]
BUG: KASAN: double-free in __kmem_cache_free+0x71/0x110 mm/slub.c:3674
Free of addr ffff88806f410000 by task syz-executor131/3632
CPU: 0 PID: 3632 Comm: syz-executor131 Not tainted 6.1.0-rc7-syzkaller-00012-gca57f02295f1 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1b1/0x28e lib/dump_stack.c:106
print_address_description+0x74/0x340 mm/kasan/report.c:284
print_report+0x107/0x1f0 mm/kasan/report.c:395
kasan_report_invalid_free+0xac/0xd0 mm/kasan/report.c:460
____kasan_slab_free+0xfb/0x120
kasan_slab_free include/linux/kasan.h:177 [inline]
slab_free_hook mm/slub.c:1724 [inline]
slab_free_freelist_hook+0x12e/0x1a0 mm/slub.c:1750
slab_free mm/slub.c:3661 [inline]
__kmem_cache_free+0x71/0x110 mm/slub.c:3674
diUnmount+0xef/0x100 fs/jfs/jfs_imap.c:195
jfs_umount+0x108/0x370 fs/jfs/jfs_umount.c:63
jfs_put_super+0x86/0x190 fs/jfs/super.c:194
generic_shutdown_super+0x130/0x310 fs/super.c:492
kill_block_super+0x79/0xd0 fs/super.c:1428
deactivate_locked_super+0xa7/0xf0 fs/super.c:332
cleanup_mnt+0x494/0x520 fs/namespace.c:1186
task_work_run+0x243/0x300 kernel/task_work.c:179
exit_task_work include/linux/task_work.h:38 [inline]
do_exit+0x664/0x2070 kernel/exit.c:820
do_group_exit+0x1fd/0x2b0 kernel/exit.c:950
__do_sys_exit_group kernel/exit.c:961 [inline]
__se_sys_exit_group kernel/exit.c:959 [inline]
__x64_sys_exit_group+0x3b/0x40 kernel/exit.c:959
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
[...]
JFS_IP(ipimap)->i_imap is not setting to NULL after free in diUnmount.
If jfs_remount() free JFS_IP(ipimap)->i_imap but then failed at diMount().
JFS_IP(ipimap)->i_imap will be freed once again.
Fix this problem by setting JFS_IP(ipimap)->i_imap to NULL after free.
Reported-by: syzbot+90a11e6b1e810785c6ff@syzkaller.appspotmail.com
Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-09-23 11:11:05 +02:00
..
2023-02-09 11:28:04 +01:00
2022-05-09 16:21:44 -04:00
2023-02-01 08:34:08 +01:00
2023-07-19 16:22:06 +02:00
2023-09-23 11:10:59 +02:00
2022-08-02 12:34:03 -04:00
2022-05-09 16:21:44 -04:00
2023-09-23 11:10:59 +02:00
2022-09-24 07:00:00 +02:00
2023-08-23 17:52:25 +02:00
2023-03-10 09:33:52 +01:00
2022-12-31 13:32:22 +01:00
2023-03-10 09:34:09 +01:00
2023-05-11 23:03:00 +09:00
2022-12-31 13:31:58 +01:00
2022-01-24 14:17:02 +01:00
2023-09-13 09:43:02 +02:00
2022-10-06 17:31:02 -07:00
2022-10-21 11:09:40 +02:00
2022-05-09 16:21:45 -04:00
2023-09-06 21:26:59 +01:00
2023-08-11 12:08:26 +02:00
2022-08-17 17:25:04 -04:00
2023-09-23 11:11:05 +02:00
2023-09-19 12:28:05 +02:00
2023-09-19 12:28:05 +02:00
2022-10-11 17:42:58 -06:00
2022-08-02 12:34:03 -04:00
2023-02-22 12:59:43 +01:00
2023-09-19 12:28:05 +02:00
2023-09-19 12:27:58 +02:00
2023-03-10 09:34:07 +01:00
2023-05-24 17:32:34 +01:00
2022-09-19 22:46:25 +02:00
2022-05-09 16:21:45 -04:00
2022-12-31 13:33:05 +01:00
2023-09-13 09:42:27 +02:00
2022-10-12 11:00:22 -07:00
2023-09-19 12:28:05 +02:00
2023-07-19 16:22:11 +02:00
2023-09-23 11:11:05 +02:00
2023-07-19 16:21:53 +02:00
2023-09-13 09:42:49 +02:00
2022-09-24 07:00:00 +02:00
2023-02-09 11:28:04 +01:00
2023-09-19 12:27:58 +02:00
2021-10-04 22:02:17 +01:00
2023-09-13 09:42:49 +02:00
2023-09-06 21:27:03 +01:00
2023-09-13 09:42:22 +02:00
2023-07-19 16:22:05 +02:00
2022-10-12 11:00:22 -07:00
2023-08-23 17:52:26 +02:00
2023-09-13 09:42:33 +02:00
2022-05-09 16:21:44 -04:00
2022-03-22 15:57:03 -07:00
2023-02-09 11:28:04 +01:00
2023-09-13 09:42:23 +02:00
2023-09-13 09:43:02 +02:00
2023-09-13 09:43:03 +02:00
2022-05-09 16:21:44 -04:00
2022-09-11 21:55:07 -07:00
2023-09-13 09:42:36 +02:00
2023-07-19 16:22:11 +02:00
2023-09-13 09:42:27 +02:00
2022-05-09 16:21:46 -04:00
2023-09-19 12:28:00 +02:00
2023-02-22 12:59:50 +01:00
2022-04-05 15:39:19 +02:00
2023-08-11 12:08:23 +02:00
2022-09-08 17:10:54 -04:00
2023-05-11 23:03:05 +09:00
2023-09-13 09:43:05 +02:00
2022-09-11 20:26:07 -07:00
2022-02-14 10:37:32 +09:00
2022-05-09 16:21:46 -04:00
2023-09-13 09:43:03 +02:00
2023-07-19 16:22:15 +02:00
2023-04-06 12:10:52 +02:00
2023-02-22 12:59:46 +01:00
2022-08-20 11:34:04 -04:00
2023-08-30 16:11:10 +02:00
2022-09-24 07:00:00 +02:00
2023-01-18 11:58:12 +01:00
2022-03-03 20:38:56 -08:00
2023-07-01 13:16:25 +02:00
2022-04-22 10:57:18 -07:00
2022-12-31 13:32:57 +01:00
2022-10-12 11:00:22 -07:00
2022-12-31 13:32:41 +01:00
2022-03-03 20:38:56 -08:00
2023-02-22 12:59:50 +01:00
2022-08-20 11:34:33 -04:00
2022-09-24 18:14:12 -07:00
2022-10-10 19:45:17 -07:00
2022-09-20 08:24:38 -06:00
2023-09-13 09:42:27 +02:00
2023-06-21 16:00:54 +02:00
2023-07-01 13:16:25 +02:00
2022-06-10 16:10:23 -04:00
2022-09-01 17:36:39 -04:00
2022-08-16 10:59:54 -04:00
2023-08-11 12:08:23 +02:00
2023-09-13 09:42:28 +02:00
2023-01-07 11:11:59 +01:00
2023-05-17 11:53:33 +02:00
2022-05-19 23:25:10 -04:00
2023-07-19 16:22:12 +02:00
2023-08-30 16:11:10 +02:00
2022-04-01 19:35:56 -07:00
2023-06-28 11:12:40 +02:00
2022-10-10 14:21:11 -07:00
2022-06-16 19:58:21 -07:00
2022-12-31 13:31:58 +01:00
2023-09-23 11:11:00 +02:00
2023-06-28 11:12:40 +02:00
2023-01-07 11:12:02 +01:00
2022-07-05 16:18:21 -04:00
2022-08-03 10:35:43 -07:00
2023-09-13 09:42:27 +02:00
2023-04-13 16:55:33 +02:00
2022-08-20 11:34:04 -04:00
2023-08-11 12:08:22 +02:00
2022-08-20 11:34:04 -04:00
2023-01-04 11:29:01 +01:00
2022-10-10 17:53:04 -07:00
2022-06-28 13:58:05 -04:00
2023-02-09 11:28:04 +01:00
2022-08-17 17:25:04 -04:00
2022-08-05 16:32:45 -07:00
2022-01-11 09:03:05 -08:00
2023-02-09 11:28:04 +01:00
2022-01-17 05:49:30 +02:00
2023-02-09 11:28:04 +01:00
2022-09-11 19:47:12 -05:00
2023-05-24 17:32:51 +01:00
2023-08-11 12:08:24 +02:00
2022-04-26 13:36:25 -07:00
2022-01-22 08:33:36 +02:00
2023-04-26 14:28:37 +02:00
2022-12-31 13:31:55 +01:00