Eric Biggers 9aae17f851 KEYS: put keyring if install_session_keyring_to_cred() fails ...

[ Upstream commit d636bd9f12 ]

In join_session_keyring(), if install_session_keyring_to_cred() were to
fail, we would leak the keyring reference, just like in the bug fixed by
commit 23567fd052 ("KEYS: Fix keyring ref leak in
join_session_keyring()").  Fortunately this cannot happen currently, but
we really should be more careful.  Do this by adding and using a new
error label at which the keyring reference is dropped.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2018-11-10 07:41:34 -08:00

..

encrypted-keys

KEYS: encrypted: fix buffer overread in valid_master_desc()

2018-02-16 20:09:38 +01:00

big_key.c

KEYS: Fix race between updating and finding a negative key

2017-10-27 10:23:18 +02:00

compat.c

switch keyctl_instantiate_key_common() to iov_iter

2015-04-11 22:27:12 -04:00

gc.c

KEYS: Fix race between updating and finding a negative key

2017-10-27 10:23:18 +02:00

internal.h

KEYS: prevent creating a different user's keyrings

2017-10-05 09:41:45 +02:00

Kconfig

security/keys: add CONFIG_KEYS_COMPAT to Kconfig

2017-11-18 11:11:07 +01:00

key.c

KEYS: Fix race between updating and finding a negative key

2017-10-27 10:23:18 +02:00

keyctl.c

KEYS: Fix race between updating and finding a negative key

2017-10-27 10:23:18 +02:00

keyring.c

KEYS: return full count in keyring_read() if buffer is too small

2017-11-08 10:06:27 +01:00

Makefile

KEYS: Add per-user_namespace registers for persistent per-UID kerberos caches

2013-09-24 10:35:19 +01:00

permission.c

KEYS: Move the flags representing required permission to linux/key.h

2014-03-14 17:44:49 +00:00

persistent.c

KEYS: Move the flags representing required permission to linux/key.h

2014-03-14 17:44:49 +00:00

proc.c

KEYS: Fix race between updating and finding a negative key

2017-10-27 10:23:18 +02:00

process_keys.c

KEYS: put keyring if install_session_keyring_to_cred() fails

2018-11-10 07:41:34 -08:00

request_key_auth.c

KEYS: Fix race between updating and finding a negative key

2017-10-27 10:23:18 +02:00

request_key.c

KEYS: add missing permission check for request_key() destination

2017-12-20 10:04:52 +01:00

sysctl.c

security: Convert use of typedef ctl_table to struct ctl_table

2014-04-15 13:39:58 +10:00

trusted.c

KEYS: trusted: fix writing past end of buffer in trusted_read()

2017-11-15 17:13:11 +01:00

trusted.h

keys, trusted: move struct trusted_key_options to trusted-type.h

2015-10-19 01:01:21 +02:00

user_defined.c

KEYS: Fix race between updating and finding a negative key

2017-10-27 10:23:18 +02:00