Cheng Lin
28b4a8bc60
nfs_common: need lock during iterate through the list
[ Upstream commit 4a9d81caf8 ]
If the elem is deleted during be iterated on it, the iteration
process will fall into an endless loop.
kernel: NMI watchdog: BUG: soft lockup - CPU#4 stuck for 22s! [nfsd:17137]
PID: 17137 TASK: ffff8818d93c0000 CPU: 4 COMMAND: "nfsd"
[exception RIP: __state_in_grace+76]
RIP: ffffffffc00e817c RSP: ffff8818d3aefc98 RFLAGS: 00000246
RAX: ffff881dc0c38298 RBX: ffffffff81b03580 RCX: ffff881dc02c9f50
RDX: ffff881e3fce8500 RSI: 0000000000000001 RDI: ffffffff81b03580
RBP: ffff8818d3aefca0 R8: 0000000000000020 R9: ffff8818d3aefd40
R10: ffff88017fc03800 R11: ffff8818e83933c0 R12: ffff8818d3aefd40
R13: 0000000000000000 R14: ffff8818e8391068 R15: ffff8818fa6e4000
CS: 0010 SS: 0018
#0 [ffff8818d3aefc98] opens_in_grace at ffffffffc00e81e3 [grace]
#1 [ffff8818d3aefca8] nfs4_preprocess_stateid_op at ffffffffc02a3e6c [nfsd]
#2 [ffff8818d3aefd18] nfsd4_write at ffffffffc028ed5b [nfsd]
#3 [ffff8818d3aefd80] nfsd4_proc_compound at ffffffffc0290a0d [nfsd]
#4 [ffff8818d3aefdd0] nfsd_dispatch at ffffffffc027b800 [nfsd]
#5 [ffff8818d3aefe08] svc_process_common at ffffffffc02017f3 [sunrpc]
#6 [ffff8818d3aefe70] svc_process at ffffffffc0201ce3 [sunrpc]
#7 [ffff8818d3aefe98] nfsd at ffffffffc027b117 [nfsd]
#8 [ffff8818d3aefec8] kthread at ffffffff810b88c1
#9 [ffff8818d3aeff50] ret_from_fork at ffffffff816d1607
The troublemake elem:
crash> lock_manager ffff881dc0c38298
struct lock_manager {
list = {
next = 0xffff881dc0c38298,
prev = 0xffff881dc0c38298
},
block_opens = false
}
Fixes: c87fb4a378 ("lockd: NLM grace period shouldn't block NFSv4 opens")
Signed-off-by: Cheng Lin <cheng.lin130@zte.com.cn>
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-12-29 13:44:59 +01:00
..
2020-11-10 10:23:59 +01:00
2019-08-06 18:29:35 +02:00
2020-09-12 11:47:39 +02:00
2020-01-29 10:24:34 +01:00
2019-12-21 10:40:46 +01:00
2016-10-15 12:09:13 -07:00
2018-12-01 09:44:19 +01:00
2020-12-11 13:37:58 +01:00
2020-11-10 10:24:00 +01:00
2020-11-10 10:23:59 +01:00
2020-12-11 13:38:00 +01:00
2019-08-06 18:29:38 +02:00
2020-05-27 16:41:45 +02:00
2018-11-13 11:17:03 -08:00
2020-11-10 10:23:51 +01:00
2019-05-08 07:19:10 +02:00
2019-03-23 13:19:47 +01:00
2020-10-29 09:05:43 +01:00
2020-03-11 07:53:06 +01:00
2020-12-02 08:31:28 +01:00
2018-11-27 16:09:38 +01:00
2020-01-29 10:24:03 +01:00
2020-08-21 11:02:08 +02:00
2020-11-24 13:03:07 +01:00
2020-11-10 10:23:52 +01:00
2020-06-20 10:24:13 +02:00
2018-12-17 09:38:34 +01:00
2020-11-10 10:23:51 +01:00
2020-12-11 13:38:01 +01:00
2019-11-28 18:28:50 +01:00
2020-04-24 07:58:59 +02:00
2016-10-10 20:16:43 -07:00
2016-10-10 20:16:43 -07:00
2019-05-31 06:48:12 -07:00
2017-11-30 08:39:04 +00:00
2020-09-03 11:21:19 +02:00
2020-08-26 10:29:05 +02:00
2020-01-29 10:24:19 +01:00
2019-11-25 09:52:23 +01:00
2020-12-29 13:44:57 +01:00
2016-10-10 20:16:43 -07:00
2020-08-21 11:02:06 +02:00
2019-03-13 14:04:52 -07:00
2020-12-29 13:44:57 +01:00
2020-12-29 13:44:59 +01:00
2020-12-29 13:44:59 +01:00
2020-06-20 10:24:09 +02:00
2019-02-06 17:33:30 +01:00
2020-10-29 09:05:43 +01:00
2020-11-18 18:26:28 +01:00
2016-10-10 20:16:43 -07:00
2020-02-28 15:42:43 +01:00
2020-06-20 10:24:11 +02:00
2020-12-02 08:31:26 +01:00
2020-01-12 11:24:20 +01:00
2020-10-29 09:05:36 +01:00
2016-10-10 20:16:43 -07:00
2020-10-29 09:05:45 +01:00
2020-08-26 10:29:03 +02:00
2018-09-05 09:20:03 +02:00
2018-09-05 09:20:10 +02:00
2018-12-17 09:38:32 +01:00
2020-11-10 10:23:58 +01:00
2020-10-29 09:05:44 +01:00
2020-08-21 11:02:11 +02:00
2020-11-24 13:03:04 +01:00
2018-12-21 14:11:31 +01:00
2016-10-10 20:16:43 -07:00
2017-01-09 08:32:24 +01:00
2020-06-03 08:16:42 +02:00
2019-07-10 09:55:38 +02:00
2018-06-26 08:08:09 +08:00
2019-11-06 12:18:04 +01:00
2020-10-01 20:40:12 +02:00
2020-11-10 10:23:56 +01:00
2020-05-20 08:15:32 +02:00
2018-02-25 11:05:55 +01:00
2020-06-30 15:38:35 -04:00
2017-07-05 14:40:26 +02:00
2018-02-28 10:18:33 +01:00
2019-03-27 14:13:04 +09:00
2019-03-05 17:57:05 +01:00
2019-03-13 14:04:58 -07:00
2020-10-14 09:48:13 +02:00
2020-05-20 08:15:41 +02:00
2018-01-31 12:55:52 +01:00
2020-05-27 16:41:40 +02:00
2020-09-03 11:21:21 +02:00
2020-04-02 17:20:27 +02:00
2017-09-20 08:20:01 +02:00
2017-09-20 08:19:59 +02:00
2016-10-07 18:46:29 -07:00
2020-11-24 13:03:05 +01:00
2020-01-12 11:24:13 +01:00
2018-02-22 15:43:48 +01:00
2017-07-21 07:42:22 +02:00
2017-10-18 09:35:39 +02:00
2020-03-11 07:53:07 +01:00
2020-05-02 17:23:10 +02:00
2018-02-17 13:21:15 +01:00
2020-03-20 09:07:44 +01:00
2019-06-11 12:22:45 +02:00
2020-05-02 17:23:20 +02:00
2017-03-15 10:02:43 +08:00
2017-01-26 08:24:37 +01:00
2019-06-11 12:22:49 +02:00
2020-01-04 13:41:06 +01:00
2016-10-11 15:06:30 -07:00
2016-10-07 18:46:30 -07:00
2019-06-11 12:22:45 +02:00
2017-06-14 15:06:01 +02:00
2020-11-24 13:03:00 +01:00
2017-05-08 07:47:54 +02:00
2019-09-06 10:19:37 +02:00
2016-10-08 11:06:08 -04:00
2020-08-21 11:01:55 +02:00