Files
linux/include/uapi/linux
Jordan Rome 799a914e48 bpf: Add crosstask check to __bpf_get_stack
[ Upstream commit b8e3a87a627b575896e448021e5c2f8a3bc19931 ]

Currently get_perf_callchain only supports user stack walking for
the current task. Passing the correct *crosstask* param will return
0 frames if the task passed to __bpf_get_stack isn't the current
one instead of a single incorrect frame/address. This change
passes the correct *crosstask* param but also does a preemptive
check in __bpf_get_stack if the task is current and returns
-EOPNOTSUPP if it is not.

This issue was found using bpf_get_task_stack inside a BPF
iterator ("iter/task"), which iterates over all tasks.
bpf_get_task_stack works fine for fetching kernel stacks
but because get_perf_callchain relies on the caller to know
if the requested *task* is the current one (via *crosstask*)
it was failing in a confusing way.

It might be possible to get user stacks for all tasks utilizing
something like access_process_vm but that requires the bpf
program calling bpf_get_task_stack to be sleepable and would
therefore be a breaking change.

Fixes: fa28dcb82a ("bpf: Introduce helper bpf_get_task_stack()")
Signed-off-by: Jordan Rome <jordalgo@meta.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20231108112334.3433136-1-jordalgo@meta.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-01-25 15:27:24 -08:00
..
2022-09-15 09:08:09 +02:00
2021-01-25 18:44:44 +01:00
2022-04-19 13:13:47 +01:00
2021-11-01 13:36:08 +00:00
2022-08-11 10:31:19 -07:00
2019-03-07 18:32:01 -08:00
2022-06-07 10:20:42 -07:00
2019-10-09 22:31:14 -04:00
2019-09-25 17:51:39 -07:00
2021-11-26 16:48:59 +01:00
2019-08-02 14:44:02 +10:00
2022-08-23 14:54:54 -05:00
2020-07-19 19:20:22 -07:00
2022-04-04 08:55:23 +02:00
2020-05-14 16:44:25 +02:00
2019-03-27 13:30:07 -07:00
2022-09-24 07:00:00 +02:00
2021-10-07 13:51:11 +02:00
2022-08-10 13:49:50 +01:00
2021-02-08 13:01:24 +01:00
2023-11-02 09:35:28 +01:00
2021-11-15 07:53:10 -08:00
2021-06-03 15:31:34 -07:00
2020-07-13 15:32:56 -07:00
2020-04-20 12:43:24 -07:00
2022-06-03 20:09:27 +08:00
2022-09-20 09:13:38 +02:00
2022-09-29 18:43:04 +02:00
2017-11-28 16:54:00 +01:00
2021-03-10 09:34:06 +01:00
2020-08-18 15:44:44 +02:00
2022-09-07 16:46:03 +02:00
2018-01-14 23:06:30 -05:00
2018-01-16 16:47:29 +01:00
2021-07-06 10:37:46 -05:00
2019-10-02 20:32:27 -06:00
2022-09-20 09:13:38 +02:00
2019-01-22 10:21:45 +01:00
2019-07-30 20:34:34 +02:00
2018-03-20 03:17:41 +02:00
2020-03-29 22:30:57 -07:00
2023-09-13 09:42:53 +02:00
2021-01-07 16:17:32 +01:00
2022-09-27 17:29:09 -07:00
2018-09-03 13:29:38 +02:00
2019-12-09 09:59:07 +01:00
2020-03-29 23:29:08 +02:00
2022-08-11 04:31:15 -04:00
2019-08-01 21:49:46 +02:00
2021-06-12 13:16:45 -07:00
2020-07-13 15:32:56 -07:00