Sheng Yong
dbeca41557
f2fs: UBSAN: set boolean value iostat_enable correctly
[ Upstream commit ac92985864 ]
When setting /sys/fs/f2fs/<DEV>/iostat_enable with non-bool value, UBSAN
reports the following warning.
[ 7562.295484] ================================================================================
[ 7562.296531] UBSAN: Undefined behaviour in fs/f2fs/f2fs.h:2776:10
[ 7562.297651] load of value 64 is not a valid value for type '_Bool'
[ 7562.298642] CPU: 1 PID: 7487 Comm: dd Not tainted 4.20.0-rc4+ #79
[ 7562.298653] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006
[ 7562.298662] Call Trace:
[ 7562.298760] dump_stack+0x46/0x5b
[ 7562.298811] ubsan_epilogue+0x9/0x40
[ 7562.298830] __ubsan_handle_load_invalid_value+0x72/0x90
[ 7562.298863] f2fs_file_write_iter+0x29f/0x3f0
[ 7562.298905] __vfs_write+0x115/0x160
[ 7562.298922] vfs_write+0xa7/0x190
[ 7562.298934] ksys_write+0x50/0xc0
[ 7562.298973] do_syscall_64+0x4a/0xe0
[ 7562.298992] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[ 7562.299001] RIP: 0033:0x7fa45ec19c00
[ 7562.299004] Code: 73 01 c3 48 8b 0d 88 92 2c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 0f 1f 44 00 00 83 3d dd eb 2c 00 00 75 10 b8 01 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 31 c3 48 83 ec 08 e8 ce 8f 01 00 48 89 04 24
[ 7562.299044] RSP: 002b:00007ffca52b49e8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
[ 7562.299052] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fa45ec19c00
[ 7562.299059] RDX: 0000000000000400 RSI: 000000000093f000 RDI: 0000000000000001
[ 7562.299065] RBP: 000000000093f000 R08: 0000000000000004 R09: 0000000000000000
[ 7562.299071] R10: 00007ffca52b47b0 R11: 0000000000000246 R12: 0000000000000400
[ 7562.299077] R13: 000000000093f000 R14: 000000000093f400 R15: 0000000000000000
[ 7562.299091] ================================================================================
So, if iostat_enable is enabled, set its value as true.
Signed-off-by: Sheng Yong <shengyong1@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-04-05 22:33:14 +02:00
..
2019-03-23 20:09:38 +01:00
2018-08-22 10:52:51 -07:00
2018-05-28 12:36:41 +02:00
2019-02-27 10:08:56 +01:00
2019-03-13 14:02:32 -07:00
2018-06-15 18:10:01 -03:00
2018-12-01 09:37:27 +01:00
2019-04-05 22:33:02 +02:00
2018-12-17 09:24:40 +01:00
2019-02-27 10:08:50 +01:00
2019-04-05 22:33:00 +02:00
2018-06-05 16:57:31 -07:00
2018-07-17 06:14:07 -07:00
2018-11-13 11:08:55 -08:00
2018-11-13 11:08:46 -08:00
2019-02-15 08:10:11 +01:00
2019-03-23 20:09:59 +01:00
2019-02-12 19:46:58 +01:00
2018-05-26 09:16:25 +02:00
2018-07-22 14:13:44 +02:00
2018-11-27 16:13:00 +01:00
2018-12-17 09:24:35 +01:00
2019-03-23 20:10:03 +01:00
2019-04-05 22:32:55 +02:00
2019-04-05 22:33:14 +02:00
2018-10-13 09:31:03 +02:00
2018-05-22 14:27:51 -04:00
2018-12-17 09:24:40 +01:00
2019-02-12 19:47:24 +01:00
2019-03-13 14:02:40 -07:00
2018-12-17 09:24:41 +01:00
2018-12-17 09:24:41 +01:00
2018-08-17 16:20:28 -07:00
2018-08-25 12:42:33 -07:00
2019-03-05 17:58:53 +01:00
2018-08-21 11:37:41 +02:00
2019-04-05 22:33:07 +02:00
2019-01-26 09:32:37 +01:00
2018-08-15 22:47:23 -07:00
2019-03-23 20:09:53 +01:00
2019-04-03 06:26:21 +02:00
2018-05-22 14:27:52 -04:00
2019-04-03 06:26:22 +02:00
2018-03-27 13:18:09 -04:00
2019-03-23 20:10:09 +01:00
2018-09-04 16:45:02 -07:00
2019-01-31 08:14:34 +01:00
2018-08-17 16:20:27 -07:00
2019-04-05 22:32:59 +02:00
2018-05-22 14:27:58 -04:00
2018-05-22 14:27:57 -04:00
2018-08-14 12:07:14 -04:00
2019-03-23 20:09:59 +01:00
2019-04-03 06:26:26 +02:00
2019-01-26 09:32:37 +01:00
2018-05-22 14:27:52 -04:00
2018-05-22 14:27:54 -04:00
2019-01-26 09:32:42 +01:00
2018-11-27 16:12:59 +01:00
2018-05-22 14:27:55 -04:00
2018-08-02 09:34:02 -07:00
2018-08-18 11:44:53 -07:00
2018-12-17 09:24:30 +01:00
2018-07-31 11:32:44 -04:00
2018-12-29 13:37:55 +01:00
2019-03-27 14:14:39 +09:00
2018-08-17 16:20:27 -07:00
2019-02-12 19:47:23 +01:00
2019-03-10 07:17:21 +01:00
2018-07-12 10:04:27 -04:00
2018-07-03 16:44:45 -04:00
2018-07-12 10:04:20 -04:00
2018-04-11 10:28:37 -07:00
2018-06-12 16:19:22 -07:00
2018-08-13 19:24:32 -07:00
2018-04-11 10:28:37 -07:00
2018-07-10 23:29:03 -04:00
2019-02-15 09:09:54 +01:00
2019-01-22 21:40:36 +01:00
2019-04-05 22:33:00 +02:00
2018-03-15 17:59:24 +01:00
2018-07-30 16:21:49 -04:00
2018-06-05 19:23:26 +02:00
2018-03-29 15:07:46 -04:00
2019-01-09 17:38:46 +01:00
2019-02-06 17:30:11 +01:00
2018-04-02 20:15:39 +02:00
2019-03-05 17:58:50 +01:00
2019-03-13 14:02:32 -07:00
2018-06-28 10:40:47 -07:00
2019-02-12 19:47:19 +01:00
2019-03-10 07:17:21 +01:00
2018-08-15 23:03:20 -05:00
2018-08-21 18:19:09 -07:00
2019-04-05 22:32:59 +02:00
2018-05-16 07:23:35 +02:00
2019-03-05 17:58:50 +01:00
2019-02-20 10:25:47 +01:00
2018-08-21 18:19:09 -07:00
2018-11-21 09:19:14 +01:00
2019-03-13 14:02:29 -07:00
2018-06-11 08:22:34 -07:00
2018-08-02 08:06:55 +09:00
2018-03-30 11:34:55 -07:00
2018-08-21 18:19:09 -07:00
2018-06-11 08:22:34 -07:00
2018-06-12 16:19:22 -07:00
2018-08-17 16:20:29 -07:00
2018-12-29 13:37:54 +01:00
2018-11-21 09:19:22 +01:00
2018-02-15 15:34:42 -05:00
2019-04-03 06:26:23 +02:00
2019-03-23 20:09:59 +01:00
2018-02-11 14:34:03 -08:00
2019-04-05 22:33:06 +02:00
2018-04-02 20:16:02 +02:00
2018-06-28 10:40:47 -07:00
2018-08-17 16:20:28 -07:00
2018-06-16 16:21:50 +09:00
2019-03-23 20:09:59 +01:00
2018-04-02 20:15:34 +02:00
2018-07-12 14:49:48 +01:00
2018-08-26 11:48:42 -07:00
2018-04-04 12:44:02 -07:00
2018-08-13 20:56:23 -07:00
2019-01-26 09:32:43 +01:00
2018-04-02 20:15:44 +02:00
2018-09-18 07:30:48 -04:00