Jack Wang b5e07d44b0 md: fix memleak for mempool ...

[ Upstream commit 6aaa58c994 ]

I noticed kmemleak report memory leak when run create/stop
md in a loop, backtrace:
[<000000001ca975e7>] mempool_create_node+0x86/0xd0
[<0000000095576bcd>] md_run+0x1057/0x1410 [md_mod]
[<000000007b45c5fc>] do_md_run+0x15/0x130 [md_mod]
[<000000001ede9ec0>] md_ioctl+0x1f49/0x25d0 [md_mod]
[<000000004142cacf>] blkdev_ioctl+0x680/0xd00

The root cause is we alloc mddev->flush_pool and
mddev->flush_bio_pool in md_run, but from do_md_stop
will not call into md_stop but __md_stop, move the
mempool_destroy to __md_stop fixes the problem for me.

The bug was introduced in 5a409b4f56, the fixes should go to
4.18+

Fixes: 5a409b4f56 ("MD: fix lock contention for flush bios")
Signed-off-by: Jack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: Xiao Ni <xni@redhat.com>
Signed-off-by: Shaohua Li <shli@fb.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-11-13 11:08:31 -08:00

..

bcache

bcache: Populate writeback_rate_minimum attribute

2018-11-13 11:08:22 -08:00

persistent-data

dm: Avoid namespace collision with bitmap API

2018-08-01 15:49:38 -07:00

dm-bio-prison-v1.c

dm: adjust structure members to improve alignment

2018-06-08 11:53:14 -04:00

dm-bio-prison-v1.h

block: switch bios to blk_status_t

2017-06-09 09:27:32 -06:00

dm-bio-prison-v2.c

dm: adjust structure members to improve alignment

2018-06-08 11:53:14 -04:00

dm-bio-prison-v2.h

dm bio prison v2: new interface for the bio prison

2017-03-07 11:30:16 -05:00

dm-bio-record.h

block: replace bi_bdev with a gendisk pointer and partitions index

2017-08-23 12:49:55 -06:00

dm-bufio.c

dm bufio: fix buffer alignment

2018-04-30 11:51:39 -04:00

dm-builtin.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

dm-cache-background-tracker.c

dm cache background tracker: fix sparse warning

2018-04-30 15:40:40 -04:00

dm-cache-background-tracker.h

dm cache: significant rework to leverage dm-bio-prison-v2

2017-03-07 13:28:31 -05:00

dm-cache-block-types.h

linux: drop __bitwise__ everywhere

2016-12-16 00:13:41 +02:00

dm-cache-metadata.c

dm cache metadata: ignore hints array being too small during resize

2018-10-04 15:20:51 -04:00

dm-cache-metadata.h

dm cache: significant rework to leverage dm-bio-prison-v2

2017-03-07 13:28:31 -05:00

dm-cache-policy-internal.h

dm cache: significant rework to leverage dm-bio-prison-v2

2017-03-07 13:28:31 -05:00

dm-cache-policy-smq.c

treewide: Use array_size() in vzalloc()

2018-06-12 16:19:22 -07:00

dm-cache-policy.c

dm cache: add policy name to status output

2014-01-16 13:44:11 -05:00

dm-cache-policy.h

dm cache: significant rework to leverage dm-bio-prison-v2

2017-03-07 13:28:31 -05:00

dm-cache-target.c

dm cache: destroy migration_cache if cache target registration failed

2018-10-09 13:53:03 -04:00

dm-core.h

dm: adjust structure members to improve alignment

2018-06-08 11:53:14 -04:00

dm-crypt.c

dm: disable CRYPTO_TFM_REQ_MAY_SLEEP to fix a GFP_KERNEL recursion deadlock

2018-09-06 13:31:09 -04:00

dm-delay.c

dm delay: add flush as a third class of IO

2018-07-27 15:24:19 -04:00

dm-era-target.c

dm: allow targets to return output from messages they are sent

2018-04-03 15:04:10 -04:00

dm-exception-store.c

Merge tag 'dm-4.4-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm

2015-11-04 21:19:53 -08:00

dm-exception-store.h

dm snapshot: fix hung bios when copy error occurs

2016-01-08 20:03:05 -05:00

dm-flakey.c

dm linear: fix linear_end_io conditional definition

2018-10-10 23:22:24 -04:00

dm-integrity.c

Merge tag 'alloc-args-v4.19-rc8' of https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux

2018-10-11 19:10:30 +02:00

dm-io.c

dm: Use kzalloc for all structs with embedded biosets/mempools

2018-06-05 08:47:43 -06:00

dm-ioctl.c

dm: report which conflicting type caused error during table_load()

2018-06-08 09:50:15 -04:00

dm-kcopyd.c

dm kcopyd: avoid softlockup in run_complete_job

2018-08-08 09:16:24 -04:00

dm-linear.c

dm linear: fix linear_end_io conditional definition

2018-10-10 23:22:24 -04:00

dm-log-userspace-base.c

dm: convert to bioset_init()/mempool_init()

2018-05-30 15:33:32 -06:00

dm-log-userspace-transfer.c

dm log userspace transfer: match wait_for_completion_timeout return type

2015-04-15 12:10:20 -04:00

dm-log-userspace-transfer.h

dm log: userspace add luid to distinguish between concurrent log instances

2009-09-04 20:40:34 +01:00

dm-log-writes.c

dax: Introduce a ->copy_to_iter dax operation

2018-05-22 23:18:31 -07:00

dm-log.c

block,fs: use REQ_* flags directly

2016-11-01 09:43:26 -06:00

dm-mpath.c

dm mpath: fix attached_handler_name leak and dangling hw_handler_name pointer

2018-09-17 22:46:49 -04:00

dm-mpath.h

dm mpath: remove is_active from struct dm_path

2008-10-10 13:36:58 +01:00

dm-path-selector.c

md: Add module.h to all files using it implicitly

2011-10-31 19:31:18 -04:00

dm-path-selector.h

dm path selector: remove 'repeat_count' return from .select_path hook

2016-02-22 22:34:42 -05:00

dm-queue-length.c

dm mpath selector: more evenly distribute ties

2018-01-29 13:44:58 -05:00

dm-raid1.c

dm kcopyd: return void from dm_kcopyd_copy()

2018-07-31 17:33:21 -04:00

dm-raid.c

dm raid: remove bogus const from decipher_sync_action() return type

2018-09-17 22:46:50 -04:00

dm-region-hash.c

Merge tag 'overflow-v4.18-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux

2018-06-12 18:28:00 -07:00

dm-round-robin.c

dm round robin: revert "use percpu 'repeat_count' and 'current_path'"

2017-02-17 00:54:09 -05:00

dm-rq.c

dm: convert to bioset_init()/mempool_init()

2018-05-30 15:33:32 -06:00

dm-rq.h

dm rq: do not update rq partially in each ending bio

2017-08-28 10:23:28 -04:00

dm-service-time.c

dm mpath selector: more evenly distribute ties

2018-01-29 13:44:58 -05:00

dm-snap-persistent.c

dm bufio: move dm-bufio.h to include/linux/

2018-04-03 15:04:23 -04:00

dm-snap-transient.c

dm snapshot: fix hung bios when copy error occurs

2016-01-08 20:03:05 -05:00

dm-snap.c

dm snapshot: remove stale FIXME in snapshot_map()

2018-08-08 20:50:58 -04:00

dm-stats.c

treewide: kmalloc() -> kmalloc_array()

2018-06-12 16:19:22 -07:00

dm-stats.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

dm-stripe.c

dax: Introduce a ->copy_to_iter dax operation

2018-05-22 23:18:31 -07:00

dm-switch.c

treewide: Use array_size() in vmalloc()

2018-06-12 16:19:22 -07:00

dm-sysfs.c

dm: move request-based code out to dm-rq.[hc]

2016-06-10 15:15:44 -04:00

dm-table.c

dm: prevent DAX mounts if not supported

2018-06-28 16:06:14 -04:00

dm-target.c

dm: remove unused macro DM_MOD_NAME_SIZE

2018-04-03 15:04:15 -04:00

dm-thin-metadata.c

dm thin metadata: fix __udivdi3 undefined on 32-bit

2018-09-17 11:49:34 -04:00

dm-thin-metadata.h

dm thin: fix a race condition between discarding and provisioning a block

2016-07-20 12:43:35 -04:00

dm-thin.c

dm thin metadata: try to avoid ever aborting transactions

2018-09-10 17:03:18 -04:00

dm-uevent.c

md: Add in export.h for files using EXPORT_SYMBOL

2011-10-31 19:31:19 -04:00

dm-uevent.h

dm: uevent generate events

2007-10-20 02:01:26 +01:00

dm-unstripe.c

dm unstripe: remove unnecessary header includes

2018-04-03 15:04:15 -04:00

dm-verity-fec.c

Merge tag 'rslib-v4.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux

2018-06-05 10:48:05 -07:00

dm-verity-fec.h

dm: convert to bioset_init()/mempool_init()

2018-05-30 15:33:32 -06:00

dm-verity-target.c

dm verity: fix crash on bufio buffer that was allocated with vmalloc

2018-09-04 11:25:25 -04:00

dm-verity.h

dm verity: add 'check_at_most_once' option to only validate hashes once

2018-04-03 15:04:29 -04:00

dm-writecache.c

Merge tag 'libnvdimm-for-4.19_misc' of gitolite.kernel.org:pub/scm/linux/kernel/git/nvdimm/nvdimm

2018-08-25 18:13:10 -07:00

dm-zero.c

dm: don't return errnos from ->map

2017-06-09 09:27:32 -06:00

dm-zoned-metadata.c

dm: backfill missing calls to mutex_destroy()

2018-01-17 09:16:15 -05:00

dm-zoned-reclaim.c

dm kcopyd: return void from dm_kcopyd_copy()

2018-07-31 17:33:21 -04:00

dm-zoned-target.c

dm zoned: avoid triggering reclaim from inside dmz_map()

2018-06-22 14:51:12 -04:00

dm-zoned.h

dm zoned: drive-managed zoned block device target

2017-06-19 11:05:20 -04:00

dm.c

dm: fix report zone remapping to account for partition offset

2018-10-09 14:20:13 -04:00

dm.h

dm: move dm_table_destroy() to same header as dm_table_create()

2018-01-17 09:16:06 -05:00

Kconfig

dm: add writecache target

2018-06-08 11:59:51 -04:00

Makefile

dm: add writecache target

2018-06-08 11:59:51 -04:00

md-bitmap.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input

2018-08-18 16:48:07 -07:00

md-bitmap.h

md: Avoid namespace collision with bitmap API

2018-08-01 15:49:39 -07:00

md-cluster.c

md-cluster: release RESYNC lock after the last resync message

2018-08-31 17:38:10 -07:00

md-cluster.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

md-faulty.c

md: convert to bioset_init()/mempool_init()

2018-05-30 15:33:32 -06:00

md-linear.c

md: convert to bioset_init()/mempool_init()

2018-05-30 15:33:32 -06:00

md-linear.h

Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md

2017-11-14 16:07:26 -08:00

md-multipath.c

treewide: kzalloc() -> kcalloc()

2018-06-12 16:19:22 -07:00

md-multipath.h

md: convert to bioset_init()/mempool_init()

2018-05-30 15:33:32 -06:00

md.c

md: fix memleak for mempool

2018-11-13 11:08:31 -08:00

md.h

md-cluster: show array's status more accurate

2018-07-05 11:17:01 -07:00

raid0.c

treewide: kzalloc() -> kcalloc()

2018-06-12 16:19:22 -07:00

raid0.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

raid1-10.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

raid1.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input

2018-08-18 16:48:07 -07:00

raid1.h

md: convert to bioset_init()/mempool_init()

2018-05-30 15:33:32 -06:00

raid5-cache.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input

2018-08-18 16:48:07 -07:00

raid5-log.h

md/raid5-cache: disable reshape completely

2018-08-31 17:38:09 -07:00

raid5-ppl.c

md: convert to bioset_init()/mempool_init()

2018-05-30 15:33:32 -06:00

raid5.c

md/raid5-cache: disable reshape completely

2018-08-31 17:38:09 -07:00

raid5.h

Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md

2018-06-09 12:01:36 -07:00

raid10.c

RAID10 BUG_ON in raise_barrier when force is true and conf->barrier is 0

2018-08-31 17:38:10 -07:00

raid10.h

md: convert to bioset_init()/mempool_init()

2018-05-30 15:33:32 -06:00