Bert Kenward 701768dc9a sfc: pass valid pointers from efx_enqueue_unwind ...

[ Upstream commit d4a7a8893d ]

The bytes_compl and pkts_compl pointers passed to efx_dequeue_buffers
cannot be NULL. Add a paranoid warning to check this condition and fix
the one case where they were NULL.

efx_enqueue_unwind() is called very rarely, during error handling.
Without this fix it would fail with a NULL pointer dereference in
efx_dequeue_buffer, with efx_enqueue_skb in the call stack.

Fixes: e9117e5099 ("sfc: Firmware-Assisted TSO version 2")
Reported-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Bert Kenward <bkenward@solarflare.com>
Tested-by: Jarod Wilson <jarod@redhat.com>
Acked-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-01-02 20:31:10 +01:00

..

falcon

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

bitfield.h

sfc: process RX event inner checksum flags

2017-02-09 16:47:53 -05:00

ef10_regs.h

sfc: Update EF10 register definitions

2016-11-18 11:55:37 -05:00

ef10_sriov.c

sfc: remove duplicate up_write on VF filter_sem

2017-06-20 15:40:00 -04:00

ef10_sriov.h

sfc: support ndo_get_phys_port_id even when !CONFIG_SFC_SRIOV

2017-01-10 14:16:17 -05:00

ef10.c

sfc: don't warn on successful change of MAC

2017-12-20 10:10:22 +01:00

efx.c

sfc: limit the number of receive queues

2017-04-17 11:01:19 -04:00

efx.h

net: sched: get rid of struct tc_to_netdev

2017-08-07 09:42:37 -07:00

enum.h

sfc: remove RESET_TYPE_RX_RECOVERY

2016-12-01 15:39:38 -05:00

ethtool.c

sfc: process RX event inner checksum flags

2017-02-09 16:47:53 -05:00

farch_regs.h

sfc: Update copyright banners

2013-08-29 23:34:51 +01:00

farch.c

sfc: read back RX hash config from the NIC when querying it with ethtool -x

2017-01-17 15:49:52 -05:00

filter.h

sfc: insert catch-all filters for encapsulated traffic

2017-01-27 11:59:31 -05:00

io.h

sfc: PIO:Restrict to 64bit arch and use 64-bit writes.

2014-06-11 15:36:21 -07:00

Kconfig

ethernet: sfc: Add Kconfig entry for vendor Solarflare

2016-12-20 14:19:38 -05:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

mcdi_mon.c

sfc: remove EFX_BUG_ON_PARANOID, use EFX_WARN_ON_[ONCE_]PARANOID instead

2016-12-03 16:11:00 -05:00

mcdi_pcol.h

scripts/spelling.txt: add "an one" pattern and fix typo instances

2017-02-27 18:43:46 -08:00

mcdi_port.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2017-08-15 20:23:23 -07:00

mcdi.c

sfc: correct comment on efx_mcdi_process_event

2017-07-01 15:24:06 -07:00

mcdi.h

sfc: configure UDP tunnel offload ports

2017-02-09 16:47:53 -05:00

mtd.c

sfc: Update copyright banners

2013-08-29 23:34:51 +01:00

net_driver.h

sfc: MSI-X is the only interrupt mode for EF10 VFs

2017-02-14 12:43:18 -05:00

nic.c

sfc: work around TRIGGER_INTERRUPT command not working on SFC9140

2016-08-26 21:43:52 -07:00

nic.h

sfc: revert changes to NIC revision numbers

2017-05-12 12:22:53 -04:00

ptp.c

sfc: remove EFX_BUG_ON_PARANOID, use EFX_WARN_ON_[ONCE_]PARANOID instead

2016-12-03 16:11:00 -05:00

rx.c

sfc: set csum_level for encapsulated packets

2017-02-09 16:47:53 -05:00

selftest.c

networking: make skb_put & friends return void pointers

2017-06-16 11:48:39 -04:00

selftest.h

sfc: work around TRIGGER_INTERRUPT command not working on SFC9140

2016-08-26 21:43:52 -07:00

siena_sriov.c

sfc: save old MAC address in case sriov_mac_address_changed fails

2015-05-21 18:43:53 -04:00

siena_sriov.h

sfc: save old MAC address in case sriov_mac_address_changed fails

2015-05-21 18:43:53 -04:00

siena.c

sfc: MSI-X is the only interrupt mode for EF10 VFs

2017-02-14 12:43:18 -05:00

sriov.c

sfc: support ndo_get_phys_port_id even when !CONFIG_SFC_SRIOV

2017-01-10 14:16:17 -05:00

sriov.h

sfc: support ndo_get_phys_port_id even when !CONFIG_SFC_SRIOV

2017-01-10 14:16:17 -05:00

tx_tso.c

sfc: remove EFX_BUG_ON_PARANOID, use EFX_WARN_ON_[ONCE_]PARANOID instead

2016-12-03 16:11:00 -05:00

tx.c

sfc: pass valid pointers from efx_enqueue_unwind

2018-01-02 20:31:10 +01:00

tx.h

sfc: Firmware-Assisted TSO version 2

2016-11-18 11:55:38 -05:00

vfdi.h

ethernet: codespell comment spelling fixes

2015-03-08 22:54:22 -04:00

workarounds.h

sfc: tx ring can only have 2048 entries for all EF10 NICs

2017-04-25 11:19:21 -04:00