Geert Uytterhoeven 2a71a742f0 ubifs: Fix uninitialized variable in search_dh_cookie() ...

[ Upstream commit c877154d30 ]

fs/ubifs/tnc.c: In function ‘search_dh_cookie’:
fs/ubifs/tnc.c:1893: warning: ‘err’ is used uninitialized in this function

Indeed, err is always used uninitialized.

According to an original review comment from Hyunchul, acknowledged by
Richard, err should be initialized to -ENOENT to avoid the first call to
tnc_next().  But we can achieve the same by reordering the code.

Fixes: 781f675e2d ("ubifs: Fix unlink code wrt. double hash lookups")
Reported-by: Hyunchul Lee <hyc.lee@gmail.com>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-04-26 11:02:07 +02:00

..

budget.c

UBIFS: extend debug/message capabilities

2015-03-25 11:08:41 +02:00

commit.c

UBIFS: extend debug/message capabilities

2015-03-25 11:08:41 +02:00

compress.c

UBIFS: extend debug/message capabilities

2015-03-25 11:08:41 +02:00

crypto.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

debug.c

ubifs: Fix cut and paste error on sb type comparisons

2017-05-08 20:48:41 +02:00

debug.h

UBIFS: print less

2012-08-31 17:32:58 +03:00

dir.c

ubifs: free the encrypted symlink target

2018-02-16 20:22:57 +01:00

file.c

mm/migrate: new migrate mode MIGRATE_SYNC_NO_COPY

2017-09-08 18:26:46 -07:00

find.c

UBIFS: fix mounting problems after power cuts

2012-10-26 16:26:44 +03:00

gc.c

ubifs: Remove some dead code

2016-12-12 23:06:28 +01:00

io.c

ubifs: Use dirty_writeback_interval value for wbuf timer

2016-12-12 23:06:24 +01:00

ioctl.c

Merge tag 'upstream-4.12-rc1' of git://git.infradead.org/linux-ubifs

2017-05-13 10:23:12 -07:00

journal.c

ubifs: Set double hash cookie also for RENAME_EXCHANGE

2017-07-14 22:50:57 +02:00

Kconfig

ubifs: Add CONFIG_UBIFS_FS_SECURITY to disable/enable security labels

2017-05-08 20:48:23 +02:00

key.h

ubifs: Add assert to dent_key_init()

2017-07-14 22:49:06 +02:00

log.c

UBIFS: extend debug/message capabilities

2015-03-25 11:08:41 +02:00

lprops.c

UBIFS: improve function-level documentation

2016-10-02 22:55:02 +02:00

lpt_commit.c

UBIFS: improve function-level documentation

2016-10-02 22:55:02 +02:00

lpt.c

UBIFS: use kmemdup rather than duplicating its implementation

2015-10-03 20:03:14 +02:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

master.c

UBIFS: extend debug/message capabilities

2015-03-25 11:08:41 +02:00

misc.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

misc.h

fs: ubifs: replace CURRENT_TIME_SEC with current_time

2017-05-08 17:15:15 -07:00

orphan.c

UBIFS: extend debug/message capabilities

2015-03-25 11:08:41 +02:00

recovery.c

ubifs: Remove unnecessary assignment

2017-05-08 20:48:47 +02:00

replay.c

ubifs: Implement encrypted filenames

2016-12-12 23:07:38 +01:00

sb.c

fs: ubifs: replace CURRENT_TIME_SEC with current_time

2017-05-08 17:15:15 -07:00

scan.c

UBIFS: extend debug/message capabilities

2015-03-25 11:08:41 +02:00

shrinker.c

UBIFS: Remove incorrect assertion in shrink_tnc()

2014-06-02 11:28:24 +03:00

super.c

ubifs: Check ubifs_wbuf_sync() return code

2018-04-24 09:36:21 +02:00

tnc_commit.c

ubifs: Fail commit if TNC is obviously inconsistent

2017-07-14 22:49:07 +02:00

tnc_misc.c

UBIFS: extend debug/message capabilities

2015-03-25 11:08:41 +02:00

tnc.c

ubifs: Fix uninitialized variable in search_dh_cookie()

2018-04-26 11:02:07 +02:00

ubifs-media.h

ubifs: Raise write version to 5

2016-12-12 23:07:38 +01:00

ubifs.h

ubifs: Massage assert in ubifs_xattr_set() wrt. init_xattrs

2017-07-14 22:50:54 +02:00

xattr.c

ubifs: Massage assert in ubifs_xattr_set() wrt. init_xattrs

2017-07-14 22:50:54 +02:00