Qinglang Miao
57ba2c7a50
cgroup: Fix memory leak when parsing multiple source parameters
commit 2d18e54dd8 upstream.
A memory leak is found in cgroup1_parse_param() when multiple source
parameters overwrite fc->source in the fs_context struct without free.
unreferenced object 0xffff888100d930e0 (size 16):
comm "mount", pid 520, jiffies 4303326831 (age 152.783s)
hex dump (first 16 bytes):
74 65 73 74 6c 65 61 6b 00 00 00 00 00 00 00 00 testleak........
backtrace:
[<000000003e5023ec>] kmemdup_nul+0x2d/0xa0
[<00000000377dbdaa>] vfs_parse_fs_string+0xc0/0x150
[<00000000cb2b4882>] generic_parse_monolithic+0x15a/0x1d0
[<000000000f750198>] path_mount+0xee1/0x1820
[<0000000004756de2>] do_mount+0xea/0x100
[<0000000094cafb0a>] __x64_sys_mount+0x14b/0x1f0
Fix this bug by permitting a single source parameter and rejecting with
an error all subsequent ones.
Fixes: 8d2451f499 ("cgroup1: switch to option-by-option parsing")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Reviewed-by: Zefan Li <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-01-06 14:48:37 +01:00
..
2020-11-18 19:20:26 +01:00
2021-01-06 14:48:37 +01:00
2018-10-24 20:55:56 -04:00
2020-11-05 11:43:16 +01:00
2020-11-18 19:20:32 +01:00
2020-11-18 19:20:33 +01:00
2020-09-17 13:47:56 +02:00
2020-12-30 11:51:14 +01:00
2019-08-19 13:03:37 +02:00
2020-10-01 13:17:33 +02:00
2020-10-29 09:58:04 +01:00
2020-10-01 13:18:04 +02:00
2020-11-24 13:29:01 +01:00
2020-12-30 11:51:03 +01:00
2020-11-18 19:20:26 +01:00
2020-12-30 11:51:47 +01:00
2019-04-29 16:48:03 +02:00
2019-04-04 21:04:13 -04:00
2019-06-05 17:37:17 +02:00
2019-05-30 11:26:37 -07:00
2019-04-26 13:51:03 -04:00
2020-10-01 13:17:32 +02:00
2020-06-22 09:30:59 +02:00
2020-06-22 09:30:59 +02:00
2020-06-22 09:30:59 +02:00
2019-05-28 17:46:43 -04:00
2019-06-05 17:37:17 +02:00
2018-10-31 08:54:14 -07:00
2019-01-25 11:22:43 -08:00
2019-06-19 17:09:55 +02:00
2019-07-30 18:34:15 +02:00
2019-05-21 10:50:45 +02:00
2020-06-22 09:31:22 +02:00
2020-12-30 11:50:56 +01:00
2019-06-19 17:09:06 +02:00
2019-05-21 10:50:45 +02:00
2020-01-17 19:48:42 +01:00
2019-05-21 11:52:39 +02:00
2018-05-16 07:23:35 +02:00
2019-09-25 17:51:39 -07:00
2018-05-16 07:23:35 +02:00
2020-11-18 19:20:31 +01:00
2019-08-21 22:23:48 +10:00
2020-11-24 13:29:18 +01:00
2020-11-10 12:37:32 +01:00
2019-10-06 09:11:37 -06:00
2020-11-18 19:20:30 +01:00
2020-09-03 11:27:10 +02:00
2019-05-21 10:50:45 +02:00
2019-07-12 11:05:40 -07:00
2019-05-21 10:50:45 +02:00
2019-08-29 15:10:10 +01:00
2020-07-16 08:16:44 +02:00
2020-10-01 13:17:48 +02:00
2019-05-21 10:50:46 +02:00
2019-05-21 10:50:46 +02:00
2019-05-21 10:50:46 +02:00
2019-07-22 18:05:11 +02:00
2019-03-07 18:32:02 -08:00
2019-09-25 17:51:40 -07:00
2019-09-06 23:58:44 +02:00
2019-09-28 08:14:15 -07:00
2019-08-19 21:54:15 -07:00
2019-05-24 20:16:01 +02:00
2020-04-17 10:50:22 +02:00
2020-10-01 13:18:25 +02:00
2019-05-30 11:26:39 -07:00
2020-11-10 12:37:27 +01:00
2019-06-05 17:37:17 +02:00
2020-10-01 13:17:10 +02:00
2019-08-05 18:39:56 -04:00
2019-08-05 18:39:56 -04:00
2019-05-24 17:27:11 +02:00
2020-10-29 09:57:55 +01:00
2020-10-01 13:17:23 +02:00
2019-06-05 17:37:17 +02:00
2020-06-17 16:40:22 +02:00
2019-10-07 15:47:19 -07:00
2019-08-19 21:54:16 -07:00
2019-07-18 17:08:07 -07:00
2019-07-16 19:23:24 -07:00
2019-05-21 10:50:45 +02:00
2020-11-24 13:29:24 +01:00
2020-11-18 19:20:30 +01:00
2020-08-26 10:40:51 +02:00
2020-06-24 17:50:35 +02:00
2019-05-27 09:36:28 -05:00
2020-11-24 13:29:24 +01:00
2020-11-10 12:37:24 +01:00
2019-07-20 11:27:16 +02:00
2019-05-21 10:50:45 +02:00
2019-07-08 11:01:13 -07:00
2018-12-05 19:31:44 -08:00
2019-11-04 21:19:25 +01:00
2019-10-17 12:47:12 +02:00
2019-06-21 01:54:53 +02:00
2020-10-01 13:17:23 +02:00
2019-01-04 13:13:47 -08:00
2020-10-01 13:17:10 +02:00
2020-01-04 19:18:32 +01:00
2017-12-17 13:57:15 +01:00
2020-01-09 10:19:54 +01:00
2019-05-21 11:52:39 +02:00
2019-08-01 14:30:22 -07:00
2019-07-18 11:51:00 -07:00
2019-05-30 11:26:37 -07:00
2019-07-18 17:08:07 -07:00
2018-04-02 20:15:59 +02:00
2018-04-02 20:15:30 +02:00
2020-10-14 10:32:58 +02:00
2019-06-23 14:26:26 +02:00
2019-07-08 19:36:47 -07:00
2019-05-21 10:50:45 +02:00
2019-07-08 19:36:47 -07:00
2019-06-05 17:37:17 +02:00
2019-06-05 17:37:17 +02:00
2019-04-19 09:46:05 -07:00
2020-02-24 08:36:52 +01:00
2019-04-16 16:55:15 +02:00
2020-10-01 13:17:54 +02:00