Ilpo Järvinen dc6330590f tcp: fix crash in tcp_xmit_retransmit_queue ...

commit 45e77d3145 upstream.

It can happen that there are no packets in queue while calling
tcp_xmit_retransmit_queue(). tcp_write_queue_head() then returns
NULL and that gets deref'ed to get sacked into a local var.

There is no work to do if no packets are outstanding so we just
exit early.

This oops was introduced by 08ebd1721a (tcp: remove tp->lost_out
guard to make joining diff nicer).

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Reported-by: Lennart Schulte <lennart.schulte@nets.rwth-aachen.de>
Tested-by: Lennart Schulte <lennart.schulte@nets.rwth-aachen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

2010-08-02 10:20:53 -07:00

..

netfilter

netfilter: nf_conntrack: fix hash resizing with namespaces

2010-02-23 07:37:53 -08:00

af_inet.c

net: Use sk_mark for routing lookup in more places

2009-10-01 15:16:49 -07:00

ah4.c

net: constify struct net_protocol

2009-09-14 17:03:01 -07:00

arp.c

net: make neigh_ops constant

2009-09-01 17:40:57 -07:00

cipso_ipv4.c

netlabel: Label incoming TCP connections correctly in SELinux

2009-03-28 15:01:36 +11:00

datagram.c

mib: add net to IP_INC_STATS_BH

2008-07-16 20:20:11 -07:00

devinet.c

net: Fix sysctl restarts...

2010-03-15 08:49:38 -07:00

esp4.c

net: constify struct net_protocol

2009-09-14 17:03:01 -07:00

fib_frontend.c

net: restore ip source validation

2010-02-09 04:50:55 -08:00

fib_hash.c

ipv4: cleanup - remove two unused parameters from fib_semantic_match().

2009-05-18 15:16:37 -07:00

fib_lookup.h

ipv4: cleanup - remove two unused parameters from fib_semantic_match().

2009-05-18 15:16:37 -07:00

fib_rules.c

net: Remove unused parameter from fill method in fib_rules_ops.

2009-05-20 17:26:23 -07:00

fib_semantics.c

ipv4: cleanup - remove two unused parameters from fib_semantic_match().

2009-05-18 15:16:37 -07:00

fib_trie.c

fib_trie: resize rework

2009-08-28 23:57:15 -07:00

icmp.c

net: constify struct net_protocol

2009-09-14 17:03:01 -07:00

igmp.c

inet: Remove bogus IGMPv3 report handling

2010-03-15 08:49:39 -07:00

inet_connection_sock.c

tcp: reduce SYN-ACK retrans for TCP_DEFER_ACCEPT

2009-10-19 19:19:03 -07:00

inet_diag.c

net: correct off-by-one write allocations reports

2009-06-18 00:29:12 -07:00

inet_fragment.c

inet fragments: fix sparse warning: context imbalance

2009-02-26 23:13:35 -08:00

inet_hashtables.c

net: move bsockets outside of read only beginning of struct inet_hashinfo

2009-02-01 12:31:33 -08:00

inet_lro.c

include/net net/ - csum_partial - remove unnecessary casts

2008-11-19 15:44:53 -08:00

inet_timewait_sock.c

tcp: fix premature termination of FIN_WAIT2 time-wait sockets

2009-08-29 00:00:35 -07:00

inetpeer.c

net: clean up net/ipv4/ah4.c esp4.c fib_semantics.c inet_connection_sock.c inetpeer.c ip_output.c

2008-11-03 00:23:42 -08:00

ip_forward.c

net: skb->dst accessors

2009-06-03 02:51:04 -07:00

ip_fragment.c

ipv4: additional update of dev_net(dev) to struct *net in ip_fragment.c, NULL ptr OOPS

2009-11-29 23:02:22 -08:00

ip_gre.c

gre: Fix dev_addr clobbering for gretap

2009-10-30 12:28:07 -07:00

ip_input.c

net: constify struct net_protocol

2009-09-14 17:03:01 -07:00

ip_options.c

net: skb->dst accessors

2009-06-03 02:51:04 -07:00

ip_output.c

ip_fragment: also adjust skb->truesize for packets not owned by a socket

2009-12-18 14:05:05 -08:00

ip_sockglue.c

net: Fix IP_MULTICAST_IF

2009-10-19 21:34:20 -07:00

ipcomp.c

net: constify struct net_protocol

2009-09-14 17:03:01 -07:00

ipconfig.c

ipv4: teach ipconfig about the MTU option in DHCP

2009-05-19 15:36:17 -07:00

ipip.c

ipip: Fix handling of DF packets when pmtudisc is OFF

2009-11-06 20:33:40 -08:00

ipmr.c

ipmr: missing dev_put() on error path in vif_add()

2009-11-13 19:56:54 -08:00

Kconfig

ipv4: update ARPD help text

2009-06-13 23:36:32 -07:00

Makefile

IPVS: Move IPVS to net/netfilter/ipvs

2008-10-07 08:38:24 +11:00

netfilter.c

net: skb->dst accessors

2009-06-03 02:51:04 -07:00

proc.c

snmp: add missing counters for RFC 4293

2009-04-27 02:45:02 -07:00

protocol.c

net: constify struct net_protocol

2009-09-14 17:03:01 -07:00

raw.c

AF_RAW: Augment raw_send_hdrinc to expand skb to fit iphdr->ihl (v2)

2009-10-29 01:09:58 -07:00

route.c

net: Fix RPF to work with policy routing

2009-10-29 22:49:12 -07:00

syncookies.c

percpu: clean up percpu variable definitions

2009-06-24 15:13:48 +09:00

sysctl_net_ipv4.c

sysctl: remove "struct file *" argument of ->proc_handler

2009-09-24 07:21:04 -07:00

tcp_bic.c

tcp: add helper for AI algorithm

2009-03-02 03:00:15 -08:00

tcp_cong.c

Networking: use CAP_NET_ADMIN when deciding to call request_module

2009-08-14 11:18:34 +10:00

tcp_cubic.c

tcp: add helper for AI algorithm

2009-03-02 03:00:15 -08:00

tcp_diag.c

net: inet_diag_handler structs can be const

2008-11-19 15:43:27 -08:00

tcp_highspeed.c

[TCP]: Cong.ctrl modules: remove unused good_ack from cong_avoid

2008-01-28 14:55:41 -08:00

tcp_htcp.c

htcp: merge icsk_ca_state compare

2009-03-02 03:00:14 -08:00

tcp_hybla.c

tcp: Fix tcp_hybla zero congestion window growth with small rho and large cwnd.

2008-10-07 15:58:17 -07:00

tcp_illinois.c

[TCP]: Cong.ctrl modules: remove unused good_ack from cong_avoid

2008-01-28 14:55:41 -08:00

tcp_input.c

tcp: fix ICMP-RTO war

2010-04-26 07:41:34 -07:00

tcp_ipv4.c

tcp: fix ssthresh u16 leftover

2009-09-15 01:30:10 -07:00

tcp_lp.c

[TCP]: Cong.ctrl modules: remove unused good_ack from cong_avoid

2008-01-28 14:55:41 -08:00

tcp_minisocks.c

tcp: accept socket after TCP_DEFER_ACCEPT period

2009-10-19 19:19:01 -07:00

tcp_output.c

tcp: fix crash in tcp_xmit_retransmit_queue

2010-08-02 10:20:53 -07:00

tcp_probe.c

tcp: '< 0' test on unsigned

2009-03-13 16:05:14 -07:00

tcp_scalable.c

tcp: add helper for AI algorithm

2009-03-02 03:00:15 -08:00

tcp_timer.c

Revert Backoff [v3]: Calculate TCP's connection close threshold as a time value.

2009-09-01 02:45:47 -07:00

tcp_vegas.c

tcp: tcp_vegas ssthresh bugfix

2009-05-25 22:44:59 -07:00

tcp_vegas.h

[TCP]: congestion control API pass RTT in microseconds

2007-07-31 02:27:57 -07:00

tcp_veno.c

tcp: add helper for AI algorithm

2009-03-02 03:00:15 -08:00

tcp_westwood.c

[TCP]: congestion control API pass RTT in microseconds

2007-07-31 02:27:57 -07:00

tcp_yeah.c

tcp: add helper for AI algorithm

2009-03-02 03:00:15 -08:00

tcp.c

tcp: provide more information on the tcp receive_queue bugs

2009-11-13 13:56:33 -08:00

tunnel4.c

net: constify struct net_protocol

2009-09-14 17:03:01 -07:00

udp_impl.h

net: Make setsockopt() optlen be unsigned.

2009-09-30 16:12:20 -07:00

udp.c

ipv4: udp: fix short packet and bad checksum logging

2010-05-26 14:29:13 -07:00

udplite.c

net: constify struct net_protocol

2009-09-14 17:03:01 -07:00

xfrm4_input.c

net: skb->dst accessors

2009-06-03 02:51:04 -07:00

xfrm4_mode_beet.c

ipsec: Interfamily IPSec BEET

2008-08-06 02:39:30 -07:00

xfrm4_mode_transport.c

[IPSEC]: Use IPv6 calling convention as the convention for x->mode->output

2007-10-10 16:55:54 -07:00

xfrm4_mode_tunnel.c

net: skb->dst accessors

2009-06-03 02:51:04 -07:00

xfrm4_output.c

net: skb->dst accessors

2009-06-03 02:51:04 -07:00

xfrm4_policy.c

xfrm4: fix build when SYSCTLs are disabled

2009-08-04 20:18:33 -07:00

xfrm4_state.c

xfrm: remove useless forward declarations

2008-11-25 01:05:54 -08:00

xfrm4_tunnel.c

[IPCOMP]: Fix reception of incompressible packets

2008-01-31 19:27:24 -08:00