Xiyu Yang
636987650f
btrfs: fix block group leak when removing fails
...
commit f6033c5e33 upstream.
btrfs_remove_block_group() invokes btrfs_lookup_block_group(), which
returns a local reference of the block group that contains the given
bytenr to "block_group" with increased refcount.
When btrfs_remove_block_group() returns, "block_group" becomes invalid,
so the refcount should be decreased to keep refcount balanced.
The reference counting issue happens in several exception handling paths
of btrfs_remove_block_group(). When those error scenarios occur such as
btrfs_alloc_path() returns NULL, the function forgets to decrease its
refcnt increased by btrfs_lookup_block_group() and will cause a refcnt
leak.
Fix this issue by jumping to "out_put_group" label and calling
btrfs_put_block_group() when those error scenarios occur.
CC: stable@vger.kernel.org # 4.4+
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn >
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com >
Reviewed-by: David Sterba <dsterba@suse.com >
Signed-off-by: David Sterba <dsterba@suse.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-05-06 08:15:05 +02:00
..
2019-09-27 15:10:34 -07:00
2019-07-19 11:33:22 -07:00
2020-01-17 19:48:50 +01:00
2020-05-02 08:48:55 +02:00
2019-10-25 00:03:11 -04:00
2019-08-30 07:27:17 -07:00
2019-08-30 07:27:17 -07:00
2020-05-06 08:15:05 +02:00
2020-04-29 16:32:58 +02:00
2020-04-29 16:33:19 +02:00
2019-09-19 09:42:37 -07:00
2020-02-11 04:35:12 -08:00
2019-11-23 21:44:49 -05:00
2020-03-18 07:17:53 +01:00
2020-04-17 10:50:02 +02:00
2019-09-03 09:30:56 -04:00
2019-07-12 17:37:53 -07:00
2020-02-28 17:22:26 +01:00
2019-07-19 10:42:02 -07:00
2019-08-30 07:27:17 -07:00
2020-04-17 10:50:16 +02:00
2019-11-10 11:56:05 -05:00
2020-04-23 10:36:41 +02:00
2020-05-02 08:49:01 +02:00
2020-04-29 16:32:55 +02:00
2020-03-12 13:00:19 +01:00
2019-08-30 07:27:17 -07:00
2019-07-10 18:43:43 -07:00
2020-03-18 07:17:52 +01:00
2020-04-17 10:50:03 +02:00
2020-04-17 10:50:22 +02:00
2019-08-30 08:11:25 -07:00
2020-01-04 19:19:19 +01:00
2020-01-04 19:17:31 +01:00
2019-09-19 09:42:37 -07:00
2020-04-21 09:04:52 +02:00
2019-12-04 22:31:06 +01:00
2019-09-19 09:42:37 -07:00
2019-12-13 08:42:53 +01:00
2019-07-03 17:52:09 -04:00
2019-08-30 07:27:17 -07:00
2020-05-06 08:15:05 +02:00
2020-05-02 08:48:46 +02:00
2019-07-01 08:25:34 -07:00
2020-01-12 12:21:38 +01:00
2020-02-11 04:35:12 -08:00
2020-04-17 10:50:21 +02:00
2019-08-30 08:11:25 -07:00
2019-07-19 10:42:02 -07:00
2020-02-24 08:37:02 +01:00
2020-04-21 09:04:50 +02:00
2020-04-29 16:33:14 +02:00
2020-04-17 10:50:12 +02:00
2019-08-30 07:27:17 -07:00
2019-08-30 07:27:17 -07:00
2020-01-12 12:21:37 +01:00
2019-09-12 21:05:34 -04:00
2020-02-24 08:37:00 +01:00
2019-09-19 10:06:57 -07:00
2019-09-19 10:06:57 -07:00
2019-07-19 10:42:02 -07:00
2019-08-30 07:27:18 -07:00
2019-10-12 20:49:07 -04:00
2020-05-02 08:48:42 +02:00
2020-02-24 08:36:44 +01:00
2019-09-19 09:42:37 -07:00
2019-09-17 11:48:24 -04:00
2019-08-12 19:33:50 -07:00
2020-05-02 08:48:56 +02:00
2020-02-11 04:35:37 -08:00
2019-07-19 10:42:02 -07:00
2020-02-11 04:35:12 -08:00
2019-10-06 13:53:27 -07:00
2019-07-16 19:23:22 -07:00
2019-07-19 10:42:02 -07:00
2020-04-23 10:36:34 +02:00
2020-04-23 10:36:15 +02:00
2020-01-14 20:08:18 +01:00
2020-01-09 10:20:05 +01:00
2020-04-29 16:33:14 +02:00
2019-08-30 19:31:09 -04:00
2020-03-05 16:43:36 +01:00
2019-07-20 09:15:51 -07:00
2019-10-14 15:04:01 -07:00
2020-01-12 12:21:37 +01:00
2020-02-11 04:35:37 -08:00
2020-03-25 08:25:57 +01:00
2020-04-17 10:50:12 +02:00
2019-08-07 21:51:47 -04:00
2019-08-19 11:00:39 -04:00
2020-04-17 10:50:21 +02:00
2019-09-06 21:28:49 +02:00
2019-09-12 21:06:14 -04:00
2019-07-16 22:52:37 -04:00
2020-02-11 04:35:11 -08:00
2019-07-19 10:42:02 -07:00
2020-03-25 08:25:58 +01:00
2020-01-17 19:48:21 +01:00
2020-04-17 10:50:16 +02:00
2019-12-17 19:55:30 +01:00
2019-09-18 16:59:14 -07:00
2020-04-01 11:02:17 +02:00
2020-03-25 08:25:41 +01:00
2019-09-18 16:59:14 -07:00
2019-07-16 22:52:37 -04:00
2020-01-17 19:48:21 +01:00
2020-03-05 16:43:48 +01:00
2019-10-16 23:15:09 -04:00
2020-03-18 07:17:51 +01:00
2020-05-02 08:48:44 +02:00
2019-09-06 21:28:49 +02:00
2020-02-11 04:35:23 -08:00
2020-01-29 16:45:31 +01:00
2019-07-16 19:23:25 -07:00
2019-08-13 16:06:52 -07:00
2019-12-17 19:56:52 +01:00
2019-10-03 14:21:35 -07:00
2020-01-12 12:21:38 +01:00
2019-08-01 20:51:23 +02:00
2020-01-04 19:18:32 +01:00
2020-02-11 04:35:12 -08:00