Files
linux/fs
Al Viro 186c5856dc cachefiles: fix the race between cachefiles_bury_object() and rmdir(2)
commit 169b803397 upstream.

the victim might've been rmdir'ed just before the lock_rename();
unlike the normal callers, we do not look the source up after the
parents are locked - we know it beforehand and just recheck that it's
still the child of what used to be its parent.  Unfortunately,
the check is too weak - we don't spot a dead directory since its
->d_parent is unchanged, dentry is positive, etc.  So we sail all
the way to ->rename(), with hosting filesystems _not_ expecting
to be asked renaming an rmdir'ed subdirectory.

The fix is easy, fortunately - the lock on parent is sufficient for
making IS_DEADDIR() on child safe.

Cc: stable@vger.kernel.org
Fixes: 9ae326a690 (CacheFiles: A cache that backs onto a mounted filesystem)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-11-10 07:43:00 -08:00
..
2017-08-06 18:59:43 -07:00
2016-05-20 17:58:30 -07:00
2017-11-30 08:39:04 +00:00
2018-09-26 08:36:37 +02:00
2018-07-03 11:23:17 +02:00
2018-06-06 16:44:38 +02:00
2017-06-14 15:06:00 +02:00
2016-09-27 21:20:53 -04:00
2016-09-27 18:47:38 -04:00
2018-05-16 10:08:42 +02:00
2016-06-21 09:23:11 +10:00
2018-02-17 13:21:15 +01:00
2017-06-14 15:06:01 +02:00