Files
linux/net
Florian Westphal 40352e791c netfilter: x_tables: initialise match/target check parameter struct
commit c568503ef0 upstream.

syzbot reports following splat:

BUG: KMSAN: uninit-value in ebt_stp_mt_check+0x24b/0x450
 net/bridge/netfilter/ebt_stp.c:162
 ebt_stp_mt_check+0x24b/0x450 net/bridge/netfilter/ebt_stp.c:162
 xt_check_match+0x1438/0x1650 net/netfilter/x_tables.c:506
 ebt_check_match net/bridge/netfilter/ebtables.c:372 [inline]
 ebt_check_entry net/bridge/netfilter/ebtables.c:702 [inline]

The uninitialised access is
   xt_mtchk_param->nft_compat

... which should be set to 0.
Fix it by zeroing the struct beforehand, same for tgchk.

ip(6)tables targetinfo uses c99-style initialiser, so no change
needed there.

Reported-by: syzbot+da4494182233c23a5fcf@syzkaller.appspotmail.com
Fixes: 55917a21d0 ("netfilter: x_tables: add context to know if extension runs from nft_compat")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-07-17 11:37:54 +02:00
..
2015-03-02 16:43:41 -05:00
2018-05-16 10:08:44 +02:00
2016-12-03 23:54:25 -05:00
2017-11-15 15:53:17 +01:00
2018-04-13 19:48:29 +02:00
2016-05-29 22:33:25 -07:00
2016-10-20 11:23:08 -04:00
2018-05-30 07:50:28 +02:00
2018-06-13 16:16:42 +02:00
2018-05-30 07:50:32 +02:00
2018-05-30 07:50:25 +02:00
2018-04-24 09:34:17 +02:00
2016-08-17 19:36:23 -04:00
2016-08-17 19:36:23 -04:00