Bart Van Assche 047b402d1b scsi: target/core: Fix a race condition in the LUN lookup code ...

[ Upstream commit 63f7479439 ]

The rcu_dereference(deve->se_lun) expression occurs twice in the LUN lookup
functions. Since these expressions are not serialized against deve->se_lun
assignments each of these expressions may yield a different result. Avoid
that the wrong LUN pointer is stored in se_cmd by reading deve->se_lun only
once.

Cc: Mike Christie <mchristi@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Nicholas Bellinger <nab@linux-iscsi.org>
Fixes: 29a05deebf ("target: Convert se_node_acl->device_list[] to RCU hlist") # v4.10
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2020-01-27 14:50:38 +01:00

..

iscsi

scsi: target: iscsi: Wait for all commands to finish before freeing a session

2020-01-04 19:13:06 +01:00

loopback

Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi

2018-08-15 22:06:26 -07:00

sbp

scsi: target: srp, vscsi, sbp, qla: use target_remove_session

2018-08-02 15:29:31 -04:00

tcm_fc

scsi: tcm_fc: use target_remove_session

2018-08-02 15:29:31 -04:00

Kconfig

target: don't depend on SCSI

2018-08-02 15:19:49 -06:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

target_core_alua.c

target: fix ALUA state file path truncation

2017-11-04 15:00:30 -07:00

target_core_alua.h

Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending

2017-11-24 19:19:20 -10:00

target_core_configfs.c

scsi: target: add helper to check if dev is configured

2018-07-30 23:17:53 -04:00

target_core_device.c

scsi: target/core: Fix a race condition in the LUN lookup code

2020-01-27 14:50:38 +01:00

target_core_fabric_configfs.c

scsi: target: add helper to check if dev is configured

2018-07-30 23:17:53 -04:00

target_core_fabric_lib.c

scsi: target: core: Fix a pr_debug() argument

2020-01-23 08:21:38 +01:00

target_core_file.c

scsi: target: target/file: Add support of direct and async I/O

2018-05-14 22:40:08 -04:00

target_core_file.h

scsi: target: target/file: Add support of direct and async I/O

2018-05-14 22:40:08 -04:00

target_core_hba.c

target: Fix target_sense_desc_format NULL pointer dereference

2015-09-24 23:17:23 -07:00

target_core_iblock.c

scsi: target/iblock: Fix overrun in WRITE SAME emulation

2019-09-16 08:22:17 +02:00

target_core_iblock.h

scsi: target/core: Use the SECTOR_SHIFT constant

2019-09-16 08:22:16 +02:00

target_core_internal.h

scsi: target: Fold core_tmr_handle_tas_abort() into transport_cmd_finish_abort()

2018-07-02 16:44:31 -04:00

target_core_pr.c

scsi: target: Fix truncated PR-in ReadKeys response

2018-06-19 21:36:37 -04:00

target_core_pr.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

target_core_pscsi.c

Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi

2018-06-10 13:01:12 -07:00

target_core_pscsi.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

target_core_rd.c

target: break up free_device callback

2017-07-06 23:11:37 -07:00

target_core_rd.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

target_core_sbc.c

scsi: target: Use config_item_name() instead of open-coding it

2018-07-02 16:44:30 -04:00

target_core_spc.c

scsi: target: use consistent left-aligned ASCII INQUIRY data

2019-01-26 09:32:38 +01:00

target_core_stat.c

target: make config_item_type const

2017-10-19 16:15:17 +02:00

target_core_tmr.c

scsi: target: Fold core_tmr_handle_tas_abort() into transport_cmd_finish_abort()

2018-07-02 16:44:31 -04:00

target_core_tpg.c

target: Fix node_acl demo-mode + uncached dynamic shutdown regression

2017-08-09 20:55:19 -07:00

target_core_transport.c

scsi: target/core: Use kmem_cache_free() instead of kfree()

2019-02-23 09:07:26 +01:00

target_core_ua.c

scsi: target: Remove se_dev_entry.ua_count

2018-07-02 16:44:32 -04:00

target_core_ua.h

scsi: target: Fix handling of removed LUNs

2018-07-02 16:44:32 -04:00

target_core_user.c

scsi: target/tcmu: Fix queue_cmd_ring() declaration

2019-12-05 09:19:47 +01:00

target_core_xcopy.c

scsi: target/core: Make sure that target_wait_for_sess_cmds() waits long enough

2019-01-26 09:32:38 +01:00

target_core_xcopy.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00