Files
linux/include/linux
Waiman Long b6e8d40d43 sched, cpuset: Fix dl_cpu_busy() panic due to empty cs->cpus_allowed
With cgroup v2, the cpuset's cpus_allowed mask can be empty indicating
that the cpuset will just use the effective CPUs of its parent. So
cpuset_can_attach() can call task_can_attach() with an empty mask.
This can lead to cpumask_any_and() returns nr_cpu_ids causing the call
to dl_bw_of() to crash due to percpu value access of an out of bound
CPU value. For example:

	[80468.182258] BUG: unable to handle page fault for address: ffffffff8b6648b0
	  :
	[80468.191019] RIP: 0010:dl_cpu_busy+0x30/0x2b0
	  :
	[80468.207946] Call Trace:
	[80468.208947]  cpuset_can_attach+0xa0/0x140
	[80468.209953]  cgroup_migrate_execute+0x8c/0x490
	[80468.210931]  cgroup_update_dfl_csses+0x254/0x270
	[80468.211898]  cgroup_subtree_control_write+0x322/0x400
	[80468.212854]  kernfs_fop_write_iter+0x11c/0x1b0
	[80468.213777]  new_sync_write+0x11f/0x1b0
	[80468.214689]  vfs_write+0x1eb/0x280
	[80468.215592]  ksys_write+0x5f/0xe0
	[80468.216463]  do_syscall_64+0x5c/0x80
	[80468.224287]  entry_SYSCALL_64_after_hwframe+0x44/0xae

Fix that by using effective_cpus instead. For cgroup v1, effective_cpus
is the same as cpus_allowed. For v2, effective_cpus is the real cpumask
to be used by tasks within the cpuset anyway.

Also update task_can_attach()'s 2nd argument name to cs_effective_cpus to
reflect the change. In addition, a check is added to task_can_attach()
to guard against the possibility that cpumask_any_and() may return a
value >= nr_cpu_ids.

Fixes: 7f51412a41 ("sched/deadline: Fix bandwidth check/update when migrating tasks between exclusive cpusets")
Signed-off-by: Waiman Long <longman@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Juri Lelli <juri.lelli@redhat.com>
Link: https://lore.kernel.org/r/20220803015451.2219567-1-longman@redhat.com
2022-08-03 10:34:26 +02:00
..
2022-05-10 16:03:52 +08:00
2022-04-20 12:59:50 +05:30
2022-05-22 20:44:29 +01:00
2022-03-23 19:58:38 +01:00
2022-02-01 14:25:50 +02:00
2022-01-22 08:33:34 +02:00
2021-05-06 19:24:11 -07:00
2021-04-14 16:30:30 +03:00
2022-06-08 14:04:14 -04:00
2022-05-20 15:29:00 -07:00
2021-02-26 09:41:03 -08:00
2022-03-11 19:15:03 -08:00
2022-04-22 12:32:03 +02:00
2022-03-15 10:32:44 +01:00
2022-05-16 13:37:59 -07:00
2021-12-10 17:10:55 -08:00
2022-06-28 10:37:25 -03:00
2021-12-10 12:51:28 +01:00
2021-08-26 15:32:28 -04:00
2022-07-01 14:53:01 +02:00
2021-07-27 11:00:36 +02:00
2021-04-12 15:04:23 +02:00
2022-03-16 15:13:36 -07:00
2022-06-03 06:52:57 -07:00
2021-06-25 19:57:01 -04:00
2021-07-26 15:09:44 +02:00
2022-01-20 08:52:54 +02:00
2021-07-27 20:11:45 +01:00
2021-07-27 20:11:44 +01:00
2022-07-20 10:52:40 +01:00
2022-03-02 22:44:49 -08:00
2021-08-05 11:46:42 +01:00
2022-02-28 23:26:27 -08:00
2022-02-19 19:23:53 -08:00
2022-02-14 15:43:15 +01:00
2022-03-18 09:47:04 +01:00
2021-06-01 10:29:21 +01:00
2021-02-26 09:41:03 -08:00
2022-05-02 14:06:20 -06:00
2022-06-06 09:52:17 +09:00
2022-01-27 13:53:26 +00:00
2022-05-03 16:09:03 -04:00
2021-06-15 17:46:57 +02:00
2022-04-21 07:36:56 -04:00
2022-05-19 14:08:53 -07:00
2022-03-21 12:57:38 -04:00
2022-05-13 07:20:17 -07:00
2022-04-28 23:16:14 -07:00
2022-05-12 10:29:41 -07:00
2021-07-01 11:06:05 -07:00
2021-12-16 22:22:20 +01:00
2022-04-28 16:31:10 +02:00
2022-04-01 14:40:44 -04:00
2022-05-17 13:32:46 -04:00
2022-02-09 09:24:40 -05:00
2022-01-12 10:14:09 -06:00
2021-11-16 19:07:53 -08:00
2021-09-17 13:52:17 +01:00
2021-09-27 09:27:29 -04:00
2022-02-02 07:49:59 -07:00
2021-09-27 17:00:21 +02:00
2021-06-16 17:20:40 -05:00
2021-07-06 10:37:46 -05:00
2022-02-09 08:04:44 +01:00
2022-02-09 08:04:44 +01:00
2021-10-14 13:29:18 +02:00
2021-06-07 14:11:47 -07:00
2022-01-22 08:33:37 +02:00
2022-01-08 12:43:57 -06:00
2021-11-18 09:36:39 +01:00
2022-01-24 14:45:02 +01:00
2022-06-10 11:29:48 +02:00
2022-03-08 14:33:36 -06:00
2022-03-17 20:16:29 -07:00
2022-03-23 19:58:41 +01:00
2021-03-18 12:58:27 -04:00
2022-05-22 21:03:01 +01:00
2022-04-07 12:53:54 +02:00
2022-02-24 15:04:51 +00:00
2022-06-02 10:15:05 -07:00
2021-08-06 13:41:48 -07:00
2022-05-08 01:33:08 -07:00
2021-08-19 09:02:55 +09:00
2021-06-24 15:49:32 +02:00
2022-02-25 09:36:06 +01:00
2022-04-11 19:18:27 -06:00
2022-03-22 15:57:11 -07:00
2021-11-25 18:35:23 +01:00
2022-01-26 14:54:48 +01:00
2022-01-27 13:53:27 +00:00
2021-10-12 11:41:39 -03:00
2022-05-24 08:41:18 -06:00
2022-05-31 12:45:10 -04:00
2022-06-13 09:54:52 -07:00
2021-02-09 12:15:07 +01:00
2021-08-11 06:44:24 -04:00
2021-10-19 23:44:30 +08:00