Files
linux/fs
J. Bruce Fields 2becaa990b nfsd: fix use-after-free due to delegation race
commit 548ec0805c upstream.

A delegation break could arrive as soon as we've called vfs_setlease.  A
delegation break runs a callback which immediately (in
nfsd4_cb_recall_prepare) adds the delegation to del_recall_lru.  If we
then exit nfs4_set_delegation without hashing the delegation, it will be
freed as soon as the callback is done with it, without ever being
removed from del_recall_lru.

Symptoms show up later as use-after-free or list corruption warnings,
usually in the laundromat thread.

I suspect aba2072f45 "nfsd: grant read delegations to clients holding
writes" made this bug easier to hit, but I looked as far back as v3.0
and it looks to me it already had the same problem.  So I'm not sure
where the bug was introduced; it may have been there from the beginning.

Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
[Salvatore Bonaccorso: Backport for context changes to versions which do
not have 20b7d86f29 ("nfsd: use boottime for lease expiry calculation")]
Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-12-22 09:19:01 +01:00
..
2020-11-05 11:08:53 +01:00
2021-06-30 08:48:14 -04:00
2019-08-06 19:06:51 +02:00
2021-07-20 16:15:46 +02:00
2021-09-22 11:48:02 +02:00
2018-08-17 16:20:28 -07:00
2021-11-26 11:36:12 +01:00
2021-11-26 11:36:23 +01:00
2018-07-03 16:44:45 -04:00
2018-06-05 19:23:26 +02:00
2020-03-05 16:42:12 +01:00
2020-03-25 08:06:14 +01:00
2021-05-22 10:59:50 +02:00
2018-06-11 08:22:34 -07:00
2021-12-14 10:18:07 +01:00