Dmitry Safonov 835cdc67d6 tty: Don't hold ldisc lock in tty_reopen() if ldisc present ...

commit d3736d82e8 upstream.

Try to get reference for ldisc during tty_reopen().
If ldisc present, we don't need to do tty_ldisc_reinit() and lock the
write side for line discipline semaphore.
Effectively, it optimizes fast-path for tty_reopen(), but more
importantly it won't interrupt ongoing IO on the tty as no ldisc change
is needed.
Fixes user-visible issue when tty_reopen() interrupted login process for
user with a long password, observed and reported by Lukas.

Fixes: c96cf923a9 ("tty: Don't block on IO when ldisc change is pending")
Fixes: 83d817f410 ("tty: Hold tty_ldisc_lock() during tty_reopen()")
Cc: Jiri Slaby <jslaby@suse.com>
Reported-by: Lukas F. Hartmann <lukas@mntmn.com>
Tested-by: Lukas F. Hartmann <lukas@mntmn.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Dmitry Safonov <dima@arista.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2023-05-15 11:01:10 +09:00

..

hvc

hvc_opal: don't set tb_ticks_per_usec in udbg_init_opal_common()

2023-05-12 16:39:49 +09:00

ipwireless

tty: ipwireless, cleanup TIOCGSERIAL

2016-06-25 08:56:30 -07:00

serial

serial/sunsu: fix refcount leak

2023-05-15 10:54:35 +09:00

vt

tty: vt_ioctl: fix potential Spectre v1

2023-05-15 08:25:18 +09:00

amiserial.c

tty: Replace ASYNC_INITIALIZED bit and update atomically

2016-04-30 09:26:55 -07:00

bfin_jtag_comm.c

TTY: bfin_jtag_comm: remove incorrect wait_until_sent operation

2015-03-07 03:44:14 +01:00

cyclades.c

tty: stop defining STD_COM_FLAGS in drivers

2016-06-25 08:56:30 -07:00

ehv_bytechan.c

drivers/tty: make ehv_bytechan.c explicitly non-modular

2016-02-06 23:26:43 -08:00

goldfish.c

tty: goldfish: Fix a parameter of a call to free_irq

2017-10-08 10:26:05 +02:00

isicom.c

tty: Replace ASYNC_INITIALIZED bit and update atomically

2016-04-30 09:26:55 -07:00

Kconfig

devpts: Make each mount of devpts an independent filesystem.

2016-06-05 10:36:01 -07:00

Makefile

TTY: Add MIPS EJTAG Fast Debug Channel TTY driver

2015-03-31 12:04:12 +02:00

metag_da.c

timers, drivers/tty/metag_da: Initialize the poll timer as pinned

2016-07-07 10:25:14 +02:00

mips_ejtag_fdc.c

timers, drivers/tty/mips_ejtag: Initialize the poll timer as pinned

2016-07-07 10:34:59 +02:00

moxa.c

tty: Replace ASYNC_INITIALIZED bit and update atomically

2016-04-30 09:26:55 -07:00

moxa.h

…

mxser.c

tty: cyclades+mxser, do not initialize to zero

2016-06-25 08:56:30 -07:00

mxser.h

Fix common misspellings

2011-03-31 11:26:23 -03:00

n_gsm.c

tty: n_gsm: Fix DLCI handling for ADM mode if debug & 2 is not set

2018-05-01 15:13:06 -07:00

n_hdlc.c

tty: n_hdlc: get rid of racy n_hdlc.tbuf

2017-03-15 10:02:40 +08:00

n_r3964.c

tty: r3964: Replace/remove bogus tty lock use

2015-10-17 21:11:29 -07:00

n_tracerouter.c

n_tracerouter: stop including <asm-generic/bug>

2015-10-15 00:21:10 +02:00

n_tracesink.c

n_tracesink: stop including <asm-generic/bug>

2015-10-15 00:21:11 +02:00

n_tracesink.h

n_tracerouter and n_tracesink ldisc additions.

2011-05-13 16:31:00 -07:00

n_tty.c

tty: wipe buffer if not echoing data

2023-05-15 09:59:16 +09:00

nozomi.c

tty: Replace TTY_THROTTLED bit tests with tty_throttled()

2016-04-30 09:26:55 -07:00

pty.c

tty: Fix data race in tty_insert_flip_string_fixed_flag

2023-05-12 16:42:37 +09:00

rocket_int.h

tty: rocket: Remove private close_wait

2016-01-28 14:13:44 -08:00

rocket.c

tty: rocket: Fix possible buffer overwrite on register_PCI

2023-05-15 08:14:01 +09:00

rocket.h

tty: rocket: fix comment of ROCKET_SPD_HI

2015-05-24 12:49:16 -07:00

synclink_gt.c

Merge tag 'tty-4.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty

2016-05-20 20:57:27 -07:00

synclink.c

Merge tag 'tty-4.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty

2016-05-20 20:57:27 -07:00

synclinkmp.c

Merge tag 'tty-4.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty

2016-05-20 20:57:27 -07:00

sysrq.c

debug: add watchdog trigger in sysrq

2018-05-09 21:14:17 -07:00

tty_audit.c

tty: audit: remove unused variable

2016-03-07 16:11:14 -08:00

tty_buffer.c

tty: wipe buffer.

2023-05-15 09:59:14 +09:00

tty_io.c

tty: Don't hold ldisc lock in tty_reopen() if ldisc present

2023-05-15 11:01:10 +09:00

tty_ioctl.c

termios, tty/tty_baudrate.c: fix buffer overrun

2023-05-15 09:27:11 +09:00

tty_ldisc.c

tty: Use __GFP_NOFAIL for tty_ldisc_get()

2018-05-01 15:13:06 -07:00

tty_ldsem.c

tty/ldsem: Wake up readers after timed out down_write()

2023-05-15 11:01:07 +09:00

tty_mutex.c

Merge 4.5-rc4 into tty-next

2016-02-14 14:36:04 -08:00

tty_port.c

tty: do not set TTY_IO_ERROR flag if console port

2023-05-15 10:26:59 +09:00