Files
linux/crypto
Eric Biggers ad28c2ba43 crypto: chacha20 - Fix chacha20_block() keystream alignment (again)
[ Upstream commit a5e9f55709 ]

In commit 9f480faec5 ("crypto: chacha20 - Fix keystream alignment for
chacha20_block()"), I had missed that chacha20_block() can be called
directly on the buffer passed to get_random_bytes(), which can have any
alignment.  So, while my commit didn't break anything, it didn't fully
solve the alignment problems.

Revert my solution and just update chacha20_block() to use
put_unaligned_le32(), so the output buffer need not be aligned.
This is simpler, and on many CPUs it's the same speed.

But, I kept the 'tmp' buffers in extract_crng_user() and
_get_random_bytes() 4-byte aligned, since that alignment is actually
needed for _crng_backtrack_protect() too.

Reported-by: Stephan Müller <smueller@chronox.de>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-11-20 18:47:11 +01:00
..
2018-06-18 20:17:38 +05:30
2018-05-26 09:16:44 +02:00
2018-05-26 09:16:44 +02:00
2018-04-21 00:58:34 +08:00
2018-04-21 00:58:34 +08:00
2018-04-21 00:58:34 +08:00
2018-07-20 13:51:21 +08:00
2018-11-13 11:08:46 -08:00
2018-05-16 07:23:35 +02:00
2019-01-09 17:38:44 +01:00
2018-04-21 00:58:30 +08:00