Files
linux/include/linux
Yang Shi 88aa7cc688 mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct
mmap_sem is on the hot path of kernel, and it very contended, but it is
abused too.  It is used to protect arg_start|end and evn_start|end when
reading /proc/$PID/cmdline and /proc/$PID/environ, but it doesn't make
sense since those proc files just expect to read 4 values atomically and
not related to VM, they could be set to arbitrary values by C/R.

And, the mmap_sem contention may cause unexpected issue like below:

INFO: task ps:14018 blocked for more than 120 seconds.
       Tainted: G            E 4.9.79-009.ali3000.alios7.x86_64 #1
 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this
message.
 ps              D    0 14018      1 0x00000004
 Call Trace:
   schedule+0x36/0x80
   rwsem_down_read_failed+0xf0/0x150
   call_rwsem_down_read_failed+0x18/0x30
   down_read+0x20/0x40
   proc_pid_cmdline_read+0xd9/0x4e0
   __vfs_read+0x37/0x150
   vfs_read+0x96/0x130
   SyS_read+0x55/0xc0
   entry_SYSCALL_64_fastpath+0x1a/0xc5

Both Alexey Dobriyan and Michal Hocko suggested to use dedicated lock
for them to mitigate the abuse of mmap_sem.

So, introduce a new spinlock in mm_struct to protect the concurrent
access to arg_start|end, env_start|end and others, as well as replace
write map_sem to read to protect the race condition between prctl and
sys_brk which might break check_data_rlimit(), and makes prctl more
friendly to other VM operations.

This patch just eliminates the abuse of mmap_sem, but it can't resolve
the above hung task warning completely since the later
access_remote_vm() call needs acquire mmap_sem.  The mmap_sem
scalability issue will be solved in the future.

[yang.shi@linux.alibaba.com: add comment about mmap_sem and arg_lock]
  Link: http://lkml.kernel.org/r/1524077799-80690-1-git-send-email-yang.shi@linux.alibaba.com
Link: http://lkml.kernel.org/r/1523730291-109696-1-git-send-email-yang.shi@linux.alibaba.com
Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
Reviewed-by: Cyrill Gorcunov <gorcunov@openvz.org>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Mateusz Guzik <mguzik@redhat.com>
Cc: Kirill Tkhai <ktkhai@virtuozzo.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-06-07 17:34:34 -07:00
..
2018-05-25 18:23:56 +02:00
2018-01-01 22:54:42 -08:00
2018-05-31 15:35:38 -04:00
2018-02-20 11:34:54 +00:00
2018-06-05 10:48:09 -04:00
2018-04-16 14:20:26 -04:00
2018-05-26 09:16:44 +02:00
2018-04-20 17:18:35 -07:00
2017-06-08 18:52:36 -07:00
2018-03-16 10:56:13 +01:00
2018-05-28 17:41:02 +02:00
2018-05-09 17:25:13 +02:00
2017-11-15 18:21:04 -08:00
2018-03-16 15:45:51 -07:00
2018-03-16 10:55:47 +01:00
2018-03-26 15:09:38 +02:00
2018-06-07 17:34:33 -07:00
2018-04-27 14:34:51 +02:00
2017-08-24 13:23:03 -07:00
2017-11-27 16:19:56 -05:00
2018-06-01 07:38:16 -06:00
2018-01-01 12:40:27 -07:00
2018-03-26 15:56:44 +02:00
2017-08-07 17:22:14 +02:00
2017-11-13 01:41:20 +01:00
2018-04-26 09:02:01 -06:00
2018-04-16 14:25:08 -06:00
2018-02-22 21:13:03 +01:00
2017-06-21 14:37:12 -04:00
2018-03-26 08:53:43 -06:00
2018-01-17 11:30:16 +00:00
2018-05-09 12:21:46 -05:00
2018-04-11 10:28:38 -07:00
2017-11-15 18:21:01 -08:00
2017-12-01 13:09:40 -08:00
2018-04-12 09:41:19 -07:00
2017-10-07 10:45:02 -06:00
2017-08-28 20:51:22 +02:00
2018-06-05 08:50:16 -04:00
2018-04-11 10:28:32 -07:00
2018-06-07 17:34:33 -07:00
2018-03-26 13:14:43 -04:00
2018-03-26 13:14:43 -04:00
2017-11-17 16:10:00 -08:00
2018-01-28 22:17:24 -05:00
2017-07-25 18:05:25 +02:00
2018-06-01 14:37:35 +02:00
2018-01-08 08:22:45 -06:00
2018-01-17 15:25:50 +01:00
2018-01-08 08:22:45 -06:00
2018-04-11 10:28:39 -07:00
2018-01-31 17:18:37 -08:00
2017-11-09 10:23:28 +01:00
2018-05-09 06:57:18 +02:00
2018-01-19 16:50:53 -08:00
2017-11-17 16:10:04 -08:00
2017-11-17 16:10:04 -08:00
2017-11-13 01:33:48 +01:00
2017-12-16 02:05:48 +01:00
2018-05-31 00:13:56 +08:00
2018-05-11 17:28:45 -07:00
2018-05-11 17:28:45 -07:00
2017-12-11 14:37:11 -07:00
2018-06-04 17:28:20 -04:00
2018-03-17 14:20:55 +01:00
2018-03-01 08:33:05 -07:00
2017-11-07 12:22:21 +01:00
2018-05-04 12:48:54 -07:00
2018-04-30 05:14:55 -07:00
2018-05-03 15:55:23 -07:00
2018-01-15 12:07:46 -08:00
2018-04-16 14:25:08 -06:00
2018-02-06 18:32:47 -08:00
2018-01-09 16:27:43 +01:00
2018-05-18 11:40:27 -04:00
2018-05-19 13:57:31 +02:00
2018-05-19 13:57:31 +02:00
2018-02-20 16:10:25 -08:00
2018-04-26 15:08:04 -04:00
2018-02-06 18:32:44 -08:00
2017-12-20 09:53:54 -07:00
2017-10-04 10:29:22 +02:00
2018-05-14 09:51:34 -04:00
2017-08-15 09:02:07 -07:00
2017-08-15 09:02:08 -07:00