Yunfeng Ye d983182d40 crypto: hisilicon - Fix double free in sec_free_hw_sgl() ...

[ Upstream commit 24fbf7bad8 ]

There are two problems in sec_free_hw_sgl():

First, when sgl_current->next is valid, @hw_sgl will be freed in the
first loop, but it free again after the loop.

Second, sgl_current and sgl_current->next_sgl is not match when
dma_pool_free() is invoked, the third parameter should be the dma
address of sgl_current, but sgl_current->next_sgl is the dma address
of next chain, so use sgl_current->next_sgl is wrong.

Fix this by deleting the last dma_pool_free() in sec_free_hw_sgl(),
modifying the condition for while loop, and matching the address for
dma_pool_free().

Fixes: 915e4e8413 ("crypto: hisilicon - SEC security accelerator driver")
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2019-10-07 18:57:16 +02:00

..

sec

crypto: hisilicon - Fix double free in sec_free_hw_sgl()

2019-10-07 18:57:16 +02:00

Kconfig

crypto: hisilicon - SEC security accelerator driver

2018-08-03 18:06:02 +08:00

Makefile

crypto: hisilicon - SEC security accelerator driver

2018-08-03 18:06:02 +08:00