Files
linux/include/linux
Masami Hiramatsu (Google) fbcd0c2b56 fprobe: Ensure running fprobe_exit_handler() finished before calling rethook_free()
commit 195b9cb5b2 upstream.

Ensure running fprobe_exit_handler() has finished before
calling rethook_free() in the unregister_fprobe() so that caller can free
the fprobe right after unregister_fprobe().

unregister_fprobe() ensured that all running fprobe_entry/exit_handler()
have finished by calling unregister_ftrace_function() which synchronizes
RCU. But commit 5f81018753 ("fprobe: Release rethook after the ftrace_ops
is unregistered") changed to call rethook_free() after
unregister_ftrace_function(). So call rethook_stop() to make rethook
disabled before unregister_ftrace_function() and ensure it again.

Here is the possible code flow that can call the exit handler after
unregister_fprobe().

------
 CPU1                              CPU2
 call unregister_fprobe(fp)
 ...
                                   __fprobe_handler()
                                   rethook_hook() on probed function
 unregister_ftrace_function()
                                   return from probed function
                                   rethook hooks
                                   find rh->handler == fprobe_exit_handler
                                   call fprobe_exit_handler()
 rethook_free():
   set rh->handler = NULL;
 return from unreigster_fprobe;
                                   call fp->exit_handler() <- (*)
------

(*) At this point, the exit handler is called after returning from
unregister_fprobe().

This fixes it as following;
------
 CPU1                              CPU2
 call unregister_fprobe()
 ...
 rethook_stop():
   set rh->handler = NULL;
                                   __fprobe_handler()
                                   rethook_hook() on probed function
 unregister_ftrace_function()
                                   return from probed function
                                   rethook hooks
                                   find rh->handler == NULL
                                   return from rethook
 rethook_free()
 return from unreigster_fprobe;
------

Link: https://lore.kernel.org/all/168873859949.156157.13039240432299335849.stgit@devnote2/

Fixes: 5f81018753 ("fprobe: Release rethook after the ftrace_ops is unregistered")
Cc: stable@vger.kernel.org
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-07-23 13:49:46 +02:00
..
2023-07-19 16:21:11 +02:00
2023-06-21 16:01:00 +02:00
2022-05-22 20:44:29 +01:00
2022-03-23 19:58:38 +01:00
2023-05-24 17:32:41 +01:00
2022-02-01 14:25:50 +02:00
2022-07-05 20:25:39 +02:00
2022-01-22 08:33:34 +02:00
2022-09-21 11:18:28 +09:00
2023-07-19 16:21:05 +02:00
2022-09-26 19:46:29 -07:00
2022-09-26 10:13:13 -07:00
2022-09-26 10:13:13 -07:00
2022-09-15 09:32:06 -07:00
2022-09-26 10:13:14 -07:00
2022-03-15 10:32:44 +01:00
2021-12-10 17:10:55 -08:00
2021-08-26 15:32:28 -04:00
2022-07-01 14:53:01 +02:00
2021-07-27 11:00:36 +02:00
2022-01-20 08:52:54 +02:00
2021-07-27 20:11:45 +01:00
2021-07-27 20:11:44 +01:00
2022-10-03 14:02:45 -07:00
2022-08-16 12:46:26 +02:00
2022-06-09 21:53:09 -07:00
2022-02-28 23:26:27 -08:00
2022-09-01 18:04:43 +02:00
2022-06-27 06:29:12 -06:00
2022-09-08 12:59:00 -06:00
2022-09-26 13:31:20 +02:00
2022-09-01 18:08:44 +02:00
2022-07-17 17:31:38 -07:00
2022-10-03 14:03:19 -07:00
2022-05-02 14:06:20 -06:00
2022-01-27 13:53:26 +00:00
2022-05-03 16:09:03 -04:00
2022-06-19 10:38:26 +01:00
2022-07-27 14:04:52 +02:00
2022-09-26 19:46:18 -07:00
2022-04-28 23:16:14 -07:00
2022-09-26 10:13:13 -07:00
2022-08-02 12:34:04 -04:00
2021-07-01 11:06:05 -07:00
2023-05-30 14:03:22 +01:00
2022-09-01 17:39:49 -04:00
2022-05-17 13:32:46 -04:00
2022-08-09 14:11:34 -04:00
2022-02-09 09:24:40 -05:00
2022-01-12 10:14:09 -06:00
2022-10-03 17:34:32 -07:00
2022-09-26 19:46:27 -07:00
2021-09-17 13:52:17 +01:00
2021-09-27 09:27:29 -04:00
2022-02-02 07:49:59 -07:00
2021-09-27 17:00:21 +02:00
2021-07-06 10:37:46 -05:00
2022-02-09 08:04:44 +01:00
2022-02-09 08:04:44 +01:00
2022-10-17 16:32:05 +02:00
2021-10-14 13:29:18 +02:00
2022-10-04 20:52:38 +02:00
2022-01-08 12:43:57 -06:00
2022-01-24 14:45:02 +01:00
2022-03-08 14:33:36 -06:00
2022-03-23 19:58:41 +01:00
2022-05-22 21:03:01 +01:00
2022-04-07 12:53:54 +02:00
2022-06-27 14:41:31 +02:00
2023-07-19 16:21:54 +02:00
2022-02-24 15:04:51 +00:00
2022-05-08 01:33:08 -07:00
2021-08-19 09:02:55 +09:00
2022-09-07 12:42:25 +01:00
2022-02-25 09:36:06 +01:00
2022-09-29 15:20:29 +02:00
2022-04-11 19:18:27 -06:00
2022-03-22 15:57:11 -07:00
2022-09-22 16:12:34 +02:00
2021-11-25 18:35:23 +01:00
2022-09-22 16:12:34 +02:00
2022-08-31 13:37:32 +02:00
2022-09-01 11:42:12 +01:00
2021-10-12 11:41:39 -03:00
2022-08-28 16:52:28 +01:00
2022-10-07 09:32:40 -04:00
2022-11-10 12:03:36 -07:00
2022-09-26 19:46:18 -07:00
2022-06-13 09:54:52 -07:00
2022-09-26 19:46:18 -07:00
2021-08-11 06:44:24 -04:00
2022-07-10 21:17:30 -04:00
2021-10-19 23:44:30 +08:00