Files
linux/fs
David Disseldorp 965eb86507 ksmbd: remove unused compression negotiate ctx packing
[ Upstream commit af36c51e0e ]

build_compression_ctxt() is currently unreachable due to
conn.compress_algorithm remaining zero (SMB3_COMPRESS_NONE).

It appears to have been broken in a couple of subtle ways over the
years:
- prior to d6c9ad23b4 ("ksmbd: use the common definitions for
  NEGOTIATE_PROTOCOL") smb2_compression_ctx.DataLength was set to 8,
  which didn't account for the single CompressionAlgorithms flexible
  array member.
- post d6c9ad23b4 smb2_compression_capabilities_context
  CompressionAlgorithms is a three member array, while
  CompressionAlgorithmCount is set to indicate only one member.
  assemble_neg_contexts() ctxt_size is also incorrectly incremented by
  sizeof(struct smb2_compression_capabilities_context) + 2, which
  assumes one flexible array member.

Signed-off-by: David Disseldorp <ddiss@suse.de>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-01-05 15:18:29 +01:00
..
2023-11-28 17:07:19 +00:00
2022-05-09 16:21:45 -04:00
2022-09-24 07:00:00 +02:00
2022-05-09 16:21:46 -04:00
2023-09-13 09:43:05 +02:00
2022-09-11 20:26:07 -07:00
2023-02-22 12:59:46 +01:00
2023-09-23 11:11:10 +02:00
2022-09-24 07:00:00 +02:00
2022-08-20 11:34:33 -04:00
2023-11-28 17:07:15 +00:00
2023-08-30 16:11:10 +02:00
2023-01-04 11:29:01 +01:00
2022-06-28 13:58:05 -04:00