Jim Bos
726f22c83d
Fix gcc 4.5.1 miscompiling drivers/char/i8k.c (again)
...
commit 22d3243de8 upstream.
The fix in commit 6b4e81db25 ("i8k: Tell gcc that *regs gets
clobbered") to work around the gcc miscompiling i8k.c to add "+m
(*regs)" caused register pressure problems and a build failure.
Changing the 'asm' statement to 'asm volatile' instead should prevent
that and works around the gcc bug as well, so we can remove the "+m".
[ Background on the gcc bug: a memory clobber fails to mark the function
the asm resides in as non-pure (aka "__attribute__((const))"), so if
the function does nothing else that triggers the non-pure logic, gcc
will think that that function has no side effects at all. As a result,
callers will be mis-compiled.
Adding the "+m" made gcc see that it's not a pure function, and so
does "asm volatile". The problem was never really the need to mark
"*regs" as changed, since the memory clobber did that part - the
problem was just a bug in the gcc "pure" function analysis - Linus ]
Signed-off-by: Jim Bos <jim876@xs4all.nl >
Acked-by: Jakub Jelinek <jakub@redhat.com >
Cc: Andi Kleen <andi@firstfloor.org >
Cc: Andreas Schwab <schwab@linux-m68k.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-05-09 15:54:59 -07:00
..
2011-05-09 15:54:54 -07:00
2009-10-22 16:39:34 +10:30
2009-06-11 08:51:01 -07:00
2010-07-05 11:10:57 -07:00
2009-09-24 07:21:03 -07:00
2010-11-22 10:47:30 -08:00
2009-10-11 11:20:58 -07:00
2011-04-14 16:53:34 -07:00
2009-10-01 16:11:11 -07:00
2006-10-03 17:59:17 +01:00
2009-07-12 12:22:34 -07:00
2009-10-01 16:11:11 -07:00
2009-10-11 11:20:58 -07:00
2005-04-16 15:20:36 -07:00
2009-06-22 11:32:23 -07:00
2009-10-01 16:11:11 -07:00
2008-06-20 14:05:55 -06:00
2009-06-26 14:37:26 +10:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2009-01-06 15:59:30 -08:00
2008-12-13 11:25:49 -08:00
2008-06-20 14:05:53 -06:00
2009-10-01 16:11:16 -07:00
2008-03-03 14:53:16 -08:00
2005-04-16 15:20:36 -07:00
2005-09-07 16:57:20 -07:00
2005-09-07 16:57:20 -07:00
2005-04-16 15:20:36 -07:00
2008-10-20 08:52:41 -07:00
2008-12-13 09:12:07 +00:00
2008-10-16 09:24:42 -07:00
2009-10-04 15:05:10 -07:00
2008-08-04 16:59:56 -07:00
2009-10-11 11:20:58 -07:00
2008-07-20 17:12:36 -07:00
2005-04-16 15:20:36 -07:00
2009-09-19 13:13:31 -07:00
2009-09-11 16:02:11 +10:00
2009-10-11 11:20:58 -07:00
2009-10-13 10:20:16 -07:00
2008-02-03 17:11:42 +02:00
2010-12-09 13:26:36 -08:00
2009-01-08 16:25:16 +11:00
2011-01-07 14:43:12 -08:00
2009-09-24 15:12:47 +10:00
2009-01-13 14:48:01 +11:00
2009-06-16 14:15:44 +10:00
2011-02-17 15:36:52 -08:00
2008-02-14 22:11:02 +11:00
2008-11-19 16:04:25 +11:00
2009-08-28 14:24:11 +10:00
2009-11-03 11:05:51 -08:00
2009-06-18 11:16:55 +10:00
2009-08-20 10:29:28 +10:00
2011-05-09 15:54:59 -07:00
2009-09-19 13:13:27 -07:00
2009-10-11 11:20:58 -07:00
2009-10-30 14:43:12 -07:00
2009-11-25 23:05:17 -08:00
2008-10-16 09:24:42 -07:00
2009-09-24 07:21:03 -07:00
2009-09-15 08:42:00 -07:00
2008-02-07 08:42:25 -08:00
2010-09-26 17:21:26 -07:00
2009-09-23 07:39:29 -07:00
2008-07-17 11:34:49 -07:00
2009-07-12 12:22:34 -07:00
2008-04-30 08:29:43 -07:00
2009-09-27 11:39:25 -07:00
2009-09-19 13:13:38 -07:00
2008-04-30 08:29:49 -07:00
2009-07-12 12:22:34 -07:00
2009-07-12 12:22:34 -07:00
2009-09-19 13:13:34 -07:00
2010-01-25 10:49:20 -08:00
2006-12-08 08:28:44 -08:00
2010-08-13 13:19:31 -07:00
2007-02-12 09:48:30 -08:00
2006-10-05 15:10:12 +01:00
2008-12-13 09:12:07 +00:00
2008-10-20 08:52:40 -07:00
2009-06-18 13:03:54 -07:00
2009-06-15 16:47:27 +10:00
2009-10-11 11:20:58 -07:00
2010-02-09 04:50:58 -08:00
2010-04-26 07:41:19 -07:00
2005-04-16 15:20:36 -07:00
2009-09-19 13:13:37 -07:00
2008-07-20 17:12:38 -07:00
2009-01-02 10:19:39 -08:00
2009-07-12 12:22:34 -07:00
2009-01-02 10:19:39 -08:00
2009-10-13 10:20:16 -07:00
2009-02-22 09:23:02 -08:00
2008-06-20 14:05:53 -06:00
2009-06-11 08:51:01 -07:00
2009-10-11 11:20:58 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2009-10-01 16:11:16 -07:00
2008-05-16 12:01:45 -07:00
2008-10-16 09:24:42 -07:00
2008-04-18 22:22:54 -04:00
2009-10-13 10:20:16 -07:00
2008-07-20 17:12:38 -07:00
2009-07-20 16:38:43 -07:00
2009-10-11 11:20:58 -07:00
2009-07-12 12:22:34 -07:00
2008-02-07 08:42:33 -08:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2009-09-01 01:13:31 -07:00
2009-09-01 01:13:31 -07:00
2009-09-01 01:13:31 -07:00
2009-09-21 14:28:04 +02:00
2009-07-03 15:45:29 +01:00
2009-10-11 11:20:58 -07:00
2008-04-30 23:15:34 +02:00
2009-06-11 08:51:02 -07:00
2010-12-09 13:26:46 -08:00
2010-04-26 07:41:18 -07:00
2009-09-19 13:13:35 -07:00
2011-01-07 14:43:01 -08:00
2009-11-30 16:38:25 -08:00
2009-09-24 07:21:03 -07:00
2009-07-20 16:38:43 -07:00
2009-06-02 10:32:34 +10:00
2009-10-22 16:39:28 +10:30
2009-01-12 20:56:38 +01:00
2010-12-09 13:26:44 -08:00
2009-09-19 13:13:35 -07:00