Richard Cochran e31a6f9067
net: phylink: Remove redundant netdev.phydev assignment ...
As a part of working on MII time stamping infrastructure, I was trying
to figure out how netdev->phydev gets assigned, and I stumbled across
this. Ever since the new phylink code came in, the field is assigned
twice.
The function, phylink_connect_phy(), calls
phy_attach_direct()
phylink_bringup_phy()
and phy_attach_direct() sets
dev->phydev = phydev;
but phylink_bringup_phy() then sets the same field again:
pl->netdev->phydev = phy;
Similarly, the function, phylink_of_phy_connect(), calls
of_phy_attach()
phy_attach_direct()
phylink_bringup_phy()
The removal code is also duplicated:
phylink_disconnect_phy()
pl->netdev->phydev = NULL;
phy_disconnect()
phy_detach()
phydev->attached_dev->phydev = NULL;
This patch removes the redundant assignments, restricting manipulation
of the netdev.phydev field to phy_attach_direct() and phy_detach().
Signed-off-by: Richard Cochran <richardcochran@gmail.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2018-03-01 13:26:14 -05:00
2018-02-15 12:02:42 +01:00
2018-02-16 11:16:38 +01:00
2018-02-06 09:59:40 -08:00
2018-02-23 12:42:26 -05:00
2018-01-10 17:50:01 +01:00
2018-02-15 14:50:32 -08:00
2018-01-19 22:59:33 -05:00
2018-02-08 11:38:59 -08:00
2018-02-15 15:43:49 -05:00
2018-02-01 16:35:31 -08:00
2018-02-14 17:02:15 -08:00
2018-02-07 11:22:44 -08:00
2018-01-08 17:57:26 +01:00
2018-02-14 17:02:15 -08:00
2018-02-02 10:01:04 -08:00
2018-02-22 16:38:10 -08:00
2018-02-03 00:26:10 -07:00
2018-01-02 09:36:54 +09:00
2018-02-02 09:50:51 -08:00
2018-02-11 14:34:03 -08:00
2018-02-14 17:02:15 -08:00
2018-01-23 09:04:10 +01:00
2018-02-14 06:37:33 +09:00
2018-02-11 14:34:03 -08:00
2018-02-08 10:44:25 -08:00
2017-12-18 15:59:16 +01:00
2018-02-11 14:34:03 -08:00
2018-02-23 11:11:57 +10:00
2018-02-15 18:44:03 +01:00
2018-02-11 14:34:03 -08:00
2018-02-11 14:34:03 -08:00
2018-02-15 14:31:28 -08:00
2018-02-01 10:31:17 -08:00
2018-02-22 12:15:35 +01:00
2018-02-06 09:59:40 -08:00
2018-02-20 10:03:22 +01:00
2018-02-28 09:54:54 -05:00
2018-02-11 14:34:03 -08:00
2018-02-08 12:03:54 -08:00
2018-02-16 14:22:16 +00:00
2018-02-12 14:15:04 -05:00
2018-02-11 14:34:03 -08:00
2018-01-05 08:50:12 -07:00
2018-02-13 08:58:53 -08:00
2018-02-11 14:34:03 -08:00
2018-02-16 10:46:35 -05:00
2018-02-11 14:34:03 -08:00
2018-02-01 16:35:31 -08:00
2018-01-30 21:32:06 -05:00
2018-02-11 14:34:03 -08:00
2018-02-22 12:04:05 -08:00
2018-02-14 11:30:10 +01:00
2018-02-12 10:57:20 +01:00
2018-02-01 10:31:17 -08:00
2018-03-01 13:26:14 -05:00
2018-01-28 22:17:24 -05:00
2018-01-16 16:47:29 +01:00
2018-02-03 00:26:26 -07:00
2018-02-14 15:44:22 +02:00
2018-01-02 14:46:35 +01:00
2018-02-12 10:41:11 +01:00
2018-02-12 15:07:46 +05:30
2018-01-02 21:01:02 +01:00
2018-02-16 15:41:53 -05:00
2018-02-08 11:48:49 -08:00
2018-02-20 11:34:54 +00:00
2018-02-01 09:40:49 -08:00
2018-02-02 14:22:53 -08:00
2018-02-15 12:18:33 +02:00
2017-12-18 16:47:27 +01:00
2018-01-31 12:55:31 -08:00
2018-01-17 12:56:24 +01:00
2018-02-11 14:34:03 -08:00
2018-02-11 14:34:03 -08:00
2018-02-11 14:34:03 -08:00
2018-01-23 12:17:42 -06:00
2018-01-30 12:25:59 +00:00
2018-02-05 10:07:40 -08:00
2018-02-11 14:34:03 -08:00
2018-02-11 14:34:03 -08:00
2018-02-15 14:29:27 -08:00
2018-02-06 09:59:40 -08:00
2018-02-24 00:04:20 -05:00
2018-02-08 10:21:39 +01:00
2017-12-19 10:56:53 +01:00
2018-01-09 17:01:15 +01:00
2018-02-12 14:15:04 -05:00
2018-01-22 16:45:26 +01:00
2018-01-26 17:57:34 +00:00
2018-02-01 10:37:39 +02:00
2018-02-24 00:04:20 -05:00
2018-02-12 14:15:04 -05:00
2018-01-11 18:05:06 -08:00
2018-02-06 15:04:58 -08:00
2017-12-16 16:37:51 +01:00
2018-02-11 14:34:03 -08:00
2018-02-11 14:34:03 -08:00
2018-02-22 12:13:01 -08:00
2018-01-09 16:15:20 +01:00
2018-02-11 14:34:03 -08:00
2018-02-12 14:15:04 -05:00
2018-02-14 17:02:15 -08:00
2018-02-11 14:34:03 -08:00
2018-02-01 16:26:45 +02:00
2017-12-18 15:59:18 +01:00
2018-01-31 19:25:25 -08:00
2018-02-07 11:54:34 -08:00
2018-02-21 15:35:43 -08:00
2018-02-01 10:31:17 -08:00
2018-02-06 09:59:40 -08:00
e31a6f9067