Eric Dumazet
a4b012c648
ipvs: move old_secure_tcp into struct netns_ipvs
...
[ Upstream commit c24b75e0f9 ]
syzbot reported the following issue :
BUG: KCSAN: data-race in update_defense_level / update_defense_level
read to 0xffffffff861a6260 of 4 bytes by task 3006 on cpu 1:
update_defense_level+0x621/0xb30 net/netfilter/ipvs/ip_vs_ctl.c:177
defense_work_handler+0x3d/0xd0 net/netfilter/ipvs/ip_vs_ctl.c:225
process_one_work+0x3d4/0x890 kernel/workqueue.c:2269
worker_thread+0xa0/0x800 kernel/workqueue.c:2415
kthread+0x1d4/0x200 drivers/block/aoe/aoecmd.c:1253
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
write to 0xffffffff861a6260 of 4 bytes by task 7333 on cpu 0:
update_defense_level+0xa62/0xb30 net/netfilter/ipvs/ip_vs_ctl.c:205
defense_work_handler+0x3d/0xd0 net/netfilter/ipvs/ip_vs_ctl.c:225
process_one_work+0x3d4/0x890 kernel/workqueue.c:2269
worker_thread+0xa0/0x800 kernel/workqueue.c:2415
kthread+0x1d4/0x200 drivers/block/aoe/aoecmd.c:1253
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
Reported by Kernel Concurrency Sanitizer on:
CPU: 0 PID: 7333 Comm: kworker/0:5 Not tainted 5.4.0-rc3+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: events defense_work_handler
Indeed, old_secure_tcp is currently a static variable, while it
needs to be a per netns variable.
Fixes: a0840e2e16 ("IPVS: netns, ip_vs_ctl local vars moved to ipvs struct.")
Signed-off-by: Eric Dumazet <edumazet@google.com >
Reported-by: syzbot <syzkaller@googlegroups.com >
Signed-off-by: Simon Horman <horms@verge.net.au >
Signed-off-by: Sasha Levin <sashal@kernel.org >
2019-11-12 19:15:57 +01:00
..
2019-11-12 19:15:45 +01:00
2019-11-12 19:15:57 +01:00
2017-12-16 16:25:46 +01:00
2016-08-22 11:42:22 +02:00
2016-09-25 23:16:42 +02:00
2015-03-18 10:51:35 +01:00
2015-02-22 15:59:54 -05:00
2011-01-18 18:12:24 +01:00
2019-08-25 10:51:51 +02:00
2017-10-08 10:26:09 +02:00
2017-10-21 17:21:34 +02:00
2017-08-24 17:12:18 -07:00
2019-09-21 07:14:16 +02:00
2016-07-11 12:32:45 +02:00
2016-09-24 21:29:53 +02:00
2008-01-31 19:28:07 -08:00
2018-03-24 11:00:14 +01:00
2016-07-21 02:31:53 +02:00
2014-11-05 14:10:33 -05:00
2016-07-22 17:05:10 +02:00
2011-01-18 18:12:24 +01:00
2019-08-25 10:51:42 +02:00
2016-08-30 11:43:09 +02:00
2018-08-24 13:12:41 +02:00
2016-08-13 13:27:13 +02:00
2016-09-07 10:36:52 +02:00
2016-08-13 13:27:13 +02:00
2016-08-13 13:27:13 +02:00
2016-08-13 13:27:13 +02:00
2016-08-12 00:41:08 +02:00
2016-08-13 13:27:13 +02:00
2016-07-21 02:31:53 +02:00
2019-01-13 10:03:48 +01:00
2017-06-17 06:41:49 +02:00
2013-01-18 00:28:18 +01:00
2016-09-25 14:54:08 +02:00
2016-07-21 02:31:53 +02:00
2015-12-14 12:48:58 +01:00
2013-12-20 14:58:29 +01:00
2016-03-01 17:36:47 -05:00
2016-10-20 19:59:59 +02:00
2016-09-25 23:16:45 +02:00
2018-08-24 13:12:32 +02:00
2013-04-18 20:27:55 +02:00
2018-10-20 09:51:32 +02:00
2013-02-19 02:48:05 +01:00
2013-08-28 00:26:48 +02:00
2014-01-06 14:17:17 +01:00
2018-03-18 11:18:53 +01:00
2015-08-17 21:33:06 -07:00
2014-06-30 11:38:03 +02:00
2015-08-17 21:33:06 -07:00
2015-08-17 21:33:06 -07:00
2015-08-17 21:33:06 -07:00
2012-08-30 03:00:14 +02:00
2015-10-27 06:54:56 +01:00
2014-10-14 02:18:24 +02:00
2013-02-19 02:48:05 +01:00
2016-10-20 19:59:59 +02:00
2014-08-08 16:47:23 +02:00
2015-09-05 21:57:42 -07:00
2019-02-27 10:07:03 +01:00
2018-07-11 16:26:42 +02:00
2016-09-12 19:54:45 +02:00
2016-09-12 19:54:45 +02:00
2016-09-25 23:34:19 +02:00
2016-08-25 13:11:00 +02:00
2018-01-31 12:55:52 +01:00
2017-10-08 10:26:09 +02:00
2016-09-24 21:29:53 +02:00
2018-07-17 11:37:54 +02:00
2019-08-25 10:51:22 +02:00
2016-09-23 09:29:02 +02:00
2016-09-23 09:29:02 +02:00
2016-09-23 09:29:02 +02:00
2016-07-23 12:25:00 +02:00
2016-04-23 20:13:24 -04:00
2019-02-20 10:18:34 +01:00
2016-01-03 21:04:23 +01:00
2018-03-24 11:00:14 +01:00
2016-10-17 17:43:54 +02:00
2016-01-04 17:48:38 +01:00
2016-11-24 14:40:03 +01:00
2016-09-23 09:29:02 +02:00
2016-10-04 08:59:03 +02:00
2017-06-17 06:41:58 +02:00
2016-09-23 09:30:48 +02:00
2016-03-02 20:05:27 +01:00
2019-02-20 10:18:34 +01:00
2019-02-20 10:18:34 +01:00
2016-09-22 16:33:05 +02:00
2016-09-23 09:30:26 +02:00
2017-11-30 08:39:14 +00:00
2016-09-07 11:02:06 +02:00
2016-11-24 14:43:35 +01:00
2015-04-13 17:17:28 +02:00
2016-08-25 12:55:34 +02:00
2016-08-25 12:55:34 +02:00
2016-10-27 18:22:02 +02:00
2019-05-04 08:49:06 +02:00
2019-05-16 19:43:39 +02:00
2015-09-18 21:58:25 +02:00
2014-03-13 14:13:19 +01:00
2014-08-02 15:03:58 -07:00
2018-02-25 11:05:43 +01:00
2010-07-15 17:20:46 +02:00
2010-11-15 13:57:56 +01:00
2014-08-23 12:21:21 -07:00
2010-05-11 18:33:37 +02:00
2014-09-10 12:40:10 -07:00
2016-07-22 17:05:10 +02:00
2016-09-23 09:30:36 +02:00
2016-11-08 23:53:36 +01:00
2010-05-11 18:31:17 +02:00
2016-08-12 00:43:13 +02:00
2011-01-18 06:33:54 +01:00
2018-03-24 11:00:14 +01:00
2010-05-11 18:35:27 +02:00
2011-02-03 00:05:43 +01:00
2010-05-11 18:33:37 +02:00
2014-11-13 12:14:42 +01:00
2011-12-27 20:45:25 +01:00
2010-05-11 18:35:27 +02:00
2018-04-08 12:12:50 +02:00
2016-09-24 21:29:53 +02:00
2011-07-01 16:11:15 -07:00
2011-07-01 16:11:15 -07:00
2014-08-23 12:21:21 -07:00
2018-11-27 16:09:39 +01:00
2016-10-17 17:38:19 +02:00
2011-02-04 14:28:58 -08:00
2015-09-24 09:34:41 +09:00
2014-01-09 21:36:39 +01:00
2018-03-18 11:18:53 +01:00
2010-05-11 18:33:37 +02:00
2013-04-18 20:27:55 +02:00
2015-09-18 21:58:25 +02:00
2012-05-09 20:49:18 -04:00
2015-05-14 13:00:27 +02:00
2010-05-11 18:35:27 +02:00
2012-10-15 13:39:12 +02:00
2012-09-21 12:11:08 +02:00
2016-08-18 00:38:23 +02:00
2016-10-17 17:38:19 +02:00
2013-12-07 23:20:45 +01:00
2018-01-31 12:55:52 +01:00
2016-06-23 13:58:55 +02:00
2019-04-05 22:29:14 +02:00
2010-05-11 18:33:37 +02:00
2010-05-11 18:33:37 +02:00
2011-10-31 19:30:28 -04:00
2013-06-11 02:51:03 -07:00
2018-02-25 11:05:43 +01:00
2010-05-11 18:33:37 +02:00
2018-04-08 12:12:50 +02:00
2014-11-27 13:08:42 +01:00
2014-06-07 11:44:39 -07:00
2016-09-22 03:13:26 -04:00
2010-10-21 10:12:48 +11:00
2015-06-14 10:40:18 +02:00
2016-04-04 22:11:20 -04:00
2010-06-08 16:09:52 +02:00
2014-01-14 15:15:25 -08:00
2015-02-22 15:59:54 -05:00
2010-05-11 18:35:27 +02:00
2017-07-05 14:40:16 +02:00
2015-08-17 21:33:06 -07:00
2016-07-03 10:55:07 +02:00
2016-09-12 19:54:43 +02:00
2012-09-24 14:29:01 +02:00
2016-08-18 00:51:13 +02:00
2016-06-23 13:26:49 +02:00
2010-05-11 18:33:37 +02:00