Arnaldo Carvalho de Melo a6dd4862b9 perf annotate TUI browser: Do not use member from variable within its own initialization ...

[ Upstream commit da2019633f ]

Some compilers will complain when using a member of a struct to
initialize another member, in the same struct initialization.

For instance:

  debian:8      Debian clang version 3.5.0-10 (tags/RELEASE_350/final) (based on LLVM 3.5.0)
  oraclelinux:7 clang version 3.4.2 (tags/RELEASE_34/dot2-final)

Produce:

  ui/browsers/annotate.c:104:12: error: variable 'ops' is uninitialized when used within its own initialization [-Werror,-Wuninitialized]
                                              (!ops.current_entry ||
                                                ^~~
  1 error generated.

So use an extra variable, initialized just before that struct, to have
the value used in the expressions used to init two of the struct
members.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Fixes: c298304bd7 ("perf annotate: Use a ops table for annotation_line__write()")
Link: https://lkml.kernel.org/n/tip-f9nexro58q62l3o9hez8hr0i@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2019-07-26 09:14:02 +02:00

..

accounting

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

arch

jump_label: move 'asm goto' support test to Kconfig

2019-06-04 08:02:34 +02:00

bpf

bpftool: exclude bash-completion/bpftool from .gitignore pattern

2019-05-31 06:46:08 -07:00

build

perf build: Don't unconditionally link the libbfd feature test to -liberty and -lz

2019-02-12 19:47:16 +01:00

cgroup

tools: fix cross-compile var clobbering

2018-02-21 15:35:42 -08:00

firewire

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

gpio

Merge tag 'v4.16-rc5' into devel

2018-03-18 17:48:59 +01:00

hv

Tools: hv: kvp: Fix a warning of buffer overflow with gcc 8.0.1

2019-02-12 19:46:59 +01:00

iio

tools: iio: iio_generic_buffer: make num_loops signed

2019-02-15 08:10:10 +01:00

include

tools include: Adopt linux/bits.h

2019-04-27 09:36:40 +02:00

kvm/kvm_stat

tools/kvm_stat: fix fields filter for child events

2019-06-19 08:18:05 +02:00

laptop

tools: fix cross-compile var clobbering

2018-02-21 15:35:42 -08:00

leds

tools: fix cross-compile var clobbering

2018-02-21 15:35:42 -08:00

lib

libbpf: fix samples/bpf build failure due to undefined UINT32_MAX

2019-05-31 06:46:14 -07:00

memory-model

tools/memory-model: Rename litmus tests to comply to norm7

2018-07-17 09:30:36 +02:00

nfsd

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

objtool

objtool: Support per-function rodata sections

2019-06-25 11:35:52 +08:00

pci

tools: PCI: Add MSI-X support

2018-07-19 11:47:13 +01:00

pcmcia

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

perf

perf annotate TUI browser: Do not use member from variable within its own initialization

2019-07-26 09:14:02 +02:00

power

x86/msr-index: Cleanup bit defines

2019-05-14 19:17:53 +02:00

scripts

Kbuild: fix # escaping in .cmd files for future Make

2018-04-11 00:03:02 +09:00

spi

tools: fix cross-compile var clobbering

2018-02-21 15:35:42 -08:00

testing

selftests: fib_rule_tests: Fix icmp proto with ipv6

2019-07-10 09:53:45 +02:00

thermal/tmon

tools/thermal: tmon: fix for segfault

2018-03-27 09:51:23 +02:00

time

…

usb

usbip: fix vhci_hcd controller counting

2019-04-20 09:16:01 +02:00

virtio

virtio: fix test build after uio.h change

2019-01-13 09:51:03 +01:00

vm

tools/vm/page-types.c: fix "defined but not used" warning

2018-09-04 16:45:02 -07:00

wmi

tools: fix cross-compile var clobbering

2018-02-21 15:35:42 -08:00

Makefile

Merge tag 'platform-drivers-x86-v4.15-1' of git://git.infradead.org/linux-platform-drivers-x86

2017-11-18 10:26:57 -08:00