Kuniyuki Iwashima
de260d1e02
net: Fix load-tearing on sk->sk_stamp in sock_recv_cmsgs().
[ Upstream commit dfd9248c07 ]
KCSAN found a data race in sock_recv_cmsgs() where the read access
to sk->sk_stamp needs READ_ONCE().
BUG: KCSAN: data-race in packet_recvmsg / packet_recvmsg
write (marked) to 0xffff88803c81f258 of 8 bytes by task 19171 on cpu 0:
sock_write_timestamp include/net/sock.h:2670 [inline]
sock_recv_cmsgs include/net/sock.h:2722 [inline]
packet_recvmsg+0xb97/0xd00 net/packet/af_packet.c:3489
sock_recvmsg_nosec net/socket.c:1019 [inline]
sock_recvmsg+0x11a/0x130 net/socket.c:1040
sock_read_iter+0x176/0x220 net/socket.c:1118
call_read_iter include/linux/fs.h:1845 [inline]
new_sync_read fs/read_write.c:389 [inline]
vfs_read+0x5e0/0x630 fs/read_write.c:470
ksys_read+0x163/0x1a0 fs/read_write.c:613
__do_sys_read fs/read_write.c:623 [inline]
__se_sys_read fs/read_write.c:621 [inline]
__x64_sys_read+0x41/0x50 fs/read_write.c:621
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0x90 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x72/0xdc
read to 0xffff88803c81f258 of 8 bytes by task 19183 on cpu 1:
sock_recv_cmsgs include/net/sock.h:2721 [inline]
packet_recvmsg+0xb64/0xd00 net/packet/af_packet.c:3489
sock_recvmsg_nosec net/socket.c:1019 [inline]
sock_recvmsg+0x11a/0x130 net/socket.c:1040
sock_read_iter+0x176/0x220 net/socket.c:1118
call_read_iter include/linux/fs.h:1845 [inline]
new_sync_read fs/read_write.c:389 [inline]
vfs_read+0x5e0/0x630 fs/read_write.c:470
ksys_read+0x163/0x1a0 fs/read_write.c:613
__do_sys_read fs/read_write.c:623 [inline]
__se_sys_read fs/read_write.c:621 [inline]
__x64_sys_read+0x41/0x50 fs/read_write.c:621
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0x90 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x72/0xdc
value changed: 0xffffffffc4653600 -> 0x0000000000000000
Reported by Kernel Concurrency Sanitizer on:
CPU: 1 PID: 19183 Comm: syz-executor.5 Not tainted 6.3.0-rc7-02330-gca6270c12e20 #2
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014
Fixes: 6c7c98bad4 ("sock: avoid dirtying sk_stamp, if possible")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20230508175543.55756-1-kuniyu@amazon.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-05-24 17:36:41 +01:00
..
2022-08-17 14:24:07 +02:00
2022-08-03 12:03:40 +02:00
2021-07-01 13:19:48 -07:00
2021-01-28 20:36:21 -08:00
2023-05-11 23:00:40 +09:00
2022-07-29 17:25:11 +02:00
2021-11-25 09:48:40 +01:00
2019-06-05 17:37:07 +02:00
2023-03-11 13:57:28 +01:00
2023-03-11 13:57:29 +01:00
2020-02-28 14:51:30 +01:00
2021-08-02 10:24:38 +01:00
2022-08-03 12:03:47 +02:00
2019-05-30 11:26:41 -07:00
2021-04-23 10:17:26 +01:00
2021-08-16 18:43:39 -07:00
2022-03-23 09:16:41 +01:00
2017-11-02 11:10:55 +01:00
2022-04-13 20:59:05 +02:00
2017-11-02 11:10:55 +01:00
2022-04-20 09:34:22 +02:00
2021-08-03 13:05:25 +01:00
2020-07-21 18:30:47 -07:00
2022-09-28 11:11:48 +02:00
2021-12-14 10:57:09 +01:00
2021-08-03 11:50:22 +01:00
2022-09-28 11:11:48 +02:00
2021-03-26 17:43:55 +01:00
2022-08-31 17:16:43 +02:00
2019-05-21 11:28:45 +02:00
2019-06-19 17:09:55 +02:00
2021-10-25 15:20:22 +02:00
2020-02-29 14:39:08 +01:00
2022-03-02 11:47:58 +01:00
2020-07-15 07:45:24 -07:00
2020-03-27 19:40:38 -07:00
2016-04-25 16:44:27 -04:00
2016-06-25 12:19:35 -04:00
2016-04-25 16:44:27 -04:00
2021-08-05 11:46:42 +01:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:29:52 -07:00
2019-05-30 11:29:52 -07:00
2021-08-14 13:59:10 +01:00
2017-11-02 11:10:55 +01:00
2021-07-30 15:33:24 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 11:52:39 +02:00
2019-05-21 11:52:39 +02:00
2017-11-04 09:26:51 +09:00
2022-03-16 14:23:47 +01:00
2019-12-16 16:09:44 -08:00
2021-12-08 09:04:46 +01:00
2022-02-16 12:56:30 +01:00
2020-05-08 21:33:33 -07:00
2022-12-31 13:14:42 +01:00
2020-05-05 13:23:29 -07:00
2022-04-27 14:38:52 +02:00
2020-04-20 07:34:16 +02:00
2019-06-19 17:09:55 +02:00
2018-05-28 22:59:54 -04:00
2019-12-24 22:37:30 -08:00
2021-12-08 09:04:43 +01:00
2017-11-02 11:10:55 +01:00
2022-04-20 09:34:09 +02:00
2022-06-14 18:36:17 +02:00
2021-09-02 11:44:19 +01:00
2017-11-02 11:10:55 +01:00
2021-01-21 13:33:45 +01:00
2021-01-21 13:33:45 +01:00
2019-12-09 10:36:44 -08:00
2019-11-05 18:20:55 -08:00
2021-02-12 16:31:46 -08:00
2019-03-22 12:09:31 -07:00
2021-01-29 20:39:14 -08:00
2017-11-02 11:10:55 +01:00
2021-03-18 19:51:12 -07:00
2017-11-02 11:10:55 +01:00
2020-06-22 21:12:44 -07:00
2019-10-25 16:24:32 -07:00
2021-06-28 14:29:45 -07:00
2021-08-13 09:58:25 +02:00
2022-10-26 12:35:54 +02:00
2022-06-09 10:22:31 +02:00
2019-04-22 21:50:53 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2022-08-17 14:23:36 +02:00
2021-01-27 18:18:15 -08:00
2022-08-03 12:03:45 +02:00
2020-12-14 18:38:58 -08:00
2022-01-27 11:05:35 +01:00
2022-08-17 14:23:36 +02:00
2022-08-17 14:23:36 +02:00
2019-09-27 12:05:02 +02:00
2019-02-08 21:50:15 -08:00
2021-07-21 08:14:33 -07:00
2020-06-20 17:47:53 -07:00
2022-02-23 12:03:10 +01:00
2021-08-05 15:08:47 -07:00
2022-05-09 09:14:36 +02:00
2021-12-08 09:04:49 +01:00
2022-05-09 09:14:36 +02:00
2021-02-04 18:37:57 -08:00
2022-11-26 09:24:49 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2022-01-27 11:05:35 +01:00
2021-12-01 09:04:49 +01:00
2023-04-26 13:51:54 +02:00
2018-03-27 09:51:23 +02:00
2019-06-19 17:09:55 +02:00
2020-06-20 17:22:22 -07:00
2018-07-11 23:10:19 -07:00
2021-03-23 14:14:50 -07:00
2017-11-02 11:10:55 +01:00
2017-10-25 12:06:25 +09:00
2019-10-08 13:23:05 -07:00
2021-07-27 13:05:56 +01:00
2021-11-18 19:17:10 +01:00
2021-08-30 01:51:36 +02:00
2021-09-27 12:02:54 +02:00
2019-05-30 11:26:41 -07:00
2021-06-24 12:41:12 -07:00
2021-10-18 13:47:09 +01:00
2021-08-25 11:23:14 +01:00
2020-03-02 11:16:27 -08:00
2021-03-26 15:14:56 -07:00
2020-02-28 12:08:37 -08:00
2020-05-29 21:20:20 -07:00
2023-01-12 11:58:52 +01:00
2022-12-31 13:14:42 +01:00
2017-11-02 11:10:55 +01:00
2022-03-08 19:12:33 +01:00
2021-11-18 19:17:16 +01:00
2018-05-28 22:59:54 -04:00
2022-04-13 20:59:03 +02:00
2017-11-02 11:10:55 +01:00
2018-08-01 09:52:30 -07:00
2019-05-21 11:28:45 +02:00
2021-07-27 11:43:50 +01:00
2019-11-12 08:18:03 -08:00
2019-04-11 13:59:49 -07:00
2021-09-24 14:07:10 +01:00
2021-12-01 09:04:46 +01:00
2017-11-08 16:12:33 +09:00
2017-11-02 11:10:55 +01:00
2021-08-09 15:49:00 -07:00
2020-03-04 13:25:55 -08:00
2019-05-30 11:26:32 -07:00
2021-08-30 16:33:59 -07:00
2022-01-27 11:04:02 +01:00
2017-11-02 11:10:55 +01:00
2022-11-10 18:15:38 +01:00
2021-08-09 15:34:21 -07:00
2017-11-02 11:10:55 +01:00
2022-07-21 21:24:27 +02:00
2017-11-02 11:10:55 +01:00
2021-03-25 17:40:43 -07:00
2020-07-31 09:24:23 +02:00
2020-08-24 14:35:00 -07:00
2018-05-16 07:23:35 +02:00
2022-07-29 17:25:09 +02:00
2020-06-23 20:27:09 -07:00
2018-03-13 18:37:02 +02:00
2021-08-04 10:01:26 +01:00
2019-04-22 21:47:25 -07:00
2023-02-01 08:27:09 +01:00
2023-05-11 23:00:26 +09:00
2022-05-18 10:26:53 +02:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2022-01-27 11:05:05 +01:00
2021-04-28 14:06:45 -07:00
2018-04-11 10:33:46 -04:00
2020-09-28 15:19:03 -07:00
2019-10-05 16:29:00 -07:00
2022-12-31 13:14:07 +01:00
2023-05-24 17:36:41 +01:00
2021-08-03 13:05:26 +01:00
2017-11-02 11:10:55 +01:00
2021-11-18 19:17:11 +01:00
2021-08-04 12:35:07 +01:00
2019-05-30 11:26:32 -07:00
2022-12-31 13:14:14 +01:00
2019-05-30 11:26:32 -07:00
2018-05-08 00:02:41 -04:00
2019-10-04 14:07:07 -07:00
2022-07-21 21:24:31 +02:00
2020-06-23 20:10:15 -07:00
2020-06-18 20:46:23 -07:00
2017-08-29 15:16:52 -07:00
2022-09-15 11:30:05 +02:00
2023-04-26 13:51:54 +02:00
2023-04-26 13:51:54 +02:00
2019-11-14 18:12:17 -08:00
2020-09-14 16:49:39 -07:00
2018-01-24 19:13:45 -05:00
2019-12-09 10:28:43 -08:00
2017-11-02 11:10:55 +01:00
2019-11-16 12:39:10 -08:00
2022-06-14 18:36:18 +02:00
2021-06-24 19:41:15 +02:00
2021-07-07 19:51:12 -07:00
2022-09-23 14:15:51 +02:00
2023-05-11 23:00:27 +09:00