shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-03-26 04:20:23 +09:00
Code Issues Packages Projects Releases Wiki Activity
Files
a248d08a94de5605ed8cd5cbf3ac5457563936a8
linux/drivers/md
History
Jiazi Li 06bb3003c6 BACKPORT: dm: fix NULL pointer issue when free bio 
dm_io_dec_pending call end_io_acct first, will dec md in-flight
pending count. If a task is swapping table at same time.
task1                             task2
do_resume
 ->do_suspend
  ->dm_wait_for_completion
                                  bio_endio
				   ->clone_endio
				    ->dm_io_dec_pending
				     ->end_io_acct
				      ->wakeup task1
 ->dm_swap_table
  ->__bind
   ->__bind_mempools
    ->bioset_exit
     ->mempool_exit
                                     ->free_io
mempool->elements is NULL, and lead to following crash:
[ 67.330330] Unable to handle kernel NULL pointer dereference at virtual
address 0000000000000000
......
[ 67.330494] pstate: 80400085 (Nzcv daIf +PAN -UAO)
[ 67.330510] pc : mempool_free+0x70/0xa0
[ 67.330515] lr : mempool_free+0x4c/0xa0
[ 67.330520] sp : ffffff8008013b20
[ 67.330524] x29: ffffff8008013b20 x28: 0000000000000004
[ 67.330530] x27: ffffffa8c2ff40a0 x26: 00000000ffff1cc8
[ 67.330535] x25: 0000000000000000 x24: ffffffdada34c800
[ 67.330541] x23: 0000000000000000 x22: ffffffdada34c800
[ 67.330547] x21: 00000000ffff1cc8 x20: ffffffd9a1304d80
[ 67.330552] x19: ffffffdada34c970 x18: 000000b312625d9c
[ 67.330558] x17: 00000000002dcfbf x16: 00000000000006dd
[ 67.330563] x15: 000000000093b41e x14: 0000000000000010
[ 67.330569] x13: 0000000000007f7a x12: 0000000034155555
[ 67.330574] x11: 0000000000000001 x10: 0000000000000001
[ 67.330579] x9 : 0000000000000000 x8 : 0000000000000000
[ 67.330585] x7 : 0000000000000000 x6 : ffffff80148b5c1a
[ 67.330590] x5 : ffffff8008013ae0 x4 : 0000000000000001
[ 67.330596] x3 : ffffff80080139c8 x2 : ffffff801083bab8
[ 67.330601] x1 : 0000000000000000 x0 : ffffffdada34c970
[ 67.330609] Call trace:
[ 67.330616] mempool_free+0x70/0xa0
[ 67.330627] bio_put+0xf8/0x110
[ 67.330638] dec_pending+0x13c/0x230
[ 67.330644] clone_endio+0x90/0x180
[ 67.330649] bio_endio+0x198/0x1b8
[ 67.330655] dec_pending+0x190/0x230
[ 67.330660] clone_endio+0x90/0x180
[ 67.330665] bio_endio+0x198/0x1b8
[ 67.330673] blk_update_request+0x214/0x428
[ 67.330683] scsi_end_request+0x2c/0x300
[ 67.330688] scsi_io_completion+0xa0/0x710
[ 67.330695] scsi_finish_command+0xd8/0x110
[ 67.330700] scsi_softirq_done+0x114/0x148
[ 67.330708] blk_done_softirq+0x74/0xd0
[ 67.330716] __do_softirq+0x18c/0x374
[ 67.330724] irq_exit+0xb4/0xb8
[ 67.330732] __handle_domain_irq+0x84/0xc0
[ 67.330737] gic_handle_irq+0x148/0x1b0
[ 67.330744] el1_irq+0xe8/0x190
[ 67.330753] lpm_cpuidle_enter+0x4f8/0x538
[ 67.330759] cpuidle_enter_state+0x1fc/0x398
[ 67.330764] cpuidle_enter+0x18/0x20
[ 67.330772] do_idle+0x1b4/0x290
[ 67.330778] cpu_startup_entry+0x20/0x28
[ 67.330786] secondary_start_kernel+0x160/0x170

Move end_io_acct after free_io to fix this issue.

Bug: 228982905
Link: https://lore.kernel.org/dm-devel/1632916768-22379-1-git-send-email-lijiazi@xiaomi.com/T/#u
[Akilesh: Resolved merge conflict in drivers/md/dm.c]
Signed-off-by: Jiazi Li <lijiazi@xiaomi.com>
Signed-off-by: Akilesh Kailash <akailash@google.com>
(cherry picked from commit d208b89401)
Change-Id: I9f122cab2af3b961c472b8cf2087399c63c28de1
2022-04-27 22:38:31 +00:00
..
bcache
bcache: add proper error unwinding in bcache_device_init
2021-09-15 09:50:25 +02:00
persistent-data
dm space map common: add bounds check to sm_ll_lookup_bitmap()
2022-01-27 10:54:20 +01:00
dm-bio-prison-v1.c
dm bio prison: replace spin_lock_irqsave with spin_lock_irq
2019-11-05 14:53:03 -05:00
dm-bio-prison-v1.h
block: switch bios to blk_status_t
2017-06-09 09:27:32 -06:00
dm-bio-prison-v2.c
dm bio prison v2: use true/false for bool variable
2020-01-07 12:07:08 -05:00
dm-bio-prison-v2.h
dm bio prison v2: new interface for the bio prison
2017-03-07 11:30:16 -05:00
dm-bio-record.h
dm bio record: save/restore bi_end_io and bi_integrity
2020-03-03 10:02:46 -05:00
dm-bow.c
ANDROID: dm-bow: Protect Ranges fetched and erased from the RB tree
2022-04-27 16:07:42 +00:00
dm-bufio.c
dm bufio: subtract the number of initial sectors in dm_bufio_get_device_size
2021-03-09 11:11:12 +01:00
dm-builtin.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
dm-cache-background-tracker.c
dm cache background tracker: fix sparse warning
2018-04-30 15:40:40 -04:00
dm-cache-background-tracker.h
dm cache: significant rework to leverage dm-bio-prison-v2
2017-03-07 13:28:31 -05:00
dm-cache-block-types.h
linux: drop __bitwise__ everywhere
2016-12-16 00:13:41 +02:00
dm-cache-metadata.c
dm cache metadata: Avoid returning cmd->bm wild pointer on error
2020-09-02 13:38:24 -04:00
dm-cache-metadata.h
dm cache: significant rework to leverage dm-bio-prison-v2
2017-03-07 13:28:31 -05:00
dm-cache-policy-internal.h
dm cache: significant rework to leverage dm-bio-prison-v2
2017-03-07 13:28:31 -05:00
dm-cache-policy-smq.c
dm: remove unnecessary unlikely() around WARN_ON_ONCE()
2018-10-16 14:34:59 -04:00
dm-cache-policy.c
…
dm-cache-policy.h
dm cache: significant rework to leverage dm-bio-prison-v2
2017-03-07 13:28:31 -05:00
dm-cache-target.c
Revert "dm cache: fix arm link errors with inline"
2020-12-01 15:43:36 -05:00
dm-clone-metadata.c
dm clone metadata: Fix return type of dm_clone_nr_of_hydrated_regions()
2020-03-27 14:42:51 -04:00
dm-clone-metadata.h
dm clone metadata: Fix return type of dm_clone_nr_of_hydrated_regions()
2020-03-27 14:42:51 -04:00
dm-clone-target.c
writeback: remove bdi->congested_fn
2020-07-08 17:20:46 -06:00
dm-core.h
Merge 5.10.20 into android12-5.10
2021-03-07 12:33:33 +01:00
dm-crypt.c
dm crypt: Avoid percpu_counter spinlock contention in crypt_page_alloc()
2021-09-18 13:40:08 +02:00
dm-default-key.c
ANDROID: dm: sync inline crypto support with patches going upstream
2021-02-19 10:48:51 +00:00
dm-delay.c
block: rename generic_make_request to submit_bio_noacct
2020-07-01 07:27:24 -06:00
dm-dust.c
dm dust: add interface to list all badblocks
2020-07-20 11:17:41 -04:00
dm-ebs-target.c
dm ebs: Fix incorrect checking for REQ_OP_FLUSH
2020-08-04 16:01:40 -04:00
dm-era-target.c
dm era: only resize metadata in preresume
2021-03-04 11:38:46 +01:00
dm-exception-store.c
Merge tag 'dm-4.4-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm
2015-11-04 21:19:53 -08:00
dm-exception-store.h
Merge tag 'for-5.2/dm-changes-v2' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm
2019-05-16 15:55:48 -07:00
dm-flakey.c
ANDROID: dm: sync inline crypto support with patches going upstream
2021-02-19 10:48:51 +00:00
dm-historical-service-time.c
dm mpath: add Historical Service Time Path Selector
2020-05-15 10:29:36 -04:00
dm-init.c
dm init: Set file local variable static
2020-08-04 15:51:28 -04:00
dm-integrity.c
dm integrity: fix missing goto in bitmap_flush_interval error handling
2021-05-11 14:47:40 +02:00
dm-io.c
block: Add bio_max_segs
2021-09-28 10:28:00 -07:00
dm-ioctl.c
dm ioctl: fix out of bounds array access when no devices
2021-03-30 14:31:56 +02:00
dm-kcopyd.c
dm kcopyd: always complete failed jobs
2019-08-15 15:57:39 -04:00
dm-linear.c
ANDROID: dm: sync inline crypto support with patches going upstream
2021-02-19 10:48:51 +00:00
dm-log-userspace-base.c
dm: convert to bioset_init()/mempool_init()
2018-05-30 15:33:32 -06:00
dm-log-userspace-transfer.c
dm log userspace transfer: match wait_for_completion_timeout return type
2015-04-15 12:10:20 -04:00
dm-log-userspace-transfer.h
…
dm-log-writes.c
block: Add bio_max_segs
2021-09-28 10:28:00 -07:00
dm-log.c
block,fs: use REQ_* flags directly
2016-11-01 09:43:26 -06:00
dm-mpath.c
dm: use dm_table_get_device_name() where appropriate in targets
2020-09-29 16:33:08 -04:00
dm-mpath.h
…
dm-path-selector.c
…
dm-path-selector.h
dm mpath: pass IO start time to path selector
2020-05-15 10:29:36 -04:00
dm-queue-length.c
dm mpath: pass IO start time to path selector
2020-05-15 10:29:36 -04:00
dm-raid1.c
block: rename generic_make_request to submit_bio_noacct
2020-07-01 07:27:24 -06:00
dm-raid.c
dm raid: fix inconclusive reshape layout on fast raid4/5/6 table reload sequences
2021-05-11 14:47:36 +02:00
dm-region-hash.c
Merge tag 'overflow-v4.18-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2018-06-12 18:28:00 -07:00
dm-round-robin.c
dm round robin: revert "use percpu 'repeat_count' and 'current_path'"
2017-02-17 00:54:09 -05:00
dm-rq.c
dm rq: fix double free of blk_mq_tag_set in dev remove after table load fails
2021-05-11 14:47:40 +02:00
dm-rq.h
dm: remove unused _rq_tio_cache and _rq_cache
2019-03-05 14:48:50 -05:00
dm-service-time.c
dm mpath: pass IO start time to path selector
2020-05-15 10:29:36 -04:00
dm-snap-persistent.c
dm snap persistent: simplify area_io()
2020-09-29 16:33:12 -04:00
dm-snap-transient.c
dm snapshot: fix hung bios when copy error occurs
2016-01-08 20:03:05 -05:00
dm-snap.c
dm snapshot: properly fix a crash when an origin has no snapshots
2021-06-03 09:00:30 +02:00
dm-stats.c
dm: replace zero-length array with flexible-array
2020-05-20 17:09:44 -04:00
dm-stats.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
dm-stripe.c
dm: replace zero-length array with flexible-array
2020-05-20 17:09:44 -04:00
dm-switch.c
dm: replace zero-length array with flexible-array
2020-05-20 17:09:44 -04:00
dm-sysfs.c
dm: remove legacy request-based IO path
2018-10-11 11:36:09 -04:00
dm-table.c
Merge 5.10.27 into android12-5.10
2021-04-02 15:25:50 +02:00
dm-target.c
dm mpath: fix missing call of path selector type->end_io
2019-04-25 15:38:52 -04:00
dm-thin-metadata.c
dm thin metadata: Remove unused local variable when create thin and snap
2020-09-29 16:33:11 -04:00
dm-thin-metadata.h
dm thin metadata: Add support for a pre-commit callback
2019-12-05 17:05:24 -05:00
dm-thin.c
writeback: remove bdi->congested_fn
2020-07-08 17:20:46 -06:00
dm-uevent.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
dm-uevent.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
dm-unstripe.c
dm: Check for device sector overflow if CONFIG_LBDAF is not set
2018-12-18 09:02:26 -05:00
dm-user.c
ANDROID: dm-user: Fix build warnings
2021-05-26 22:37:59 +00:00
dm-verity-fec.c
dm verity fec: fix misaligned RS roots IO
2021-04-21 13:00:54 +02:00
dm-verity-fec.h
dm verity fec: fix misaligned RS roots IO
2021-04-21 13:00:54 +02:00
dm-verity-target.c
FROMLIST: dm-verity: skip verity_handle_error on I/O errors
2021-10-07 20:12:15 +00:00
dm-verity-verify-sig.c
dm verity: fix require_signatures module_param permissions
2021-06-16 12:01:37 +02:00
dm-verity-verify-sig.h
dm verity: Fix compilation warning
2020-08-04 15:48:13 -04:00
dm-verity.h
Revert "ANDROID: AVB error handler to invalidate vbmeta partition."
2021-06-16 17:49:01 +00:00
dm-writecache.c
dm writecache: write at least 4k when committing
2021-07-19 09:45:02 +02:00
dm-zero.c
dm: don't return errnos from ->map
2017-06-09 09:27:32 -06:00
dm-zoned-metadata.c
dm zoned: check zone capacity
2021-07-19 09:45:01 +02:00
dm-zoned-reclaim.c
dm zoned: Fix zone reclaim trigger
2020-07-08 12:21:53 -04:00
dm-zoned-target.c
dm table: Fix zoned model check and zone sectors check
2021-03-30 14:32:06 +02:00
dm-zoned.h
dm zoned: select reclaim zone based on device index
2020-06-05 14:59:53 -04:00
dm.c
BACKPORT: dm: fix NULL pointer issue when free bio
2022-04-27 22:38:31 +00:00
dm.h
dm table: fix DAX iterate_devices based device capability checks
2021-03-04 11:38:44 +01:00
Kconfig
Revert "ANDROID: AVB error handler to invalidate vbmeta partition."
2021-06-16 17:49:01 +00:00
Makefile
Revert "ANDROID: AVB error handler to invalidate vbmeta partition."
2021-06-16 17:49:01 +00:00
md-autodetect.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
md-bitmap.c
md/bitmap: wait for external bitmap writes to complete during tear down
2021-05-14 09:49:59 +02:00
md-bitmap.h
md: Avoid namespace collision with bitmap API
2018-08-01 15:49:39 -07:00
md-cluster.c
md/cluster: fix deadlock when node is doing resync job
2020-12-30 11:54:25 +01:00
md-cluster.h
md-cluster: introduce resync_info_get interface for sanity check
2018-10-18 09:36:35 -07:00
md-faulty.c
block: rename generic_make_request to submit_bio_noacct
2020-07-01 07:27:24 -06:00
md-linear.c
block: add a new revalidate_disk_size helper
2020-09-02 08:00:07 -06:00
md-linear.h
md/raid1: Replace zero-length array with flexible-array
2020-05-13 12:02:23 -07:00
md-multipath.c
writeback: remove bdi->congested_fn
2020-07-08 17:20:46 -06:00
md-multipath.h
md: convert to bioset_init()/mempool_init()
2018-05-30 15:33:32 -06:00
md.c
md: revert io stats accounting
2022-01-16 09:14:21 +01:00
md.h
md: revert io stats accounting
2022-01-16 09:14:21 +01:00
raid0.c
Revert "md: add md_submit_discard_bio() for submitting discard bio"
2020-12-09 20:46:01 -08:00
raid0.h
md/raid0: avoid RAID0 data corruption due to layout confusion.
2019-09-13 13:10:05 -07:00
raid1-10.c
md: raid1-10: Unify r{1,10}bio_pool_free
2019-06-15 01:37:35 -06:00
raid1.c
md/raid10: properly indicate failure when ending a failed write request
2021-08-12 13:22:17 +02:00
raid1.h
md/raid1: Replace zero-length array with flexible-array
2020-05-13 12:02:23 -07:00
raid5-cache.c
raid5-cache: hold spinlock instead of mutex in r5c_journal_mode_show
2020-08-02 23:03:52 -07:00
raid5-log.h
raid5: set write hint for PPL
2019-03-12 10:15:18 -07:00
raid5-ppl.c
md/raid456: convert macro STRIPE_* to RAID5_STRIPE_*
2020-07-21 17:18:12 -07:00
raid5.c
treewide: Change list_sort to use const pointers
2021-09-30 10:11:04 +02:00
raid5.h
md/raid5: let multiple devices of stripe_head share page
2020-09-24 16:44:44 -07:00
raid10.c
md/raid10: properly indicate failure when ending a failed write request
2021-08-12 13:22:17 +02:00
raid10.h
Revert "md/raid10: improve discard request for far layout"
2020-12-09 20:46:00 -08:00