Files
linux/include/linux
Daniel Borkmann aa7145c16d bpf, events: fix offset in skb copy handler
This patch fixes the __output_custom() routine we currently use with
bpf_skb_copy(). I missed that when len is larger than the size of the
current handle, we can issue multiple invocations of copy_func, and
__output_custom() advances destination but also source buffer by the
written amount of bytes. When we have __output_custom(), this is actually
wrong since in that case the source buffer points to a non-linear object,
in our case an skb, which the copy_func helper is supposed to walk.
Therefore, since this is non-linear we thus need to pass the offset into
the helper, so that copy_func can use it for extracting the data from
the source object.

Therefore, adjust the callback signatures properly and pass offset
into the skb_header_pointer() invoked from bpf_skb_copy() callback. The
__DEFINE_OUTPUT_COPY_BODY() is adjusted to accommodate for two things:
i) to pass in whether we should advance source buffer or not; this is
a compile-time constant condition, ii) to pass in the offset for
__output_custom(), which we do with help of __VA_ARGS__, so everything
can stay inlined as is currently. Both changes allow for adapting the
__output_* fast-path helpers w/o extra overhead.

Fixes: 555c8a8623 ("bpf: avoid stack copy and use skb ctx for event output")
Fixes: 7e3f977edd ("perf, events: add non-linear data support for raw records")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2016-07-25 10:34:11 -07:00
..
2015-10-07 18:08:15 +01:00
2016-03-04 23:50:27 -06:00
2015-05-13 12:04:55 -05:00
2015-12-23 08:37:10 -07:00
2015-03-25 20:28:11 -04:00
2016-03-15 16:55:16 -07:00
2016-06-07 22:07:09 -04:00
2016-07-01 16:30:38 -04:00
2016-06-01 14:56:57 -07:00
2015-02-12 18:54:15 -08:00
2016-05-31 22:12:43 +05:30
2015-01-21 19:21:30 +01:00
2016-05-17 15:48:12 -04:00
2014-12-31 13:06:50 -05:00
2015-06-24 17:49:45 -07:00
2015-12-28 13:41:50 +01:00
2015-03-16 21:45:54 +11:00
2015-05-05 13:40:42 -06:00
2015-11-25 09:22:00 -07:00
2016-03-11 14:58:58 -05:00
2015-10-23 05:44:28 -07:00
2016-02-11 09:59:22 -05:00
2016-03-22 15:36:02 -07:00
2016-05-11 22:37:54 +02:00
2015-06-25 12:06:45 +02:00
2016-01-28 14:19:12 -08:00
2016-03-22 15:36:02 -07:00
2016-03-22 15:36:02 -07:00
2015-07-28 08:50:42 +01:00
2016-01-15 17:56:32 -08:00
2015-04-29 17:17:17 -05:00
2016-03-09 15:43:42 -08:00
2016-05-03 15:07:35 -07:00
2016-01-15 17:56:32 -08:00
2016-05-19 19:12:14 -07:00
2015-10-27 18:55:31 -07:00
2016-05-26 15:35:44 -07:00
2015-06-24 17:49:41 -07:00
2015-10-20 22:10:45 +08:00
2015-07-21 10:39:05 -07:00
2016-07-01 05:32:17 -04:00
2016-06-03 19:37:21 -04:00
2016-05-17 15:48:12 -04:00
2016-05-17 15:47:55 -04:00
2016-05-23 17:04:14 -07:00
2016-04-25 15:09:11 -04:00
2016-02-16 13:04:58 -05:00
2016-05-02 09:00:56 -05:00
2016-05-23 17:04:14 -07:00
2016-05-19 19:12:14 -07:00
2015-04-12 21:03:31 +02:00
2016-02-11 18:35:48 -08:00
2016-02-11 18:35:48 -08:00
2016-03-14 15:43:11 -04:00
2015-01-25 23:17:28 -05:00
2015-10-06 17:08:19 +02:00
2016-02-16 13:04:58 -05:00
2015-10-22 08:59:18 -07:00
2016-06-23 18:37:05 +02:00
2016-03-17 15:09:34 -07:00
2016-07-06 10:51:14 +01:00
2016-03-22 15:36:02 -07:00
2016-03-22 15:36:02 -07:00
2016-03-22 15:36:02 -07:00
2016-05-26 00:04:58 -04:00
2016-01-04 16:11:11 -05:00
2016-05-19 19:12:14 -07:00
2016-05-19 19:12:14 -07:00
2016-05-08 23:46:14 -04:00
2016-05-20 17:58:30 -07:00
2015-06-25 17:00:39 -07:00
2016-05-19 19:12:14 -07:00
2015-10-01 09:57:59 -07:00
2015-10-19 01:01:21 +02:00
2016-05-23 17:04:14 -07:00
2016-04-07 16:53:29 -04:00
2015-11-23 09:44:58 +01:00
2016-05-20 17:58:30 -07:00
2016-02-22 16:10:08 -07:00
2015-12-03 07:24:29 -08:00
2015-03-24 09:48:14 -07:00
2015-09-08 15:35:28 -07:00