Files
linux/drivers/block
Mike Christie e83a26a493 nbd: fix shutdown and recv work deadlock v2
commit 1c05839aa9 upstream.

This fixes a regression added with:

commit e9e006f5fc
Author: Mike Christie <mchristi@redhat.com>
Date:   Sun Aug 4 14:10:06 2019 -0500

    nbd: fix max number of supported devs

where we can deadlock during device shutdown. The problem occurs if
the recv_work's nbd_config_put occurs after nbd_start_device_ioctl has
returned and the userspace app has droppped its reference via closing
the device and running nbd_release. The recv_work nbd_config_put call
would then drop the refcount to zero and try to destroy the config which
would try to do destroy_workqueue from the recv work.

This patch just has nbd_start_device_ioctl do a flush_workqueue when it
wakes so we know after the ioctl returns running works have exited. This
also fixes a possible race where we could try to reuse the device while
old recv_works are still running.

Cc: stable@vger.kernel.org
Fixes: e9e006f5fc ("nbd: fix max number of supported devs")
Signed-off-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-12-31 16:36:36 +01:00
..
2019-09-06 10:21:57 +02:00
2019-09-21 07:17:14 +02:00
2018-05-11 15:08:03 -06:00
2018-06-12 16:19:22 -07:00
2017-02-20 12:16:15 +01:00
2019-12-01 09:16:20 +01:00
2017-08-18 08:45:29 -06:00
2009-03-26 21:15:27 +01:00
2018-11-13 11:08:20 -08:00
2018-06-12 16:19:22 -07:00