Eric Dumazet
0c72742566
llc: fix out-of-bound array index in llc_sk_dev_hash()
...
[ Upstream commit 8ac9dfd58b ]
Both ifindex and LLC_SK_DEV_HASH_ENTRIES are signed.
This means that (ifindex % LLC_SK_DEV_HASH_ENTRIES) is negative
if @ifindex is negative.
We could simply make LLC_SK_DEV_HASH_ENTRIES unsigned.
In this patch I chose to use hash_32() to get more entropy
from @ifindex, like llc_sk_laddr_hashfn().
UBSAN: array-index-out-of-bounds in ./include/net/llc.h:75:26
index -43 is out of range for type 'hlist_head [64]'
CPU: 1 PID: 20999 Comm: syz-executor.3 Not tainted 5.15.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
ubsan_epilogue+0xb/0x5a lib/ubsan.c:151
__ubsan_handle_out_of_bounds.cold+0x62/0x6c lib/ubsan.c:291
llc_sk_dev_hash include/net/llc.h:75 [inline]
llc_sap_add_socket+0x49c/0x520 net/llc/llc_conn.c:697
llc_ui_bind+0x680/0xd70 net/llc/af_llc.c:404
__sys_bind+0x1e9/0x250 net/socket.c:1693
__do_sys_bind net/socket.c:1704 [inline]
__se_sys_bind net/socket.c:1702 [inline]
__x64_sys_bind+0x6f/0xb0 net/socket.c:1702
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7fa503407ae9
Fixes: 6d2e3ea284 ("llc: use a device based hash table to speed up multicast delivery")
Signed-off-by: Eric Dumazet <edumazet@google.com >
Reported-by: syzbot <syzkaller@googlegroups.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
Signed-off-by: Sasha Levin <sashal@kernel.org >
2021-11-26 11:36:16 +01:00
..
2019-07-03 13:14:42 +02:00
2021-08-12 13:19:40 +02:00
2021-06-10 13:24:06 +02:00
2018-06-28 10:40:47 -07:00
2020-10-29 09:55:15 +01:00
2021-04-14 08:22:34 +02:00
2021-06-03 08:38:02 +02:00
2019-03-23 20:09:51 +01:00
2021-07-31 08:22:38 +02:00
2019-05-04 09:20:18 +02:00
2017-04-12 22:02:36 +02:00
2020-06-03 08:19:15 +02:00
2020-08-11 15:32:34 +02:00
2018-07-13 12:18:18 -04:00
2018-08-03 12:46:20 -07:00
2021-07-31 08:22:37 +02:00
2018-08-07 12:39:13 -07:00
2017-11-02 11:10:55 +01:00
2019-06-11 12:20:57 +02:00
2017-11-02 11:10:55 +01:00
2019-02-23 09:07:27 +01:00
2018-04-19 16:11:11 -04:00
2018-08-04 13:23:15 -07:00
2014-11-10 13:27:49 -05:00
2017-05-27 18:51:41 -04:00
2020-12-08 10:18:53 +01:00
2021-07-31 08:22:38 +02:00
2017-07-04 22:35:16 +01:00
2011-08-08 14:26:29 -04:00
2021-06-03 08:38:03 +02:00
2016-07-08 12:20:57 +02:00
2017-01-20 12:12:13 -05:00
2017-07-04 01:29:04 -07:00
2016-04-19 20:09:25 -04:00
2016-04-25 16:44:27 -04:00
2016-06-25 12:19:35 -04:00
2016-04-25 16:44:27 -04:00
2018-04-02 20:16:17 +02:00
2017-11-02 11:10:55 +01:00
2013-12-06 12:37:56 -05:00
2018-07-27 13:17:50 -07:00
2018-10-10 10:19:10 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-18 12:39:36 +01:00
2017-11-30 09:54:25 -05:00
2017-11-04 09:26:51 +09:00
2020-11-10 12:36:02 +01:00
2017-11-02 11:10:55 +01:00
2018-03-05 12:52:45 -05:00
2021-07-28 11:13:45 +02:00
2020-01-04 19:13:37 +01:00
2020-07-22 09:31:59 +02:00
2018-05-20 18:31:42 -04:00
2017-11-02 11:10:55 +01:00
2018-02-28 11:43:28 -05:00
2018-05-28 22:59:54 -04:00
2017-11-01 11:50:43 +09:00
2020-03-18 07:14:14 +01:00
2017-11-02 11:10:55 +01:00
2020-03-05 16:42:16 +01:00
2018-07-20 10:14:41 +02:00
2017-11-02 11:10:55 +01:00
2019-12-05 09:19:45 +01:00
2019-11-10 11:27:54 +01:00
2017-11-02 11:10:55 +01:00
2018-08-11 12:37:10 -07:00
2020-07-22 09:31:58 +02:00
2017-11-02 11:10:55 +01:00
2018-02-27 14:46:26 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-12-11 14:10:06 -05:00
2017-11-02 11:10:55 +01:00
2021-03-04 09:39:59 +01:00
2018-06-15 14:04:00 +02:00
2016-01-04 20:40:41 +01:00
2018-05-29 10:12:45 -04:00
2018-04-22 21:12:00 -04:00
2015-12-15 23:25:20 -05:00
2017-01-18 13:04:28 -05:00
2017-08-07 11:39:22 -07:00
2018-06-26 11:33:04 +09:00
2021-04-07 12:48:47 +02:00
2020-07-22 09:32:00 +02:00
2019-04-27 09:36:33 +02:00
2020-01-04 19:13:41 +01:00
2018-10-02 15:52:12 -07:00
2018-06-05 10:45:24 -04:00
2019-02-23 09:07:24 +01:00
2016-03-13 23:55:13 -04:00
2019-06-11 12:20:48 +02:00
2021-08-12 13:19:39 +02:00
2019-07-14 08:11:14 +02:00
2019-01-31 08:14:32 +01:00
2020-11-24 13:27:21 +01:00
2020-08-19 08:14:56 +02:00
2021-07-20 16:15:52 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-07-10 09:53:46 +02:00
2020-04-29 16:31:16 +02:00
2020-02-11 04:34:14 -08:00
2018-03-27 09:51:23 +02:00
2016-08-17 19:36:23 -04:00
2019-02-06 17:30:06 +01:00
2018-07-11 23:10:19 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-25 12:06:25 +09:00
2013-09-21 14:01:38 -04:00
2014-12-10 15:21:24 -05:00
2019-11-06 13:06:23 +01:00
2013-09-21 14:01:38 -04:00
2021-08-04 12:23:46 +02:00
2013-09-21 14:01:38 -04:00
2013-09-21 14:01:38 -04:00
2014-12-10 15:21:24 -05:00
2013-09-21 14:01:38 -04:00
2021-11-26 11:36:16 +01:00
2018-02-14 14:43:32 -05:00
2018-06-18 22:40:32 +02:00
2016-07-08 13:23:12 +02:00
2013-12-06 12:37:56 -05:00
2017-11-02 11:10:55 +01:00
2017-04-01 20:21:44 -07:00
2016-10-03 02:00:22 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-01-09 10:19:09 +01:00
2018-05-28 22:59:54 -04:00
2021-06-30 08:48:18 -04:00
2017-11-02 11:10:55 +01:00
2018-08-01 09:52:30 -07:00
2017-07-01 07:39:09 -07:00
2018-09-29 11:48:26 -07:00
2015-12-08 22:02:33 -05:00
2019-05-02 09:58:57 +02:00
2018-04-07 22:32:31 -04:00
2016-07-08 12:20:57 +02:00
2017-11-08 16:12:33 +09:00
2017-11-02 11:10:55 +01:00
2018-05-24 18:36:15 -07:00
2018-05-16 07:23:35 +02:00
2020-02-01 09:37:06 +00:00
2021-10-17 10:19:49 +02:00
2017-11-02 11:10:55 +01:00
2017-10-01 03:55:47 +01:00
2021-08-26 08:36:38 -04:00
2017-11-02 11:10:55 +01:00
2018-05-16 07:23:35 +02:00
2017-11-02 11:10:55 +01:00
2021-04-14 08:22:34 +02:00
2018-08-28 11:11:47 +02:00
2020-01-27 14:51:18 +01:00
2018-05-16 07:23:35 +02:00
2018-05-29 10:12:45 -04:00
2018-03-13 18:37:02 +02:00
2021-03-30 14:37:03 +02:00
2021-11-26 11:36:04 +01:00
2018-07-21 10:43:12 -05:00
2017-11-02 11:10:55 +01:00
2018-06-22 13:43:27 +09:00
2018-07-31 09:22:48 +02:00
2018-06-22 13:43:27 +09:00
2018-04-11 10:33:46 -04:00
2018-06-30 20:42:25 +09:00
2016-04-28 11:49:45 -04:00
2019-09-21 07:16:43 +02:00
2021-10-06 15:31:24 +02:00
2018-03-01 21:21:36 -05:00
2017-11-02 11:10:55 +01:00
2018-06-06 14:07:53 -04:00
2018-05-03 13:46:47 -04:00
2018-02-21 15:06:05 -05:00
2021-03-17 16:43:43 +01:00
2015-07-09 15:12:20 -07:00
2018-05-08 00:02:41 -04:00
2020-12-08 10:18:52 +01:00
2018-07-07 10:58:49 +09:00
2017-11-02 11:10:55 +01:00
2017-08-29 15:16:52 -07:00
2018-06-26 11:33:04 +09:00
2018-07-03 10:29:26 +09:00
2018-02-16 15:57:42 -05:00
2013-07-27 22:14:06 -07:00
2018-04-17 13:53:13 -04:00
2018-01-24 19:13:45 -05:00
2014-09-05 17:35:28 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-05-04 09:20:12 +02:00
2018-08-10 16:12:20 +02:00
2020-10-14 10:31:24 +02:00