Files
linux/drivers/scsi
Jaegeuk Kim bbab483613 scsi: ufs: Fix clkgating on/off
[ Upstream commit 8eb456be75 ]

The following call stack prevents clk_gating at every I/O completion.  We
can remove the condition, ufshcd_any_tag_in_use(), since clkgating_work
will check it again.

ufshcd_complete_requests(struct ufs_hba *hba)
  ufshcd_transfer_req_compl()
    __ufshcd_transfer_req_compl()
      __ufshcd_release(hba)
        if (ufshcd_any_tag_in_use() == 1)
           return;
  ufshcd_tmc_handler(hba);
    blk_mq_tagset_busy_iter();

Note that this still requires work to deal with a potential race condition
when user sets clkgating.delay_ms to very small value. That can cause
preventing clkgating by the check of ufshcd_any_tag_in_use() in gate_work.

Link: https://lore.kernel.org/r/20201117165839.1643377-7-jaegeuk@kernel.org
Fixes: 7252a36030 ("scsi: ufs: Avoid busy-waiting by eliminating tag conflicts")
Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
Reviewed-by: Can Guo <cang@codeaurora.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-12-30 11:53:17 +01:00
..
2020-12-02 12:59:04 -05:00
2020-03-11 23:07:59 -04:00
2020-12-30 11:53:17 +01:00
2017-12-04 20:32:53 -05:00
2018-06-19 22:02:25 -04:00
2019-11-12 22:21:35 -05:00
2020-02-24 14:54:25 -05:00
2020-03-11 23:07:59 -04:00
2020-10-07 21:48:28 -04:00
2019-01-08 21:58:35 -05:00
2020-09-02 22:49:06 -04:00
2020-09-02 22:49:06 -04:00
2020-08-23 17:36:59 -05:00
2018-11-06 21:31:28 -05:00
2020-07-24 22:09:55 -04:00
2020-09-15 21:31:27 -04:00
2020-09-15 17:34:18 -04:00
2020-08-23 17:36:59 -05:00
2020-06-19 23:06:43 -04:00
2018-06-19 22:02:25 -04:00
2020-02-24 15:01:57 -05:00
2020-08-23 17:36:59 -05:00