Mikhail Lappo ecb67e92d4 thermal: imx: Fix race condition in imx_thermal_probe() ...

commit cf1ba1d73a upstream.

When device boots with T > T_trip_1 and requests interrupt,
the race condition takes place. The interrupt comes before
THERMAL_DEVICE_ENABLED is set. This leads to an attempt to
reading sensor value from irq and disabling the sensor, based on
the data->mode field, which expected to be THERMAL_DEVICE_ENABLED,
but still stays as THERMAL_DEVICE_DISABLED. Afher this issue
sensor is never re-enabled, as the driver state is wrong.

Fix this problem by setting the 'data' members prior to
requesting the interrupts.

Fixes: 37713a1e8e ("thermal: imx: implement thermal alarm interrupt handling")
Cc: <stable@vger.kernel.org>
Signed-off-by: Mikhail Lappo <mikhail.lappo@esrlabs.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-04-24 09:36:34 +02:00

..

broadcom

thermal: bcm2835: constify thermal_zone_of_device_ops structures

2017-08-11 11:38:30 +08:00

int340x_thermal

thermal: int3400_thermal: fix error handling in int3400_thermal_probe()

2018-04-12 12:32:21 +02:00

qcom

thermal: qcom: tsens: Fix return value check in init_common()

2016-09-27 14:02:16 +08:00

samsung

thermal: exynos: constify thermal_zone_of_device_ops structures

2017-08-11 11:38:30 +08:00

st

thermal: Enhance thermal_zone_device_update for events

2016-09-27 14:35:21 +08:00

tegra

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

ti-soc-thermal

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

armada_thermal.c

thermal: armada: Fix possible overflow in the Armada 380 thermal sensor formula

2015-10-30 11:33:23 -07:00

clock_cooling.c

thermal: convert clock cooling to use an IDA

2017-01-04 12:47:28 +08:00

cpu_cooling.c

thermal: cpu_cooling: Replace kmalloc with kmalloc_array

2017-05-27 17:33:04 -07:00

da9062-thermal.c

thermal: da9062/61: Thermal junction temperature monitoring driver

2017-04-06 21:48:03 -07:00

db8500_thermal.c

thermal: db8500: Fix module autoload

2016-11-23 10:07:35 +08:00

devfreq_cooling.c

trace: thermal: add another parameter 'power' to the tracing function

2017-05-05 15:54:45 +08:00

dove_thermal.c

thermal: consistently use int for temperatures

2015-08-03 23:15:50 +08:00

fair_share.c

thermal: fix source code documentation for parameters

2017-06-29 10:46:31 +08:00

gov_bang_bang.c

thermal: bang-bang governor: act on lower trip boundary

2016-09-27 14:02:16 +08:00

hisi_thermal.c

thermal/drivers/hisi: Fix multiple alarm interrupts firing

2017-12-25 14:26:31 +01:00

imx_thermal.c

thermal: imx: Fix race condition in imx_thermal_probe()

2018-04-24 09:36:34 +02:00

intel_bxt_pmic_thermal.c

mfd: intel_soc_pmic_bxtwc: Remove thermal second level IRQs

2017-06-19 15:44:29 +01:00

intel_pch_thermal.c

thermal: intel_pch_thermal: Fix enable check on Broadwell-DE

2017-08-15 14:32:58 +08:00

intel_powerclamp.c

sched/headers: Prepare for new header dependencies before moving code to <uapi/linux/sched/types.h>

2017-03-02 08:42:27 +01:00

intel_quark_dts_thermal.c

x86/platform/iosf_mbi: Remove duplicate definitions

2015-12-09 01:18:34 +01:00

intel_soc_dts_iosf.c

thermal: Enhance thermal_zone_device_update for events

2016-09-27 14:35:21 +08:00

intel_soc_dts_iosf.h

Thermal: Intel SoC: DTS thermal IOSF core

2015-05-01 11:20:42 +08:00

intel_soc_dts_thermal.c

Thermal: Intel SoC DTS: Change interrupt request behavior

2017-05-05 16:00:10 +08:00

Kconfig

Merge branches 'thermal-core', 'thermal-soc', 'thermal-intel' and 'const-thermal-zone-structure' into next

2017-09-08 11:20:04 +08:00

kirkwood_thermal.c

thermal: consistently use int for temperatures

2015-08-03 23:15:50 +08:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

max77620_thermal.c

thermal: max77620: fix pinmux conflict on reprobe

2017-06-13 11:07:32 +02:00

mtk_thermal.c

thermal: mediatek: minor mtk_thermal.c cleanups

2017-08-31 21:13:53 +08:00

of-thermal.c

thermal: Enhance thermal_zone_device_update for events

2016-09-27 14:35:21 +08:00

power_allocator.c

thermal: power_allocator: fix one race condition issue for thermal_instances list

2018-04-12 12:32:12 +02:00

qcom-spmi-temp-alarm.c

thermal: qcom-spmi: Treat reg property as a single cell

2016-11-23 10:07:35 +08:00

qoriq_thermal.c

thermal: qoriq: constify thermal_zone_of_device_ops structures

2017-08-11 11:38:29 +08:00

rcar_gen3_thermal.c

thermal: rcar_gen3_thermal: constify thermal_zone_of_device_ops structures

2017-08-11 11:38:29 +08:00

rcar_thermal.c

Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux

2016-10-12 11:05:23 -07:00

rockchip_thermal.c

thermal: rockchip: Support the RK3328 SOC in thermal driver

2017-08-11 16:21:38 +08:00

spear_thermal.c

thermal: spear: use __maybe_unused for PM functions

2016-02-09 14:12:08 -08:00

step_wise.c

thermal/drivers/step_wise: Fix temperature regulation misbehavior

2017-12-20 10:10:28 +01:00

tango_thermal.c

thermal: tango: Fix module autoload

2016-11-23 10:07:35 +08:00

thermal_core.c

thermal: core: Fix resources release in error paths in thermal_zone_device_register()

2017-08-11 11:34:07 +08:00

thermal_core.h

thermal: core: Add some new helper functions to free resources

2017-08-11 11:33:49 +08:00

thermal_helpers.c

thermal: core: move slop and offset helpers to thermal_helpers.c

2016-11-23 10:06:12 +08:00

thermal_hwmon.c

Revert "thermal: thermal_hwmon: Convert to hwmon_device_register_with_info()"

2017-01-25 09:51:08 +08:00

thermal_hwmon.h

thermal: hwmon: move hwmon support to single file

2013-09-03 09:09:12 -04:00

thermal_sysfs.c

thermal: core: Add some new helper functions to free resources

2017-08-11 11:33:49 +08:00

thermal-generic-adc.c

thermal: generic-adc: Add ADC based thermal sensor driver

2016-05-17 07:28:31 -07:00

uniphier_thermal.c

thermal: uniphier: add UniPhier thermal driver

2017-08-11 10:49:52 +08:00

user_space.c

thermal: fix source code documentation for parameters

2017-06-29 10:46:31 +08:00

x86_pkg_temp_thermal.c

thermal/x86 pkg temp: Convert to hotplug state machine

2016-11-30 10:25:47 +08:00

zx2967_thermal.c

thermal: zx2967: constify thermal_zone_of_device_ops structures

2017-08-11 11:38:30 +08:00