Vegard Nossum 3a22cf0c7b ext4: fix reference counting bug on block allocation error ...

commit 554a5ccc4e upstream.

If we hit this error when mounted with errors=continue or
errors=remount-ro:

    EXT4-fs error (device loop0): ext4_mb_mark_diskspace_used:2940: comm ext4.exe: Allocating blocks 5090-6081 which overlap fs metadata

then ext4_mb_new_blocks() will call ext4_mb_release_context() and try to
continue. However, ext4_mb_release_context() is the wrong thing to call
here since we are still actually using the allocation context.

Instead, just error out. We could retry the allocation, but there is a
possibility of getting stuck in an infinite loop instead, so this seems
safer.

[ Fixed up so we don't return EAGAIN to userspace. --tytso ]

Fixes: 8556e8f3b6 ("ext4: Don't allow new groups to be added during block allocation")
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2016-08-16 09:30:51 +02:00

..

9p

9p: use file_dentry()

2016-08-10 11:49:27 +02:00

adfs

fs/adfs: remove unneeded cast

2015-06-30 19:44:57 -07:00

affs

affs: fix remount failure when there are no options changed

2016-06-07 18:14:32 -07:00

afs

net: Add a struct net parameter to sock_create_kern

2015-05-11 10:50:17 -04:00

autofs4

make simple_positive() public

2015-06-23 18:02:01 -04:00

befs

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2015-07-04 19:36:06 -07:00

bfs

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2015-04-26 17:22:07 -07:00

btrfs

btrfs: account for non-CoW'd blocks in btrfs_abort_transaction

2016-07-27 09:47:33 -07:00

cachefiles

FS-Cache: Add missing initialization of ret in cachefiles_write_page()

2015-11-16 20:38:43 -05:00

ceph

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client

2015-11-13 09:24:40 -08:00

cifs

File names with trailing period or space need special case conversion

2016-07-27 09:47:39 -07:00

coda

fs/coda: fix readlink buffer overflow

2015-09-10 13:29:01 -07:00

configfs

configfs: allow dynamic group creation

2015-11-20 16:17:32 -08:00

cramfs

…

debugfs

debugfs: Make automount point inodes permanently empty

2016-05-04 14:48:41 -07:00

devpts

devpts: clean up interface to pty drivers

2016-08-16 09:30:49 +02:00

dlm

net: rename SOCK_ASYNC_NOSPACE and SOCK_ASYNC_WAITDATA

2015-12-01 15:45:05 -05:00

ecryptfs

ecryptfs: don't allow mmap when the lower fs doesn't support it

2016-08-10 11:49:27 +02:00

efivarfs

efi: Make efivarfs entries immutable by default

2016-03-03 15:07:09 -08:00

efs

fs/efs: femove unneeded cast

2015-06-25 17:00:42 -07:00

exofs

osd fs: __r4w_get_page rely on PageUptodate for uptodate

2015-12-12 10:15:34 -08:00

exportfs

VFS: (Scripted) Convert S_ISLNK/DIR/REG(dentry->d_inode) to d_is_*(dentry)

2015-02-22 11:38:41 -05:00

ext2

ext2, ext4: warn when mounting with dax enabled

2015-11-16 09:43:54 -08:00

ext4

ext4: fix reference counting bug on block allocation error

2016-08-16 09:30:51 +02:00

f2fs

Merge branch 'for-linus-3' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2015-11-13 18:02:30 -08:00

fat

fat: fix fake_offset handling on error path

2015-11-20 16:17:32 -08:00

freevxfs

freevxfs: Grammar s/an negative/a negative/

2015-08-07 13:59:24 +02:00

fscache

FS-Cache: Handle a write to the page immediately beyond the EOF marker

2015-11-11 02:11:02 -05:00

fuse

fuse: fix wrong assignment of ->flags in fuse_send_init()

2016-08-16 09:30:50 +02:00

gfs2

Merge branch 'for-linus-3' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2015-11-13 18:02:30 -08:00

hfs

hfs: fix B-tree corruption after insertion at position 0

2015-09-10 13:29:01 -07:00

hfsplus

xattr handlers: Pass handler to operations instead of flags

2015-11-13 20:34:32 -05:00

hostfs

uml: fix hostfs mknod()

2016-03-03 15:07:12 -08:00

hpfs

hpfs: implement the show_options method

2016-06-01 12:15:54 -07:00

hugetlbfs

fs/hugetlbfs/inode.c: fix bugs in hugetlb_vmtruncate_list()

2016-02-25 12:01:22 -08:00

isofs

get_rock_ridge_filename(): handle malformed NM entries

2016-05-18 17:06:54 -07:00

jbd2

jbd2: fix FS corruption possibility in jbd2_journal_destroy() on umount path

2016-04-12 09:08:53 -07:00

jffs2

jffs2: reduce the breakage on recovery from halfway failed rename()

2016-03-16 08:42:58 -07:00

jfs

fs/jfs: remove unnecessary new_valid_dev() checks

2015-11-09 15:11:24 -08:00

kernfs

kernfs: implement kernfs_path_len()

2015-08-18 15:49:15 -07:00

lockd

Merge tag 'nfsd-4.4' of git://linux-nfs.org/~bfields/linux

2015-11-11 20:11:28 -08:00

logfs

mm, fs: introduce mapping_gfp_constraint()

2015-11-06 17:50:42 -08:00

minix

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2015-07-04 19:36:06 -07:00

ncpfs

ncpfs: fix a braino in OOM handling in ncp_fill_cache()

2016-03-16 08:42:59 -07:00

nfs

NFS: Fix another OPEN_DOWNGRADE bug

2016-07-27 09:47:30 -07:00

nfs_common

lockd: NLM grace period shouldn't block NFSv4 opens

2015-08-13 10:22:06 -04:00

nfsd

nfsd: check permissions when setting ACLs

2016-07-27 09:47:30 -07:00

nilfs2

fs/nilfs2: fix potential underflow in call to crc32_le

2016-08-10 11:49:25 +02:00

nls

…

notify

inotify: actually check for invalid bits in sys_inotify_add_watch()

2015-11-05 19:34:48 -08:00

ntfs

mm, fs: introduce mapping_gfp_constraint()

2015-11-06 17:50:42 -08:00

ocfs2

ocfs2: fix posix_acl_create deadlock

2016-05-18 17:06:44 -07:00

omfs

omfs: fix potential integer overflow in allocator

2015-05-28 18:25:19 -07:00

openpromfs

…

overlayfs

ovl: handle ATTR_KILL*

2016-08-10 11:49:28 +02:00

proc

proc: prevent stacking filesystems on top

2016-06-24 10:18:20 -07:00

pstore

pstore: fix code comment to match code

2015-11-02 13:41:52 -08:00

qnx4

…

qnx6

pagemap.h: move dir_pages() over there

2015-06-23 18:02:00 -04:00

quota

quota: Fix possible GPF due to uninitialised pointers

2016-04-12 09:08:56 -07:00

ramfs

mm, fs: obey gfp_mapping for add_to_page_cache()

2015-10-16 11:42:28 -07:00

reiserfs

Merge branch 'for-linus-3' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2015-11-13 18:02:30 -08:00

romfs

make new_sync_{read,write}() static

2015-04-11 22:29:40 -04:00

squashfs

squashfs: xattr simplifications

2015-11-13 20:34:33 -05:00

sysfs

Merge tag 'chrome-platform-4.4' of git://git.kernel.org/pub/scm/linux/kernel/git/olof/chrome-platform

2015-11-13 21:53:18 -08:00

sysv

fix sysvfs symlinks

2015-11-23 21:11:08 -05:00

tracefs

tracefs: Fix refcount imbalance in start_creating()

2015-11-04 22:13:45 -05:00

ubifs

UBIFS: Implement ->migratepage()

2016-07-27 09:47:31 -07:00

udf

udf: Check output buffer length when converting name to CS0

2016-02-25 12:01:18 -08:00

ufs

fix ufs write vs readpage race when writing into a hole

2015-09-09 10:43:12 -07:00

xfs

xfs: handle dquot buffer readahead in log recovery correctly

2016-06-07 18:14:38 -07:00

aio.c

mm: move ->mremap() from file_operations to vm_operations_struct

2015-09-04 16:54:41 -07:00

anon_inodes.c

…

attr.c

…

bad_inode.c

don't bother with most of the bad_file_ops methods

2015-02-20 04:03:58 -05:00

binfmt_aout.c

assorted conversions to %p[dD]

2014-11-19 13:01:20 -05:00

binfmt_elf_fdpic.c

Merge tag 'libnvdimm-for-4.4' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm

2015-11-10 12:07:22 -08:00

binfmt_elf.c

Merge branch 'for-linus-2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2015-11-11 09:45:24 -08:00

binfmt_em86.c

syscalls: implement execveat() system call

2014-12-13 12:42:51 -08:00

binfmt_flat.c

…

binfmt_misc.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2015-04-26 17:22:07 -07:00

binfmt_script.c

syscalls: implement execveat() system call

2014-12-13 12:42:51 -08:00

block_dev.c

block: detach bdev inode from its wb in __blkdev_put()

2015-12-04 11:02:17 -07:00

buffer.c

vfs: remove unused wrapper block_page_mkwrite()

2015-11-11 02:19:33 -05:00

char_dev.c

fs/char_dev.c: fix incorrect documentation for unregister_chrdev_region

2015-08-05 13:49:35 -07:00

compat_binfmt_elf.c

…

compat_ioctl.c

i2c-dev: Fix typo in ioctl name reference

2015-10-23 23:26:43 +02:00

compat.c

vfs: make first argument of dir_context.actor typed

2014-10-31 17:48:54 -04:00

coredump.c

fs/coredump: prevent fsuid=0 dumps into user-controlled directories

2016-04-12 09:08:58 -07:00

dax.c

dax: disable pmd mappings

2015-11-16 23:54:45 -08:00

dcache.c

fs/dcache.c: avoid soft-lockup in dput()

2016-08-16 09:30:50 +02:00

dcookies.c

…

direct-io.c

block: fix use-after-free in dio_bio_complete

2016-03-03 15:07:28 -08:00

drop_caches.c

inode: convert inode_sb_list_lock to per-sb

2015-08-17 18:39:46 -04:00

eventfd.c

eventfd: don't take the spinlock in eventfd_poll

2015-02-17 14:34:52 -08:00

eventpoll.c

epoll: optimize setting task running after blocking

2015-02-13 21:21:40 -08:00

exec.c

vfs: Commit to never having exectuables on proc and sysfs.

2015-07-10 10:39:25 -05:00

fcntl.c

vfs: renumber FMODE_NONOTIFY and add to uniqueness check

2015-01-08 15:10:52 -08:00

fhandle.c

fs/coredump: prevent fsuid=0 dumps into user-controlled directories

2016-04-12 09:08:58 -07:00

file_table.c

fs, file table: reinit files_stat.max_files after deferred memory initialisation

2015-08-07 04:39:40 +03:00

file.c

vfs: clear remainder of 'full_fds_bits' in dup_fd()

2015-11-05 23:05:32 -08:00

filesystems.c

…

fs_pin.c

fs_pin: Allow for the possibility that m_list or s_list go unused.

2015-04-09 11:39:55 -05:00

fs_struct.c

…

fs-writeback.c

writeback, cgroup: fix use of the wrong bdi_writeback which mismatches the inode

2016-04-12 09:09:04 -07:00

inode.c

vfs: fix deadlock in file_remove_privs() on overlayfs

2016-08-10 11:49:30 +02:00

internal.h

inode: rename i_wb_list to i_io_list

2015-08-17 23:38:10 -04:00

ioctl.c

fsioctl.c: make generic_block_fiemap() signal-tolerant

2015-02-10 14:30:30 -08:00

Kconfig

dax: disable pmd mappings

2015-11-16 23:54:45 -08:00

Kconfig.binfmt

mm: split ET_DYN ASLR from mmap ASLR

2015-04-14 16:49:05 -07:00

libfs.c

fs: Set the size of empty dirs to 0.

2015-08-12 15:28:45 -05:00

locks.c

locks: use file_inode()

2016-08-10 11:49:27 +02:00

Makefile

ext4: promote ext4 over ext2 in the default probe order

2015-10-15 10:33:21 -04:00

mbcache.c

…

mount.h

fs: use seq_open_private() for proc_mounts

2015-06-30 19:44:56 -07:00

mpage.c

mm, fs: introduce mapping_gfp_constraint()

2015-11-06 17:50:42 -08:00

namei.c

atomic_open(): fix the handling of create_error

2016-05-18 17:06:51 -07:00

namespace.c

namespace: update event counter when umounting a deleted dentry

2016-08-10 11:49:27 +02:00

no-block.c

…

nsfs.c

fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void

2015-09-11 15:21:34 -07:00

open.c

vfs: add vfs_select_inode() helper

2016-05-18 17:06:48 -07:00

pipe.c

pipe: limit the per-user amount of pages allocated in pipes

2016-06-07 18:14:35 -07:00

pnode.c

propogate_mnt: Handle the first propogated copy being a slave

2016-05-11 11:21:19 +02:00

pnode.h

mnt: Clarify and correct the disconnect logic in umount_tree

2015-07-22 20:33:27 -05:00

posix_acl.c

posix_acl: Add set_posix_acl

2016-07-27 09:47:30 -07:00

proc_namespace.c

vfs: show_vfsstat: do not ignore errors from show_devname method

2016-04-12 09:08:55 -07:00

read_write.c

new_sync_write(): discard ->ki_pos unless the return value is positive

2015-04-11 22:29:46 -04:00

readdir.c

vfs: make first argument of dir_context.actor typed

2014-10-31 17:48:54 -04:00

select.c

locking/arch: Rename set_mb() to smp_store_mb()

2015-05-19 08:32:00 +02:00

seq_file.c

fs, seqfile: always allow oom killer

2015-11-06 17:50:42 -08:00

signalfd.c

signalfd: fix information leak in signalfd_copyinfo

2015-08-07 04:39:40 +03:00

splice.c

splice: handle zero nr_pages in splice_to_pipe()

2016-04-12 09:08:55 -07:00

stack.c

…

stat.c

fs/stat.c: remove unnecessary new_valid_dev() check

2015-11-09 15:11:24 -08:00

statfs.c

…

super.c

writeback: flush inode cgroup wb switches instead of pinning super_block

2016-03-09 15:34:52 -08:00

sync.c

fs/sync.c: make sync_file_range(2) use WB_SYNC_NONE writeback

2015-11-06 17:50:42 -08:00

timerfd.c

timerfd: Handle relative timers with CONFIG_TIME_LOW_RES proper

2016-02-25 12:01:25 -08:00

userfaultfd.c

userfaultfd: don't block on the last VM updates at exit time

2016-03-16 08:43:01 -07:00

utimes.c

…

xattr.c

9p: xattr simplifications

2015-11-13 20:34:33 -05:00