Ming Lei
0dcc9985f3
ath9k: fix lockdep warning when unloading module
commit a9f042cbe5 upstream.
Since txq->axq_lock may be hold in softirq context, it must be
acquired with spin_lock_bh() instead of spin_lock() if softieq is
enabled.
The patch fixes the lockdep warning below when unloading ath9k modules.
=================================
[ INFO: inconsistent lock state ]
2.6.33-wl #12
---------------------------------
inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage.
rmmod/3642 [HC0[0]:SC0[0]:HE1:SE1] takes:
(&(&txq->axq_lock)->rlock){+.?...}, at: [<ffffffffa03568c3>] ath_tx_node_cleanup+0x62/0x180 [ath9k]
{IN-SOFTIRQ-W} state was registered at:
[<ffffffff8107577d>] __lock_acquire+0x2f6/0xd35
[<ffffffff81076289>] lock_acquire+0xcd/0xf1
[<ffffffff813a7486>] _raw_spin_lock_bh+0x3b/0x6e
[<ffffffffa0356b49>] spin_lock_bh+0xe/0x10 [ath9k]
[<ffffffffa0358ec7>] ath_tx_tasklet+0xcd/0x391 [ath9k]
[<ffffffffa0354f5f>] ath9k_tasklet+0x70/0xc8 [ath9k]
[<ffffffff8104e601>] tasklet_action+0x8c/0xf4
[<ffffffff8104f459>] __do_softirq+0xf8/0x1cd
[<ffffffff8100ab1c>] call_softirq+0x1c/0x30
[<ffffffff8100c2cf>] do_softirq+0x4b/0xa3
[<ffffffff8104f045>] irq_exit+0x4a/0x8c
[<ffffffff813acccc>] do_IRQ+0xac/0xc3
[<ffffffff813a7d53>] ret_from_intr+0x0/0x16
[<ffffffff81302d52>] cpuidle_idle_call+0x9e/0xf8
[<ffffffff81008be7>] cpu_idle+0x62/0x9d
[<ffffffff81391c1a>] rest_init+0x7e/0x80
[<ffffffff818bbd38>] start_kernel+0x3e8/0x3f3
[<ffffffff818bb2bc>] x86_64_start_reservations+0xa7/0xab
[<ffffffff818bb3b8>] x86_64_start_kernel+0xf8/0x107
irq event stamp: 42037
hardirqs last enabled at (42037): [<ffffffff813a7b21>] _raw_spin_unlock_irqrestore+0x47/0x56
hardirqs last disabled at (42036): [<ffffffff813a72f4>] _raw_spin_lock_irqsave+0x2b/0x88
softirqs last enabled at (42000): [<ffffffffa0353ea6>] spin_unlock_bh+0xe/0x10 [ath9k]
softirqs last disabled at (41998): [<ffffffff813a7463>] _raw_spin_lock_bh+0x18/0x6e
other info that might help us debug this:
4 locks held by rmmod/3642:
#0: (rtnl_mutex){+.+.+.}, at: [<ffffffff8132c10d>] rtnl_lock+0x17/0x19
#1: (&wdev->mtx){+.+.+.}, at: [<ffffffffa01e53f2>] cfg80211_netdev_notifier_call+0x28d/0x46d [cfg80211]
#2: (&ifmgd->mtx){+.+.+.}, at: [<ffffffffa0260834>] ieee80211_mgd_deauth+0x3f/0x17e [mac80211]
#3: (&local->sta_mtx){+.+.+.}, at: [<ffffffffa025a381>] sta_info_destroy_addr+0x2b/0x5e [mac80211]
stack backtrace:
Pid: 3642, comm: rmmod Not tainted 2.6.33-wl #12
Call Trace:
[<ffffffff81074469>] valid_state+0x178/0x18b
[<ffffffff81014f94>] ? save_stack_trace+0x2f/0x4c
[<ffffffff81074e08>] ? check_usage_backwards+0x0/0x88
[<ffffffff8107458f>] mark_lock+0x113/0x230
[<ffffffff810757f1>] __lock_acquire+0x36a/0xd35
[<ffffffff8101018d>] ? native_sched_clock+0x2d/0x5f
[<ffffffffa03568c3>] ? ath_tx_node_cleanup+0x62/0x180 [ath9k]
[<ffffffff81076289>] lock_acquire+0xcd/0xf1
[<ffffffffa03568c3>] ? ath_tx_node_cleanup+0x62/0x180 [ath9k]
[<ffffffff810732eb>] ? trace_hardirqs_off+0xd/0xf
[<ffffffff813a7193>] _raw_spin_lock+0x36/0x69
[<ffffffffa03568c3>] ? ath_tx_node_cleanup+0x62/0x180 [ath9k]
[<ffffffffa03568c3>] ath_tx_node_cleanup+0x62/0x180 [ath9k]
[<ffffffff810749ed>] ? trace_hardirqs_on+0xd/0xf
[<ffffffffa0353950>] ath9k_sta_remove+0x22/0x26 [ath9k]
[<ffffffffa025a08f>] __sta_info_destroy+0x1ad/0x38c [mac80211]
[<ffffffffa025a394>] sta_info_destroy_addr+0x3e/0x5e [mac80211]
[<ffffffffa02605d6>] ieee80211_set_disassoc+0x175/0x180 [mac80211]
[<ffffffffa026084d>] ieee80211_mgd_deauth+0x58/0x17e [mac80211]
[<ffffffff813a60c1>] ? __mutex_lock_common+0x37f/0x3a4
[<ffffffffa01e53f2>] ? cfg80211_netdev_notifier_call+0x28d/0x46d [cfg80211]
[<ffffffffa026786e>] ieee80211_deauth+0x1e/0x20 [mac80211]
[<ffffffffa01f47f9>] __cfg80211_mlme_deauth+0x130/0x13f [cfg80211]
[<ffffffffa01e53f2>] ? cfg80211_netdev_notifier_call+0x28d/0x46d [cfg80211]
[<ffffffff810732eb>] ? trace_hardirqs_off+0xd/0xf
[<ffffffffa01f7eee>] __cfg80211_disconnect+0x111/0x189 [cfg80211]
[<ffffffffa01e5433>] cfg80211_netdev_notifier_call+0x2ce/0x46d [cfg80211]
[<ffffffff813aa9ea>] notifier_call_chain+0x37/0x63
[<ffffffff81068c98>] raw_notifier_call_chain+0x14/0x16
[<ffffffff81322e97>] call_netdevice_notifiers+0x1b/0x1d
[<ffffffff8132386d>] dev_close+0x6a/0xa6
[<ffffffff8132395f>] rollback_registered_many+0xb6/0x2f4
[<ffffffff81323bb8>] unregister_netdevice_many+0x1b/0x66
[<ffffffffa026494f>] ieee80211_remove_interfaces+0xc5/0xd0 [mac80211]
[<ffffffffa02580a2>] ieee80211_unregister_hw+0x47/0xe8 [mac80211]
[<ffffffffa035290e>] ath9k_deinit_device+0x7a/0x9b [ath9k]
[<ffffffffa035bc26>] ath_pci_remove+0x38/0x76 [ath9k]
[<ffffffff8120940a>] pci_device_remove+0x2d/0x51
[<ffffffff8129d797>] __device_release_driver+0x7b/0xd1
[<ffffffff8129d885>] driver_detach+0x98/0xbe
[<ffffffff8129ca7a>] bus_remove_driver+0x94/0xb7
[<ffffffff8129ddd6>] driver_unregister+0x6c/0x74
[<ffffffff812096d2>] pci_unregister_driver+0x46/0xad
[<ffffffffa035bae1>] ath_pci_exit+0x15/0x17 [ath9k]
[<ffffffffa035e1a2>] ath9k_exit+0xe/0x2f [ath9k]
[<ffffffff8108050a>] sys_delete_module+0x1c7/0x236
[<ffffffff813a7df5>] ? retint_swapgs+0x13/0x1b
[<ffffffff810749b5>] ? trace_hardirqs_on_caller+0x119/0x144
[<ffffffff8109b9f6>] ? audit_syscall_entry+0x11e/0x14a
[<ffffffff81009bb2>] system_call_fastpath+0x16/0x1b
wlan1: deauthenticating from 00:23:cd:e1:f9:b2 by local choice (reason=3)
PM: Removing info for No Bus:wlan1
cfg80211: Calling CRDA to update world regulatory domain
PM: Removing info for No Bus:rfkill2
PM: Removing info for No Bus:phy1
ath9k 0000:16:00.0: PCI INT A disabled
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-04-01 15:58:18 -07:00
..
2009-09-11 12:54:23 -07:00
2009-09-21 15:14:58 +02:00
2009-11-29 23:50:32 -08:00
2010-01-28 15:00:59 -08:00
2010-01-28 15:01:00 -08:00
2009-09-03 20:02:11 -07:00
2010-02-09 04:50:59 -08:00
2009-10-29 09:22:08 -07:00
2009-11-13 19:56:55 -08:00
2009-09-01 01:14:07 -07:00
2009-09-24 17:08:56 -07:00
2009-11-18 05:11:14 -08:00
2010-02-09 04:50:45 -08:00
2010-04-01 15:58:17 -07:00
2009-09-24 15:13:11 -07:00
2009-09-03 20:19:25 -07:00
2009-10-14 14:54:52 -07:00
2009-10-11 11:20:58 -07:00
2009-11-18 05:11:09 -08:00
2009-10-29 09:22:08 -07:00
2009-10-26 16:09:01 -07:00
2009-10-15 15:03:17 -07:00
2009-09-01 01:13:52 -07:00
2010-04-01 15:58:17 -07:00
2009-10-13 00:03:11 -07:00
2009-10-14 10:52:40 -07:00
2009-10-22 21:43:43 -07:00
2009-11-21 11:37:37 -08:00
2009-10-29 22:51:25 -07:00
2009-11-17 04:04:40 -08:00
2010-01-28 15:01:48 -08:00
2010-01-28 15:00:31 -08:00
2009-10-11 11:20:58 -07:00
2009-11-23 10:37:52 -08:00
2009-11-03 07:44:01 -08:00
2009-09-03 20:02:11 -07:00
2010-01-06 15:03:47 -08:00
2009-10-16 17:54:34 -07:00
2009-09-21 15:14:58 +02:00
2009-11-30 00:06:51 -08:00
2009-09-11 12:54:55 -07:00
2010-04-01 15:58:18 -07:00
2009-09-30 20:11:11 -07:00
2009-09-01 01:13:50 -07:00
2009-09-01 01:13:50 -07:00
2009-09-04 03:41:07 -07:00
2006-09-13 13:24:59 -04:00
2009-09-01 01:13:50 -07:00
2008-04-29 01:55:11 -04:00
2009-09-01 01:13:50 -07:00
2009-09-01 01:13:50 -07:00
2009-09-01 01:13:50 -07:00
2009-09-01 01:13:50 -07:00
2006-09-13 13:24:59 -04:00
2009-09-01 01:13:50 -07:00
2006-09-13 13:24:59 -04:00
2009-07-05 19:23:38 -07:00
2007-10-10 16:51:16 -07:00
2009-09-22 14:00:15 -07:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2006-09-13 13:24:59 -04:00
2009-03-27 00:46:54 -07:00
2009-10-12 04:18:48 -07:00
2009-09-01 01:14:07 -07:00
2009-09-03 20:02:11 -07:00
2007-10-10 16:51:58 -07:00
2008-11-25 18:25:32 -08:00
2009-09-01 01:14:07 -07:00
2007-10-19 23:21:04 +02:00
2009-09-01 01:14:07 -07:00
2009-07-05 19:16:04 -07:00
2009-09-01 01:14:07 -07:00
2005-04-16 15:20:36 -07:00
2009-11-22 20:40:52 -08:00
2008-10-08 16:29:57 -07:00
2009-03-24 23:32:03 -07:00
2009-12-18 14:05:08 -08:00
2009-06-15 03:02:23 -07:00
2009-12-18 14:05:43 -08:00
2009-09-17 20:07:53 +02:00
2009-09-02 01:03:33 -07:00
2008-10-08 16:29:57 -07:00
2009-08-12 17:44:53 -07:00
2006-09-13 13:24:59 -04:00
2009-04-04 16:51:14 -07:00
2009-09-03 20:02:11 -07:00
2009-10-28 03:41:59 -07:00
2009-08-12 23:03:00 -07:00
2009-08-12 22:53:28 -07:00
2009-04-27 03:27:43 -07:00
2009-08-12 23:02:12 -07:00
2009-08-12 23:02:59 -07:00
2009-08-12 23:02:59 -07:00
2009-08-12 23:03:01 -07:00
2009-08-12 23:02:57 -07:00
2009-09-02 01:03:33 -07:00
2009-09-21 15:14:54 +02:00
2009-08-12 23:03:01 -07:00
2007-08-26 18:35:45 -07:00
2009-11-06 20:26:09 -08:00
2008-09-22 19:27:10 -07:00
2009-06-09 10:22:42 -05:00
2009-10-02 11:03:28 -07:00
2009-10-28 03:41:59 -07:00
2009-08-15 18:50:44 -07:00
2009-09-21 11:32:23 -07:00
2009-09-01 01:14:07 -07:00
2006-09-13 13:24:59 -04:00
2009-11-20 13:57:54 -08:00
2009-07-05 19:16:04 -07:00
2007-10-10 16:51:16 -07:00
2009-07-05 19:16:04 -07:00
2005-04-16 15:20:36 -07:00
2009-07-05 19:16:04 -07:00
2009-09-01 01:14:07 -07:00
2007-02-09 16:23:17 +00:00
2009-10-11 11:20:58 -07:00
2006-09-13 13:24:59 -04:00
2009-09-01 01:14:07 -07:00
2008-02-01 20:54:03 +11:00
2009-09-09 18:54:49 -07:00
2009-10-24 06:53:07 -07:00
2009-09-01 01:14:07 -07:00
2009-03-11 23:26:02 -07:00
2009-09-01 01:13:40 -07:00
2010-01-06 15:04:38 -08:00
2009-02-17 17:21:08 -08:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2008-12-29 18:42:33 -08:00
2008-01-28 15:08:03 -08:00
2009-09-23 07:39:43 -07:00
2009-09-01 01:14:07 -07:00
2009-10-11 11:20:58 -07:00
2008-11-25 18:23:59 -08:00
2009-09-01 01:14:07 -07:00
2009-10-23 07:34:23 +09:00
2009-10-11 11:20:58 -07:00
2006-09-13 13:24:59 -04:00
2009-09-01 01:14:07 -07:00
2009-10-14 14:54:52 -07:00
2009-10-14 15:10:19 -07:00
2008-05-01 11:05:58 -06:00
2009-10-20 18:51:37 -07:00
2009-07-06 18:56:11 -07:00
2009-11-18 14:54:45 -08:00
2009-11-08 00:49:04 -08:00
2009-02-04 16:42:35 -08:00
2009-09-21 15:14:58 +02:00
2009-02-04 16:43:44 -08:00
2009-10-14 14:54:52 -07:00
2009-06-03 02:43:41 -07:00
2009-10-11 11:20:58 -07:00
2009-10-11 11:20:58 -07:00
2006-09-13 13:24:59 -04:00
2009-02-26 21:02:19 -08:00
2008-11-25 18:24:57 -08:00
2009-04-16 02:20:08 -07:00
2005-04-16 15:20:36 -07:00
2009-09-07 01:56:52 -07:00
2009-09-01 01:14:07 -07:00
2007-10-10 16:51:16 -07:00
2009-09-01 01:14:07 -07:00
2009-01-06 10:47:44 -08:00
2009-10-22 21:54:19 -07:00
2009-07-05 19:16:04 -07:00
2009-09-02 01:03:33 -07:00
2009-06-12 18:01:46 +02:00
2009-07-16 20:21:24 -07:00
2009-10-02 09:55:19 -07:00
2009-08-12 21:54:57 -07:00
2009-09-01 01:14:07 -07:00
2009-07-06 13:05:13 -07:00
2009-11-20 13:53:33 -08:00
2009-09-02 01:03:33 -07:00
2009-09-02 01:03:33 -07:00
2010-03-15 08:49:39 -07:00
2009-10-20 19:11:07 -07:00
2009-10-20 19:11:06 -07:00
2009-09-01 01:14:07 -07:00
2009-05-05 12:29:47 -07:00
2009-09-01 01:14:07 -07:00
2009-07-05 19:16:04 -07:00
2005-04-16 15:20:36 -07:00
2009-09-21 15:14:58 +02:00
2009-04-27 02:53:52 -07:00
2009-04-27 02:53:52 -07:00
2008-11-25 18:24:38 -08:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-07-05 19:16:04 -07:00
2009-06-03 02:43:41 -07:00
2009-09-21 15:14:56 +02:00
2008-10-08 16:29:57 -07:00
2009-07-05 19:16:04 -07:00
2005-04-16 15:20:36 -07:00
2009-04-16 02:20:16 -07:00
2009-11-06 20:26:10 -08:00
2009-11-23 14:18:53 -08:00
2009-10-14 15:13:45 -07:00
2009-09-03 20:02:11 -07:00
2009-10-01 14:34:40 -07:00
2007-10-19 11:53:42 -07:00
2009-09-03 20:02:11 -07:00
2009-07-05 19:16:04 -07:00
2009-09-11 12:54:49 -07:00
2009-04-16 02:20:21 -07:00
2009-07-05 19:16:04 -07:00
2008-08-29 02:13:32 -07:00
2009-09-03 20:02:11 -07:00
2008-11-28 15:55:00 -08:00
2009-05-03 14:19:23 -07:00
2009-05-01 15:21:55 -07:00
2009-01-11 00:06:36 -08:00
2009-07-08 10:30:03 -07:00
2009-05-01 15:24:18 -07:00
2009-07-05 19:16:04 -07:00
2009-09-21 15:14:58 +02:00
2008-03-26 00:18:00 -04:00
2009-09-01 01:14:07 -07:00
2006-09-13 13:24:59 -04:00
2009-07-05 19:16:04 -07:00
2005-04-16 15:20:36 -07:00
2009-10-21 17:21:10 -07:00
2009-06-12 18:01:45 +02:00
2009-10-11 11:20:58 -07:00
2009-10-07 03:37:43 -07:00
2009-04-27 03:20:17 -07:00
2009-04-27 02:53:49 -07:00
2009-09-03 20:02:11 -07:00
2009-10-11 11:20:58 -07:00
2009-07-16 20:21:24 -07:00
2009-07-16 09:14:23 -07:00
2008-01-28 15:11:27 -08:00
2009-11-16 23:51:34 -08:00
2008-08-14 04:26:38 -04:00
2005-11-08 09:40:47 -08:00
2009-07-16 09:14:23 -07:00
2009-10-26 16:23:20 -07:00
2009-09-30 16:12:20 -07:00
2009-01-21 15:55:15 -08:00
2009-09-02 01:03:33 -07:00
2008-06-03 15:00:14 -04:00
2009-09-02 01:03:33 -07:00
2008-11-10 15:11:56 -05:00
2009-09-01 01:14:07 -07:00
2008-08-07 02:11:14 -04:00
2009-11-15 21:14:59 -08:00
2009-11-29 23:12:52 -08:00
2009-09-21 15:14:54 +02:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-04-29 17:32:34 -07:00
2009-11-13 19:56:53 -08:00
2009-08-30 22:35:11 -07:00
2009-08-02 12:20:40 -07:00
2009-10-11 11:20:58 -07:00
2009-07-23 18:01:07 -07:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2006-09-13 13:24:59 -04:00
2009-10-01 14:34:43 -07:00
2006-09-13 13:24:59 -04:00
2009-10-26 17:19:44 -07:00
2009-08-29 00:19:35 -07:00
2009-09-01 01:14:07 -07:00
2009-10-11 11:20:58 -07:00
2006-09-13 13:24:59 -04:00
2009-10-11 11:20:58 -07:00
2009-10-01 15:14:54 -07:00
2010-03-15 08:49:39 -07:00
2009-10-01 15:14:55 -07:00
2008-01-28 15:11:27 -08:00
2009-10-11 11:20:58 -07:00
2009-01-06 11:28:06 +01:00
2009-11-29 23:47:14 -08:00
2009-09-17 20:53:52 -07:00
2009-07-05 19:16:04 -07:00
2009-08-12 22:13:16 -07:00
2009-09-01 01:14:07 -07:00
2006-09-13 13:24:59 -04:00
2009-05-01 15:21:55 -07:00
2009-03-27 00:46:47 -07:00
2009-03-27 00:46:48 -07:00
2009-11-15 22:17:41 -08:00
2009-03-19 23:59:27 -07:00
2009-11-29 23:14:45 -08:00
2009-02-20 00:38:51 -08:00
2008-04-25 02:08:54 -04:00
2009-07-05 19:23:38 -07:00
2008-11-12 23:38:36 -08:00
2007-07-16 15:02:47 +02:00
2008-11-12 23:38:36 -08:00
2009-03-23 14:42:09 -07:00
2008-04-16 20:06:50 -04:00
2010-02-09 04:51:00 -08:00
2008-11-25 18:25:49 -08:00
2009-07-05 19:16:04 -07:00
2006-09-13 13:24:59 -04:00
2009-07-05 19:16:04 -07:00
2009-07-05 19:16:04 -07:00
2008-08-29 02:13:33 -07:00
2009-09-01 01:14:07 -07:00
2009-02-02 23:19:50 -08:00
2007-02-27 04:16:02 -05:00
2009-11-18 14:54:45 -08:00
2008-01-28 15:07:10 -08:00
2009-09-01 01:14:07 -07:00
2008-08-29 02:14:29 -07:00
2009-07-05 19:16:04 -07:00
2009-07-05 19:16:04 -07:00
2008-08-29 02:14:43 -07:00
2009-09-22 14:00:09 -07:00
2007-07-20 17:14:30 -07:00
2009-08-06 13:14:25 -07:00
2009-09-02 01:03:33 -07:00
2009-04-07 08:31:11 -07:00
2010-04-01 15:58:05 -07:00
2010-04-01 15:58:05 -07:00
2009-09-03 20:02:11 -07:00
2008-05-30 22:18:02 -04:00
2009-07-08 10:30:03 -07:00
2007-05-08 11:54:20 +10:00
2009-09-24 15:13:11 -07:00
2009-10-11 11:20:58 -07:00
2009-01-21 14:34:08 -08:00
2009-08-30 21:51:47 -07:00
2009-09-11 12:54:45 -07:00
2009-08-30 21:51:47 -07:00
2009-11-19 13:16:22 -08:00
2010-03-15 08:49:43 -07:00
2009-09-03 20:02:11 -07:00
2009-07-23 18:11:28 -07:00
2009-11-09 09:51:42 -08:00
2009-01-11 00:06:36 -08:00
2009-09-02 01:03:33 -07:00
2009-09-22 14:00:04 -07:00
2009-07-23 18:01:08 -07:00
2009-09-03 20:02:11 -07:00
2009-10-07 22:15:23 -07:00
2009-08-09 21:46:53 -07:00