John Stultz deb79fc7b5 FROMLIST: proc: Fix timerslack_ns CAP_SYS_NICE check when adjusting self ...

In changing from checking ptrace_may_access(p, PTRACE_MODE_ATTACH_FSCREDS)
to capable(CAP_SYS_NICE), I missed that ptrace_my_access succeeds
when p == current, but the CAP_SYS_NICE doesn't.

Thus while the previous commit was intended to loosen the needed
privledges to modify a processes timerslack, it needlessly restricted
a task modifying its own timerslack via the proc/<tid>/timerslack_ns
(which is permitted also via the PR_SET_TIMERSLACK method).

This patch corrects this by checking if p == current before checking
the CAP_SYS_NICE value.

Cc: Kees Cook <keescook@chromium.org>
Cc: "Serge E. Hallyn" <serge@hallyn.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
CC: Arjan van de Ven <arjan@linux.intel.com>
Cc: Oren Laadan <orenl@cellrox.com>
Cc: Ruchi Kandoi <kandoiruchi@google.com>
Cc: Rom Lemarchand <romlem@android.com>
Cc: Todd Kjos <tkjos@google.com>
Cc: Colin Cross <ccross@android.com>
Cc: Nick Kralevich <nnk@google.com>
Cc: Dmitry Shmidt <dimitrysh@google.com>
Cc: Elliott Hughes <enh@google.com>
Cc: Android Kernel Team <kernel-team@android.com>
Mailing-list-url: http://www.spinics.net/lists/kernel/msg2317488.html
Change-Id: Ia3e8aff07c2d41f55b6617502d33c39b7d781aac
Signed-off-by: John Stultz <john.stultz@linaro.org>

2016-08-18 18:56:03 +05:30

..

array.c

ptrace: use fsuid, fsgid, effective creds for fs access checks

2016-02-25 12:01:16 -08:00

base.c

FROMLIST: proc: Fix timerslack_ns CAP_SYS_NICE check when adjusting self

2016-08-18 18:56:03 +05:30

cmdline.c

fs/proc: don't use module_init for non-modular core code

2014-01-23 16:37:02 -08:00

consoles.c

fs/proc: don't use module_init for non-modular core code

2014-01-23 16:37:02 -08:00

cpuinfo.c

fs/proc: don't use module_init for non-modular core code

2014-01-23 16:37:02 -08:00

devices.c

fs/proc: don't use module_init for non-modular core code

2014-01-23 16:37:02 -08:00

fd.c

proc: actually make proc_fd_permission() thread-friendly

2015-11-06 17:50:42 -08:00

fd.h

proc: Move proc_fd() to fs/proc/fd.h

2013-05-01 17:29:39 -04:00

generic.c

proc: change proc_subdir_lock to a rwlock

2015-09-10 13:29:01 -07:00

inode.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace

2015-07-03 15:20:57 -07:00

internal.h

proc: Allow creating permanently empty directories that serve as mount points

2015-07-01 10:36:41 -05:00

interrupts.c

fs/proc: don't use module_init for non-modular core code

2014-01-23 16:37:02 -08:00

Kconfig

fs, proc: add help for CONFIG_PROC_CHILDREN

2015-07-17 16:39:52 -07:00

kcore.c

x86/fpu, sched: Introduce CONFIG_ARCH_WANTS_DYNAMIC_TASK_STRUCT and use it on x86

2015-07-18 03:42:51 +02:00

kmsg.c

fs/proc: don't use module_init for non-modular core code

2014-01-23 16:37:02 -08:00

loadavg.c

fs/proc: don't use module_init for non-modular core code

2014-01-23 16:37:02 -08:00

Makefile

proc: Implement /proc/thread-self to point at the directory of the current thread

2014-08-04 10:07:11 -07:00

meminfo.c

mm: get rid of 'vmalloc_info' from /proc/meminfo

2015-11-01 17:09:15 -08:00

namespaces.c

ptrace: use fsuid, fsgid, effective creds for fs access checks

2016-02-25 12:01:16 -08:00

nommu.c

vfs: add seq_file_path() helper

2015-06-23 18:01:07 -04:00

page.c

proc: add cond_resched to /proc/kpage* read/write loop

2015-09-10 13:29:01 -07:00

proc_net.c

VFS: normal filesystems (and lustre): d_inode() annotations

2015-04-15 15:06:57 -04:00

proc_sysctl.c

fs: Drop unlikely before IS_ERR(_OR_NULL)

2015-09-29 15:13:58 +02:00

proc_tty.c

proc: remove proc_tty_ldisc variable

2014-08-08 15:57:22 -07:00

root.c

proc: prevent stacking filesystems on top

2016-06-24 10:18:20 -07:00

self.c

don't pass nameidata to ->follow_link()

2015-05-10 22:20:15 -04:00

softirqs.c

fs/proc: don't use module_init for non-modular core code

2014-01-23 16:37:02 -08:00

stat.c

genirq: Prevent proc race against freeing of irq descriptors

2014-12-13 13:33:07 +01:00

task_mmu.c

Merge branch 'linux-linaro-lsk-v4.4' into linux-linaro-lsk-v4.4-android

2016-05-12 09:27:18 +08:00

task_nommu.c

vfs: add seq_file_path() helper

2015-06-23 18:01:07 -04:00

thread_self.c

don't pass nameidata to ->follow_link()

2015-05-10 22:20:15 -04:00

uptime.c

cputime: Default implementation of nsecs -> cputime conversion

2014-03-13 15:56:43 +01:00

version.c

fs/proc: don't use module_init for non-modular core code

2014-01-23 16:37:02 -08:00

vmcore.c

vmcore: fix PT_NOTE n_namesz, n_descsz overflow issue

2015-02-17 14:34:52 -08:00