Radu Rendec e89aa81835 powerpc/msi: Fix NULL pointer access in teardown code ...

commit 78e7b15e17 upstream.

The arch_teardown_msi_irqs() function assumes that controller ops
pointers were already checked in arch_setup_msi_irqs(), but this
assumption is wrong: arch_teardown_msi_irqs() can be called even when
arch_setup_msi_irqs() returns an error (-ENOSYS).

This can happen in the following scenario:
  - msi_capability_init() calls pci_msi_setup_msi_irqs()
  - pci_msi_setup_msi_irqs() returns -ENOSYS
  - msi_capability_init() notices the error and calls free_msi_irqs()
  - free_msi_irqs() calls pci_msi_teardown_msi_irqs()

This is easier to see when CONFIG_PCI_MSI_IRQ_DOMAIN is not set and
pci_msi_setup_msi_irqs() and pci_msi_teardown_msi_irqs() are just
aliases to arch_setup_msi_irqs() and arch_teardown_msi_irqs().

The call to free_msi_irqs() upon pci_msi_setup_msi_irqs() failure
seems legit, as it does additional cleanup; e.g.
list_del(&entry->list) and kfree(entry) inside free_msi_irqs() do
happen (MSI descriptors are allocated before pci_msi_setup_msi_irqs()
is called and need to be cleaned up if that fails).

Fixes: 6b2fd7efeb ("PCI/MSI/PPC: Remove arch_msi_check_device()")
Cc: stable@vger.kernel.org # v3.18+
Signed-off-by: Radu Rendec <radu.rendec@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-12-21 14:13:06 +01:00

..

trace

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

vdso32

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

vdso64

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

.gitignore

powerpc: Ignore generated vmlinux.lds in git

2008-10-07 14:26:18 +11:00

align.c

powerpc: Fix check for copy/paste instructions in alignment handler

2017-10-25 12:42:35 +02:00

asm-offsets.c

powerpc/64s: Improve RFI L1-D cache flush fallback

2018-05-30 07:51:50 +02:00

audit.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

btext.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

cacheinfo.c

powerpc: Convert to using %pOF instead of full_name

2017-08-23 22:27:04 +10:00

cacheinfo.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

compat_audit.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

cpu_setup_6xx.S

powerpc: Various typo fixes

2016-06-14 13:58:26 +10:00

cpu_setup_44x.S

powerpc/44x: Add support for the AMCC APM821xx SoC

2010-10-13 08:47:09 -04:00

cpu_setup_fsl_booke.S

powerpc/cache: add cache flush operation for various e500

2016-03-04 23:44:51 -06:00

cpu_setup_pa6t.S

[POWERPC] pasemi: Enable one more hid bit

2007-04-24 21:31:49 +10:00

cpu_setup_power.S

powerpc/64s: Clear PCR on boot

2018-05-30 07:51:49 +02:00

cpu_setup_ppc970.S

powerpc, KVM: Split HVMODE_206 cpu feature bit into separate HV and architecture bits

2011-07-12 13:16:58 +03:00

cputable.c

powerpc/8xx: Use symbolic PVR value

2017-08-10 23:32:18 +10:00

crash_dump.c

Replace <asm/uaccess.h> with <linux/uaccess.h> globally

2016-12-24 11:46:01 -08:00

crash.c

powerpc/fadump: remove dependency with CONFIG_KEXEC

2017-05-08 17:15:11 -07:00

dbell.c

powerpc: Introduce msgsnd/doorbell barrier primitives

2017-04-13 23:34:33 +10:00

dma-iommu.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

dma-swiotlb.c

treewide: Constify most dma_map_ops structures

2017-01-24 12:23:35 -05:00

dma.c

powerpc: merge __dma_set_mask into dma_set_mask

2017-06-28 06:54:55 -07:00

dt_cpu_ftrs.c

powerpc/64s: Clear PCR on boot

2018-05-30 07:51:49 +02:00

eeh_cache.c

powerpc/eeh: Fix pr_debug()s in eeh_cache.c

2016-07-08 22:09:50 +10:00

eeh_dev.c

powerpc/eeh: Create PHB PEs after EEH is initialized

2017-09-21 14:56:00 +10:00

eeh_driver.c

powerpc/eeh: Fix use-after-release of EEH driver

2018-08-03 07:50:24 +02:00

eeh_event.c

powerpc/pci: Always print PHB and PE numbers as hexadecimal

2016-11-22 11:57:07 +11:00

eeh_pe.c

powerpc/eeh: Fix enabling bridge MMIO windows

2018-04-24 09:36:37 +02:00

eeh_sysfs.c

powerpc/eeh: Remove unnecessary config_addr from eeh_dev

2017-08-31 14:26:09 +10:00

eeh.c

powerpc/eeh: Fix possible null deref in eeh_dump_dev_log()

2018-11-21 09:24:03 +01:00

entry_32.S

powerpc/32: Avoid risk of unrecoverable TLBmiss inside entry_32.S

2017-08-15 22:55:53 +10:00

entry_64.S

powerpc/mm/hash: Add missing isync prior to kernel stack SLB switch

2018-07-03 11:24:50 +02:00

epapr_hcalls.S

ppc: move exports to definitions

2016-08-07 23:50:09 -04:00

epapr_paravirt.c

Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc

2014-06-10 18:54:22 -07:00

exceptions-64e.S

powerpc/64e: Fix hang when debugging programs with relocated kernel

2017-04-30 01:05:18 -05:00

exceptions-64s.S

powerpc/64s: Make rfi_flush_fallback a little more robust

2018-09-15 09:45:32 +02:00

fadump.c

powerpc/fadump: handle crash memory ranges array index overflow

2018-09-09 19:55:54 +02:00

firmware.c

powerpc: fix implicit use of cache.h in kernel/firmware.c

2011-10-31 19:30:41 -04:00

fpu.S

Merge branch 'kbuild' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild

2016-10-14 14:26:58 -07:00

fsl_booke_entry_mapping.S

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

head_8xx.S

powerpc/8xx: fix invalid register expression in head_8xx.S

2018-08-03 07:50:31 +02:00

head_32.S

powerpc: Fix DABR match on hash based systems

2018-02-22 15:42:17 +01:00

head_40x.S

ppc: move exports to definitions

2016-08-07 23:50:09 -04:00

head_44x.S

ppc: move exports to definitions

2016-08-07 23:50:09 -04:00

head_64.S

powerpc/asm: Convert .llong directives to .8byte

2017-08-31 14:26:47 +10:00

head_booke.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

head_fsl_booke.S

ppc: move exports to definitions

2016-08-07 23:50:09 -04:00

hw_breakpoint.c

powerpc/ptrace: Fix enforcement of DAWR constraints

2018-07-03 11:24:50 +02:00

idle_6xx.S

powerpc: Use CURRENT_THREAD_INFO instead of open coded assembly

2012-07-11 14:18:22 +10:00

idle_book3e.S

powerpc: No need to use dot symbols when branching to a function

2014-04-23 10:05:16 +10:00

idle_book3s.S

powerpc/powernv: Fix save/restore of SPRG3 on entry/exit from stop (idle)

2018-07-25 11:25:11 +02:00

idle_e500.S

powerpc/e500mc: Remove dead L2 flushing code in idle_e500.S

2015-06-02 21:37:19 -05:00

idle_power4.S

powerpc: No need to use dot symbols when branching to a function

2014-04-23 10:05:16 +10:00

idle.c

powerpc/idle: Convert use of typedef ctl_table to struct ctl_table

2013-07-01 11:10:35 +10:00

ima_kexec.c

powerpc: ima: send the kexec buffer to the next kernel

2016-12-20 09:48:44 -08:00

io-workarounds.c

powerpc: Convert to using %pOF instead of full_name

2017-08-23 22:27:04 +10:00

io.c

powerpc/powernv: Add PIO accessors for Power8 LPC bus

2013-08-14 14:58:08 +10:00

iomap.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

iommu.c

powerpc/iommu: Use permission-specific DEVICE_ATTR variants

2017-09-01 16:42:54 +10:00

irq.c

powerpc/64s: Fix lost pending interrupt due to race causing lost update to irq_happened

2018-04-08 14:26:27 +02:00

isa-bridge.c

powerpc: Convert to using %pOF instead of full_name

2017-08-23 22:27:04 +10:00

jump_label.c

jump_label: Rename JUMP_LABEL_{EN,DIS}ABLE to JUMP_LABEL_{JMP,NOP}

2015-08-03 11:34:12 +02:00

kexec_elf_64.c

powerpc: ima: send the kexec buffer to the next kernel

2016-12-20 09:48:44 -08:00

kgdb.c

powerpc/8xx: Getting rid of remaining use of CONFIG_8xx

2017-08-10 23:32:12 +10:00

kprobes-ftrace.c

powerpc/jprobes: Disable preemption when triggered through ftrace

2017-12-10 13:40:43 +01:00

kprobes.c

powerpc/kprobes: Fix call trace due to incorrect preempt count

2018-04-24 09:36:28 +02:00

kvm_emul.S

KVM: PPC: Not optimizing MSR_CE and MSR_ME with paravirt.

2012-05-30 11:43:11 +02:00

kvm.c

powerpc/64: Fix watchdog configuration regressions

2017-08-31 14:26:00 +10:00

l2cr_6xx.S

powerpc/l2cr_6xx: Fix invalid use of register expressions

2017-08-15 21:04:32 +10:00

legacy_serial.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

machine_kexec_32.c

treewide: convert uses of ATTRIB_NORETURN to __noreturn

2012-01-12 20:13:03 -08:00

machine_kexec_64.c

powerpc: Add purgatory for kexec_file_load() implementation.

2016-11-30 23:15:26 +11:00

machine_kexec_file_64.c

powerpc/kexec_file: Fix error code when trying to load kdump kernel

2018-04-24 09:36:28 +02:00

machine_kexec.c

powerpc/kdump: Handle crashkernel memory reservation failure

2018-10-03 17:00:48 -07:00

Makefile

powerpc: Add security feature flags for Spectre/Meltdown

2018-05-30 07:51:51 +02:00

mce_power.c

powerpc: Fix workaround for spurious MCE on POWER9

2017-09-29 14:19:44 +10:00

mce.c

powerpc/mce: Move 64-bit machine check code into mce.c

2017-08-10 23:31:31 +10:00

misc_32.S

powerpc/40x: Clear MSR_DR in one insn instead of two

2017-06-02 19:20:43 +10:00

misc_64.S

powerpc/kexec: Fix kexec/kdump in P9 guest kernels

2017-12-05 11:26:31 +01:00

misc.S

ppc: move exports to definitions

2016-08-07 23:50:09 -04:00

module_32.c

powerpc/module: Only try to generate the ftrace_caller() stub once

2016-03-07 14:53:53 +11:00

module_64.c

powerpc/64/module: REL32 relocation range check

2018-11-21 09:24:02 +01:00

module.c

Replace <asm/uaccess.h> with <linux/uaccess.h> globally

2016-12-24 11:46:01 -08:00

msi.c

powerpc/msi: Fix NULL pointer access in teardown code

2018-12-21 14:13:06 +01:00

nvram_64.c

powerpc/nvram: use memdup_user

2017-06-27 17:02:50 -07:00

of_platform.c

powerpc: Convert to using %pOF instead of full_name

2017-08-23 22:27:04 +10:00

optprobes_head.S

powerpc/kprobes: Don't save/restore DAR/DSISR to/from pt_regs for optprobes

2017-08-24 16:19:01 +10:00

optprobes.c

powerpc/kprobes: Disable preemption before invoking probe handler for optprobes

2017-12-10 13:40:43 +01:00

paca.c

treewide: make "nr_cpu_ids" unsigned

2017-09-08 18:26:48 -07:00

pci_32.c

powerpc/32: Add a missing include header

2018-08-03 07:50:30 +02:00

pci_64.c

powerpc: Convert to using %pOF instead of full_name

2017-08-23 22:27:04 +10:00

pci_dn.c

powerpc/pci: Remove OF node back pointer from pci_dn

2017-08-31 14:26:12 +10:00

pci_of_scan.c

powerpc: Convert to using %pOF instead of full_name

2017-08-23 22:27:04 +10:00

pci-common.c

powerpc: Convert to using %pOF instead of full_name

2017-08-23 22:27:04 +10:00

pci-hotplug.c

powerpc/pci: Don't scan empty slot

2016-05-11 21:54:26 +10:00

pmc.c

bug.h: add include of it to various implicit C users

2012-02-29 17:15:08 -05:00

ppc32.h

powerpc: switch to generic old sigaction()

2013-02-03 18:16:10 -05:00

ppc_save_regs.S

Fix common misspellings

2011-03-31 11:26:23 -03:00

proc_powerpc.c

Replace <asm/uaccess.h> with <linux/uaccess.h> globally

2016-12-24 11:46:01 -08:00

process.c

powerpc/oops: Line up NIP & MSR with other rows

2017-08-28 22:10:00 +10:00

prom_init_check.sh

powerpc: Simplify symbol check in prom_init_check.sh

2014-09-25 23:14:46 +10:00

prom_init.c

powerpc: Add __printf verification to prom_printf

2018-08-03 07:50:30 +02:00

prom_parse.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

prom.c

powerpc: Fix booting P9 hash with CONFIG_PPC_RADIX_MMU=N

2017-05-25 23:07:44 +10:00

ptrace32.c

Replace <asm/uaccess.h> with <linux/uaccess.h> globally

2016-12-24 11:46:01 -08:00

ptrace.c

powerpc/ptrace: Fix setting 512B aligned breakpoints with PTRACE_SET_DEBUGREG

2018-07-03 11:24:50 +02:00

reloc_32.S

powerpc: Don't flush/invalidate the d/icache for an unknown relocation type

2013-07-01 11:10:34 +10:00

reloc_64.S

powerpc/asm: Convert .llong directives to .8byte

2017-08-31 14:26:47 +10:00

rtas_flash.c

Replace <asm/uaccess.h> with <linux/uaccess.h> globally

2016-12-24 11:46:01 -08:00

rtas_pci.c

powerpc/kernel: Change retrieval of pci_dn

2017-08-31 14:26:40 +10:00

rtas-proc.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

rtas-rtc.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

rtas.c

mm: treewide: remove GFP_TEMPORARY allocation flag

2017-09-13 18:53:16 -07:00

rtasd.c

powerpc: Only obtain cpu_hotplug_lock if called by rtasd

2017-06-23 09:32:11 +02:00

security.c

powerpc/64s: Add support for a store forwarding barrier at kernel entry/exit

2018-05-30 07:51:54 +02:00

setup_32.c

powerpc/32: remove a NOP from memset()

2017-09-01 16:42:46 +10:00

setup_64.c

powerpc/64s: Fix section mismatch warnings from setup_rfi_flush()

2018-05-30 07:51:53 +02:00

setup-common.c

powerpc/mm/slice: Fix hugepage allocation at hint address on 8xx

2018-06-05 11:42:00 +02:00

setup.h

powerpc: Merge 32-bit and 64-bit setup_arch()

2016-07-21 19:17:46 +10:00

signal_32.c

signal: Remove kernel interal si_code magic

2017-07-24 14:30:28 -05:00

signal_64.c

powerpc/tm: Fix illegal TM state in signal handler

2017-10-06 22:12:55 +11:00

signal.c

powerpc/signal: Properly handle return value from uprobe_deny_signal()

2017-11-30 08:40:56 +00:00

signal.h

powerpc: tm: Rename transct_(*) to ck(\1)_state

2016-10-04 20:33:16 +11:00

smp-tbsync.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

smp.c

powerpc/smp: Add Power9 scheduler topology

2017-08-31 18:16:08 +10:00

stacktrace.c

powerpc: Make /proc/self/stack always print the current stack

2017-03-28 14:43:59 +11:00

suspend.c

nosave: consolidate __nosave_{begin,end} in <asm/sections.h>

2014-10-09 22:26:04 -04:00

swsusp_32.S

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

swsusp_64.c

sched/headers: Prepare for new header dependencies before moving code to <linux/sched/nmi.h>

2017-03-02 08:42:30 +01:00

swsusp_asm64.S

powerpc: Fix invalid use of register expressions

2017-08-10 22:29:41 +10:00

swsusp_booke.S

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

swsusp.c

powerpc/swsusp: Include suspend.h to silence sparse warnings

2017-03-20 19:02:49 +11:00

sys_ppc32.c

Replace <asm/uaccess.h> with <linux/uaccess.h> globally

2016-12-24 11:46:01 -08:00

syscalls.c

powerpc/tracing: Allow tracing of mmap syscalls

2017-04-12 22:32:43 +10:00

sysfs.c

powerpc/sysfs: Move #ifdef CONFIG_HOTPLUG_CPU out of the function body

2017-05-03 14:45:38 +10:00

systbl_chk.c

powerpc: Standardise on NR_syscalls rather than __NR_syscalls.

2015-11-26 22:11:17 +11:00

systbl_chk.sh

powerpc: Standardise on NR_syscalls rather than __NR_syscalls.

2015-11-26 22:11:17 +11:00

systbl.S

powerpc/asm: Convert .llong directives to .8byte

2017-08-31 14:26:47 +10:00

tau_6xx.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

time.c

powerpc: use spin loop primitives in some functions

2017-07-02 20:40:24 +10:00

tm.S

powerpc/tm: Avoid possible userspace r1 corruption on reclaim

2018-10-20 09:48:52 +02:00

traps.c

powerpc/traps: restore recoverability of machine_check interrupts

2018-11-21 09:24:02 +01:00

udbg_16550.c

powerpc: Fix bad NULL pointer check in udbg_uart_getc_poll()

2014-11-12 13:47:20 +11:00

udbg.c

powerpc: Remove the celleb support

2015-04-07 17:15:13 +10:00

uprobes.c

powerpc/uprobes: Implement arch_uretprobe_is_alive()

2017-08-24 16:19:21 +10:00

vdso.c

powerpc/64: Clean up ppc64_caches using a struct per cache

2017-02-06 19:46:04 +11:00

vecemu.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

vector.S

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

vmlinux.lds.S

powerpc/64s: Add support for a store forwarding barrier at kernel entry/exit

2018-05-30 07:51:54 +02:00

watchdog.c

powerpc/watchdog: Do not trigger SMP crash from touch_nmi_watchdog

2017-12-25 14:26:28 +01:00