Haiyang Zhang
ca58927b00
net: mana: Fix Rx DMA datasize and skb_over_panic
...
commit c0de6ab920aafb56feab56058e46b688e694a246 upstream.
mana_get_rxbuf_cfg() aligns the RX buffer's DMA datasize to be
multiple of 64. So a packet slightly bigger than mtu+14, say 1536,
can be received and cause skb_over_panic.
Sample dmesg:
[ 5325.237162] skbuff: skb_over_panic: text:ffffffffc043277a len:1536 put:1536 head:ff1100018b517000 data:ff1100018b517100 tail:0x700 end:0x6ea dev:<NULL>
[ 5325.243689] ------------[ cut here ]------------
[ 5325.245748] kernel BUG at net/core/skbuff.c:192!
[ 5325.247838] invalid opcode: 0000 [#1 ] PREEMPT SMP NOPTI
[ 5325.258374] RIP: 0010:skb_panic+0x4f/0x60
[ 5325.302941] Call Trace:
[ 5325.304389] <IRQ>
[ 5325.315794] ? skb_panic+0x4f/0x60
[ 5325.317457] ? asm_exc_invalid_op+0x1f/0x30
[ 5325.319490] ? skb_panic+0x4f/0x60
[ 5325.321161] skb_put+0x4e/0x50
[ 5325.322670] mana_poll+0x6fa/0xb50 [mana]
[ 5325.324578] __napi_poll+0x33/0x1e0
[ 5325.326328] net_rx_action+0x12e/0x280
As discussed internally, this alignment is not necessary. To fix
this bug, remove it from the code. So oversized packets will be
marked as CQE_RX_TRUNCATED by NIC, and dropped.
Cc: stable@vger.kernel.org
Fixes: 2fbbd712ba ("net: mana: Enable RX path to handle various MTU sizes")
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Reviewed-by: Dexuan Cui <decui@microsoft.com >
Link: https://lore.kernel.org/r/1712087316-20886-1-git-send-email-haiyangz@microsoft.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-04-10 16:35:49 +02:00
..
2023-03-27 02:33:48 +00:00
2024-04-10 16:35:48 +02:00
2023-08-10 18:24:48 -07:00
2021-11-19 11:52:25 +00:00
2024-04-10 16:35:49 +02:00
2024-03-01 13:35:09 +01:00
2023-09-13 09:20:28 +02:00
2021-11-17 20:17:05 -08:00
2023-10-04 14:22:27 -07:00
2023-06-15 22:33:26 -07:00
2023-08-10 19:31:52 -07:00
2023-11-28 17:19:54 +00:00
2020-02-28 14:51:30 +01:00
2023-02-20 16:46:10 -08:00
2023-12-20 17:01:45 +01:00
2019-05-30 11:26:41 -07:00
2023-05-01 07:43:19 +01:00
2024-02-05 20:14:37 +00:00
2024-01-25 15:35:26 -08:00
2022-07-22 12:53:22 +01:00
2023-03-21 21:32:18 -07:00
2023-03-18 12:23:34 +00:00
2022-08-09 22:14:02 -07:00
2021-12-13 12:34:09 +00:00
2023-07-28 18:06:30 -07:00
2022-11-02 20:38:13 -07:00
2022-07-22 12:53:22 +01:00
2023-08-24 10:07:13 +02:00
2021-03-26 17:43:55 +01:00
2023-08-03 08:38:07 -07:00
2019-05-21 11:28:45 +02:00
2022-11-16 11:31:47 +02:00
2024-04-03 15:28:54 +02:00
2024-04-03 15:28:27 +02:00
2023-01-27 11:19:46 +00:00
2020-07-15 07:45:24 -07:00
2020-03-27 19:40:38 -07:00
2021-12-22 15:03:47 -08:00
2022-07-22 12:53:22 +01:00
2023-07-14 20:39:29 -07:00
2022-07-24 18:39:17 -06:00
2023-07-27 17:17:32 -07:00
2022-07-22 12:53:22 +01:00
2023-01-20 09:33:22 +00:00
2023-08-27 17:08:45 -07:00
2023-08-19 15:30:15 +01:00
2023-08-14 08:01:06 +01:00
2023-04-09 15:35:49 +01:00
2023-07-18 09:47:08 +02:00
2019-12-16 16:09:44 -08:00
2021-11-29 19:50:45 -08:00
2022-12-05 21:58:27 -08:00
2023-08-22 13:19:02 +02:00
2023-03-28 18:52:28 -07:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2020-04-20 07:34:16 +02:00
2022-07-22 12:53:22 +01:00
2021-12-06 16:06:02 -08:00
2019-12-24 22:37:30 -08:00
2021-12-16 07:18:35 -08:00
2022-07-28 22:21:54 -07:00
2023-08-02 10:09:31 +01:00
2023-08-02 10:09:32 +01:00
2023-11-20 11:59:34 +01:00
2023-04-12 16:40:39 -07:00
2022-12-01 15:09:10 +01:00
2023-08-08 15:58:23 -07:00
2022-07-22 12:53:22 +01:00
2021-10-18 12:54:41 +01:00
2023-12-13 18:45:10 +01:00
2022-10-31 10:43:04 +00:00
2021-01-29 20:39:14 -08:00
2023-07-29 17:10:27 +01:00
2023-06-10 00:11:41 -07:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2023-07-28 14:07:59 -07:00
2022-07-22 12:53:22 +01:00
2021-06-28 14:29:45 -07:00
2023-08-22 21:40:40 +02:00
2023-03-23 21:51:30 +01:00
2023-12-20 17:01:45 +01:00
2019-04-22 21:50:53 -07:00
2022-07-22 12:53:22 +01:00
2023-08-15 13:57:51 -07:00
2023-08-14 07:06:13 +01:00
2024-04-10 16:35:42 +02:00
2022-02-07 20:12:45 -08:00
2021-10-15 11:33:08 +01:00
2023-07-14 20:39:29 -07:00
2023-08-15 13:57:51 -07:00
2024-01-31 16:19:01 -08:00
2022-12-30 07:25:52 +00:00
2019-02-08 21:50:15 -08:00
2022-02-17 07:00:39 -06:00
2021-11-16 13:16:54 +00:00
2024-01-01 12:42:33 +00:00
2023-07-28 11:01:56 +01:00
2022-04-25 11:40:45 +01:00
2023-10-03 09:00:40 +02:00
2023-09-06 06:05:59 +01:00
2023-04-22 01:39:41 +02:00
2024-02-05 20:14:35 +00:00
2022-09-29 07:18:00 +02:00
2022-07-22 12:53:22 +01:00
2022-10-31 20:14:27 -07:00
2024-03-01 13:35:04 +01:00
2023-09-13 07:18:04 +01:00
2023-08-22 21:40:40 +02:00
2023-06-12 21:13:23 -07:00
2020-06-20 17:22:22 -07:00
2018-07-11 23:10:19 -07:00
2021-03-23 14:14:50 -07:00
2023-08-04 15:33:17 -07:00
2023-08-04 15:33:17 -07:00
2022-07-22 12:53:22 +01:00
2023-07-20 10:46:28 +02:00
2021-10-13 09:40:46 -07:00
2024-01-31 16:19:01 -08:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2022-07-28 11:29:36 +02:00
2021-11-07 19:25:29 +00:00
2023-08-18 16:05:26 +02:00
2023-08-25 18:35:09 -07:00
2022-10-12 12:57:19 +02:00
2023-10-10 10:30:30 +02:00
2024-03-06 14:48:34 +00:00
2021-10-29 13:23:51 +01:00
2020-03-02 11:16:27 -08:00
2021-03-26 15:14:56 -07:00
2022-07-22 12:53:22 +01:00
2020-05-29 21:20:20 -07:00
2023-08-22 17:31:18 -07:00
2022-11-18 12:14:55 +00:00
2022-07-22 12:53:22 +01:00
2023-08-07 08:53:55 +01:00
2023-12-08 08:52:23 +01:00
2022-05-11 12:43:10 +01:00
2018-05-28 22:59:54 -04:00
2023-08-29 17:39:15 -07:00
2021-12-10 06:38:26 -08:00
2024-01-25 15:35:57 -08:00
2023-08-03 08:38:07 -07:00
2022-07-22 12:53:22 +01:00
2019-05-21 11:28:45 +02:00
2023-07-27 13:45:51 +02:00
2019-11-12 08:18:03 -08:00
2022-07-22 12:53:22 +01:00
2023-05-11 18:07:05 -07:00
2023-01-28 13:51:22 +01:00
2023-07-14 20:39:29 -07:00
2023-08-04 15:33:50 -07:00
2023-07-14 20:39:30 -07:00
2023-06-02 09:55:22 +01:00
2023-08-07 08:53:54 +01:00
2023-07-12 15:59:33 -07:00
2022-07-22 12:53:22 +01:00
2022-07-15 18:50:35 -07:00
2021-08-09 15:34:21 -07:00
2022-07-22 12:53:22 +01:00
2023-04-06 12:01:20 -07:00
2023-03-17 08:56:37 +00:00
2022-10-11 17:42:58 -06:00
2023-06-19 12:05:29 +02:00
2022-02-02 14:45:18 +00:00
2022-08-01 11:59:23 -07:00
2023-08-16 11:09:17 +01:00
2023-06-19 11:32:58 -07:00
2023-07-14 20:39:30 -07:00
2023-08-20 11:40:03 +01:00
2019-04-22 21:47:25 -07:00
2024-01-31 16:19:02 -08:00
2023-09-04 11:00:17 +01:00
2022-07-22 12:53:22 +01:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2022-01-04 12:17:35 +00:00
2021-04-28 14:06:45 -07:00
2023-03-15 08:18:35 +00:00
2019-10-05 16:29:00 -07:00
2022-10-25 11:35:16 +02:00
2024-04-10 16:35:42 +02:00
2023-08-03 18:10:10 -07:00
2022-07-22 12:53:22 +01:00
2022-07-18 11:24:10 +01:00
2024-03-01 13:35:06 +01:00
2023-02-16 09:27:07 +01:00
2019-05-30 11:26:32 -07:00
2024-03-01 13:35:02 +01:00
2023-07-19 10:07:27 -07:00
2019-05-30 11:26:32 -07:00
2018-05-08 00:02:41 -04:00
2023-07-28 14:07:59 -07:00
2019-10-04 14:07:07 -07:00
2024-02-23 09:24:52 +01:00
2023-08-01 15:06:27 -07:00
2022-12-12 15:04:39 -08:00
2022-07-22 12:53:22 +01:00
2023-11-20 11:58:56 +01:00
2023-08-07 08:53:55 +01:00
2023-11-20 11:58:56 +01:00
2019-11-14 18:12:17 -08:00
2023-08-02 10:58:26 +01:00
2023-03-18 12:23:34 +00:00
2022-07-22 12:53:22 +01:00
2024-01-31 16:19:04 -08:00
2024-01-10 17:16:54 +01:00
2023-08-03 08:38:07 -07:00
2023-08-01 12:04:43 +02:00
2023-07-19 09:56:49 -07:00