Jason Gerecke 34808d76dd HID: wacom: Have wacom_tpc_irq guard against possible NULL dereference ...

commit 2ac97f0f66 upstream.

The following Smatch complaint was generated in response to commit
2a6cdbd ("HID: wacom: Introduce new 'touch_input' device"):

    drivers/hid/wacom_wac.c:1586 wacom_tpc_irq()
             error: we previously assumed 'wacom->touch_input' could be null (see line 1577)

The 'touch_input' and 'pen_input' variables point to the 'struct input_dev'
used for relaying touch and pen events to userspace, respectively. If a
device does not have a touch interface or pen interface, the associated
input variable is NULL. The 'wacom_tpc_irq()' function is responsible for
forwarding input reports to a more-specific IRQ handler function. An
unknown report could theoretically be mistaken as e.g. a touch report
on a device which does not have a touch interface. This can be prevented
by only calling the pen/touch functions are called when the pen/touch
pointers are valid.

Fixes: 2a6cdbd ("HID: wacom: Introduce new 'touch_input' device")
Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Reviewed-by: Ping Cheng <ping.cheng@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2017-06-07 12:07:47 +02:00

..

i2c-hid

HID: i2c-hid: add a simple quirk to fix device defects

2017-04-12 12:41:15 +02:00

intel-ish-hid

HID: intel-ish-hid: request_irq failure

2016-11-05 15:57:38 +01:00

usbhid

HID: usbhid: Add quirk for Mayflash/Dragonrise DolphinBar.

2017-04-12 12:41:18 +02:00

hid-a4tech.c

HID: trivial devm conversion for special hid drivers

2013-07-31 10:12:28 +02:00

hid-alps.c

Merge branches 'for-4.8/upstream-fixes', 'for-4.9/alps', 'for-4.9/hid-input', 'for-4.9/intel-ish', 'for-4.9/kye-uclogic-waltop-fixes', 'for-4.9/logitech', 'for-4.9/sony', 'for-4.9/upstream' and 'for-4.9/wacom' into for-linus

2016-10-07 09:59:48 +02:00

hid-apple.c

HID: add usb device id for Apple Magic Keyboard

2016-07-11 17:41:31 +02:00

hid-appleir.c

HID: hid-input: allow input_configured callback return errors

2015-11-05 09:51:50 -08:00

hid-asus.c

HID: asus: add support for VivoBook E200HA

2016-04-04 09:59:21 +02:00

hid-aureal.c

HID: fix some indenting issues

2015-10-21 13:15:53 +02:00

hid-axff.c

HID: enable Mayflash USB Gamecube Adapter

2013-11-12 19:06:23 +01:00

hid-belkin.c

HID: Use module_hid_driver macro

2013-01-03 10:27:31 +01:00

hid-betopff.c

HID: betop: add drivers/hid/hid-betopff.c

2014-12-22 15:00:25 +01:00

hid-cherry.c

HID: fix a couple of off-by-ones

2014-08-21 10:43:28 -05:00

hid-chicony.c

HID: chicony: Add support for Acer Aspire Switch 12

2015-07-29 14:12:26 +02:00

hid-cmedia.c

HID: Support for CMedia CM6533 HID audio jack controls

2016-03-02 10:31:36 +01:00

hid-core.c

HID: multitouch: enable the Surface 3 Type Cover to report multitouch data

2017-04-12 12:41:16 +02:00

hid-corsair.c

HID: corsair: fix control-transfer error handling

2017-01-26 08:24:38 +01:00

hid-cp2112.c

HID: cp2112: fix gpio-callback error handling

2017-02-09 08:08:25 +01:00

hid-cypress.c

HID: hid-cypress: validate length of report

2017-01-15 13:42:56 +01:00

hid-debug.c

HID: debug: improve hid_debug_event()

2015-11-27 00:02:59 +01:00

hid-dr.c

Revert "HID: dragonrise: fix HID Descriptor for 0x0006 PID"

2016-10-10 10:52:01 +02:00

hid-elecom.c

HID: fix some indenting issues

2015-10-21 13:15:53 +02:00

hid-elo.c

HID: elo: kill not flush the work

2016-06-01 14:08:17 +02:00

hid-emsff.c

HID: use hid_hw_request() instead of direct call to usbhid

2013-02-25 13:26:41 +01:00

hid-ezkey.c

HID: Use module_hid_driver macro

2013-01-03 10:27:31 +01:00

hid-gaff.c

HID: use hid_hw_request() instead of direct call to usbhid

2013-02-25 13:26:41 +01:00

hid-gembird.c

HID: gembird: add new driver to fix Gembird JPD-DualForce 2

2015-08-18 15:03:43 +02:00

hid-generic.c

HID: Use module_hid_driver macro

2013-01-03 10:27:31 +01:00

hid-gfrm.c

HID: hid-gfrm: avoid warning for input_configured API change

2015-11-05 10:15:35 -08:00

hid-gt683r.c

HID: use to_hid_device()

2015-12-28 13:41:44 +01:00

hid-gyration.c

HID: Use module_hid_driver macro

2013-01-03 10:27:31 +01:00

hid-holtek-kbd.c

HID: Use module_hid_driver macro

2013-01-03 10:27:31 +01:00

hid-holtek-mouse.c

HID: Add Holtek USB ID 04d9:a0c2 ETEKCITY Scroll

2014-09-08 09:48:56 +02:00

hid-holtekff.c

HID: hid-holtekff: don't push static constants on stack for %*ph

2013-08-05 11:29:57 +02:00

hid-hyperv.c

HID: hyperv: match wait_for_completion_timeout return type

2015-01-26 14:25:41 +01:00

hid-icade.c

HID: icade: u16 which never < 0

2013-04-24 16:32:27 +02:00

hid-ids.h

HID: usbhid: Add quirk for Mayflash/Dragonrise DolphinBar.

2017-04-12 12:41:18 +02:00

hid-input.c

Merge branches 'for-4.8/upstream-fixes', 'for-4.9/alps', 'for-4.9/hid-input', 'for-4.9/intel-ish', 'for-4.9/kye-uclogic-waltop-fixes', 'for-4.9/logitech', 'for-4.9/sony', 'for-4.9/upstream' and 'for-4.9/wacom' into for-linus

2016-10-07 09:59:48 +02:00

hid-kensington.c

HID: Use module_hid_driver macro

2013-01-03 10:27:31 +01:00

hid-keytouch.c

HID: Use module_hid_driver macro

2013-01-03 10:27:31 +01:00

hid-kye.c

HID: kye: Fix MousePen i608X v2 report descriptor

2016-09-19 14:32:22 +02:00

hid-lcpower.c

HID: Use module_hid_driver macro

2013-01-03 10:27:31 +01:00

hid-led.c

HID: hid-led: fix issue with transfer buffer not being dma capable

2016-10-10 10:47:03 +02:00

hid-lenovo.c

HID: lenovo: Don't use stack variables for DMA buffers

2016-03-29 15:39:36 +02:00

hid-lg2ff.c

HID: logitech - lg2ff: Add IDs for Formula Vibration Feedback Wheel

2013-10-09 12:06:02 +02:00

hid-lg3ff.c

HID: LG: validate HID output report details

2013-09-13 15:12:39 +02:00

hid-lg4ff.c

HID: hid-logitech: Improve Wingman Formula Force GP support

2016-09-26 15:39:56 +02:00

hid-lg4ff.h

HID: hid-logitech: Add combined pedal support Logitech wheels

2016-09-26 15:39:54 +02:00

hid-lg.c

HID: hid-lg: Fix immediate disconnection of Logitech Rumblepad 2

2017-02-09 08:08:29 +01:00

hid-lg.h

HID: hid-lg4ff: Introduce a module parameter to disable automatic switch of compatibility mode

2015-02-18 21:14:54 +01:00

hid-lgff.c

HID: LG: validate HID output report details

2013-09-13 15:12:39 +02:00

hid-logitech-dj.c

HID: logitech-dj: check report length

2014-12-17 08:50:12 +01:00

hid-logitech-hidpp.c

HID: logitech-hidpp: limit visibility of init/deinit functions

2016-01-28 14:28:39 +01:00

hid-magicmouse.c

HID: magicmouse: make transfer buffers DMA capable

2016-11-23 17:43:25 +01:00

hid-microsoft.c

HID: multitouch: enable the Surface 3 Type Cover to report multitouch data

2017-04-12 12:41:16 +02:00

hid-monterey.c

HID: fix a couple of off-by-ones

2014-08-21 10:43:28 -05:00

hid-multitouch.c

HID: multitouch: do not retrieve all reports for all devices

2017-04-12 12:41:16 +02:00

hid-ntrig.c

HID: use to_hid_device()

2015-12-28 13:41:44 +01:00

hid-ortek.c

HID: Use module_hid_driver macro

2013-01-03 10:27:31 +01:00

hid-penmount.c

HID: penmount: report only one button for PenMount 6000 USB touchscreen controller

2016-03-10 17:17:26 +01:00

hid-petalynx.c

HID: fix a couple of off-by-ones

2014-08-21 10:43:28 -05:00

hid-picolcd_backlight.c

HID: picoLCD: Deletion of unnecessary checks before three function calls

2015-06-29 14:51:12 +02:00

hid-picolcd_cir.c

HID: picoLCD: Deletion of unnecessary checks before three function calls

2015-06-29 14:51:12 +02:00

hid-picolcd_core.c

HID: picolcd: be more verbose when reporting report size error

2014-08-27 23:27:10 +02:00

hid-picolcd_debugfs.c

HID: picolcd: remove unnecessary NULL test before debugfs_remove

2014-06-30 09:54:22 +02:00

hid-picolcd_fb.c

drivers/hid/hid-picolcd_fb: avoid world-writable sysfs files.

2014-05-14 10:53:56 +09:30

hid-picolcd_lcd.c

HID: picoLCD: Deletion of unnecessary checks before three function calls

2015-06-29 14:51:12 +02:00

hid-picolcd_leds.c

HID: use to_hid_device()

2015-12-28 13:41:44 +01:00

hid-picolcd.h

Merge branches 'for-3.10/multitouch', 'for-3.10/roccat' and 'for-3.10/upstream' into for-linus

2013-04-30 10:19:07 +02:00

hid-pl.c

HID: pantherlord: validate output report details

2013-09-04 11:58:32 +02:00

hid-plantronics.c

HID: plantronics: Update to map volume up/down controls

2015-06-12 15:04:17 +02:00

hid-primax.c

HID: Use module_hid_driver macro

2013-01-03 10:27:31 +01:00

hid-prodikeys.c

HID: use to_hid_device()

2015-12-28 13:41:44 +01:00

hid-rmi.c

HID: rmi: make transfer buffers DMA capable

2016-11-23 17:43:25 +01:00

hid-roccat-arvo.c

HID: use kobj_to_dev()

2015-12-28 13:41:51 +01:00

hid-roccat-arvo.h

HID: roccat: correction and cleanup of HID feature reports

2011-06-13 12:52:57 +02:00

hid-roccat-common.c

HID: use kobj_to_dev()

2015-12-28 13:41:51 +01:00

hid-roccat-common.h

HID: roccat: generalize some common code

2013-10-30 14:17:31 +01:00

hid-roccat-isku.c

HID: use kobj_to_dev()

2015-12-28 13:41:51 +01:00

hid-roccat-isku.h

HID: roccat: add support for IskuFX

2013-03-14 11:50:49 +01:00

hid-roccat-kone.c

HID: use kobj_to_dev()

2015-12-28 13:41:51 +01:00

hid-roccat-kone.h

HID: roccat: added media key support for Kone

2013-04-08 10:33:13 +02:00

hid-roccat-koneplus.c

HID: use kobj_to_dev()

2015-12-28 13:41:51 +01:00

hid-roccat-koneplus.h

HID: roccat: fix wrong attr size for koneplus tcu

2012-11-18 22:58:28 +01:00

hid-roccat-konepure.c

HID: roccat: generalize some common code

2013-10-30 14:17:31 +01:00

hid-roccat-kovaplus.c

HID: use kobj_to_dev()

2015-12-28 13:41:51 +01:00

hid-roccat-kovaplus.h

HID: roccat: deprecate some Kovaplus attributes

2012-11-12 15:30:29 +01:00

hid-roccat-lua.c

HID: use kobj_to_dev()

2015-12-28 13:41:51 +01:00

hid-roccat-lua.h

HID: roccat: add support for Roccat Lua

2012-10-17 10:44:47 +02:00

hid-roccat-pyra.c

HID: use kobj_to_dev()

2015-12-28 13:41:51 +01:00

hid-roccat-pyra.h

HID: roccat: deprecated some Pyra attributes

2012-11-12 15:30:28 +01:00

hid-roccat-ryos.c

HID: roccat: add support for Ryos MK keyboards

2013-10-30 14:17:31 +01:00

hid-roccat-savu.c

HID: roccat: generalize some common code

2013-10-30 14:17:31 +01:00

hid-roccat-savu.h

HID: roccat: generalize some common code

2013-10-30 14:17:31 +01:00

hid-roccat.c

HID: roccat: silence an uninitialized variable warning

2016-04-04 09:49:12 +02:00

hid-saitek.c

HID: Add a new Saitek mouse device ID (RAT 9)

2016-08-02 16:45:17 +02:00

hid-samsung.c

HID: Use module_hid_driver macro

2013-01-03 10:27:31 +01:00

hid-sensor-custom.c

HID: sensor: fix attributes in HID sensor interface

2016-11-05 16:56:09 +01:00

hid-sensor-hub.c

HID: sensor-hub: add quirk for Microchip MM7150

2017-04-12 12:41:16 +02:00

hid-sjoy.c

HID: sjoy: support Super Joy Box 4

2015-05-07 10:47:53 +02:00

hid-sony.c

Merge branches 'for-4.8/upstream-fixes', 'for-4.9/alps', 'for-4.9/hid-input', 'for-4.9/intel-ish', 'for-4.9/kye-uclogic-waltop-fixes', 'for-4.9/logitech', 'for-4.9/sony', 'for-4.9/upstream' and 'for-4.9/wacom' into for-linus

2016-10-07 09:59:48 +02:00

hid-speedlink.c

HID: Fix Speedlink VAD Cezanne support for some devices

2013-08-26 13:51:10 +02:00

hid-steelseries.c

HID: use to_hid_device()

2015-12-28 13:41:44 +01:00

hid-sunplus.c

HID: fix a couple of off-by-ones

2014-08-21 10:43:28 -05:00

hid-tivo.c

HID: tivo: enable all buttons on the TiVo Slide Pro remote

2015-03-15 10:04:27 -04:00

hid-tmff.c

HID: use hid_hw_request() instead of direct call to usbhid

2013-02-25 13:26:41 +01:00

hid-topseed.c

HID: Use module_hid_driver macro

2013-01-03 10:27:31 +01:00

hid-twinhan.c

HID: Use module_hid_driver macro

2013-01-03 10:27:31 +01:00

hid-uclogic.c

HID: uclogic: Add support for UC-Logic TWHA60 v3

2016-09-19 14:32:24 +02:00

hid-waltop.c

HID: Remove broken links to tablet descriptions

2016-09-19 14:32:21 +02:00

hid-wiimote-core.c

HID: wiimote: replace hid_output_raw_report with hid_hw_output_report for output requests

2014-02-17 14:57:17 +01:00

hid-wiimote-debug.c

HID: wiimote: fix DRM debug-attr to correctly parse input

2013-06-03 11:07:06 +02:00

hid-wiimote-modules.c

HID: wiimote: Fix wiimote mp scale linearization

2016-03-18 17:31:38 +01:00

hid-wiimote.h

HID: use to_hid_device()

2015-12-28 13:41:44 +01:00

hid-xinmo.c

HID: use module_hid_driver() to simplify the code

2013-08-26 13:23:04 +02:00

hid-zpff.c

HID: zeroplus: validate output report details

2013-09-13 15:11:34 +02:00

hid-zydacron.c

HID: trivial devm conversion for special hid drivers

2013-07-31 10:12:28 +02:00

hidraw.c

Merge branch 'for-4.7/upstream' into for-linus

2016-05-17 12:41:22 +02:00

Kconfig

Merge branches 'for-4.8/upstream-fixes', 'for-4.9/alps', 'for-4.9/hid-input', 'for-4.9/intel-ish', 'for-4.9/kye-uclogic-waltop-fixes', 'for-4.9/logitech', 'for-4.9/sony', 'for-4.9/upstream' and 'for-4.9/wacom' into for-linus

2016-10-07 09:59:48 +02:00

Makefile

HID: intel_ish-hid: ISH Transport layer

2016-08-17 11:13:07 +02:00

uhid.c

miscdevice: Add helper macro for misc device boilerplate

2016-08-31 14:12:35 +02:00

wacom_sys.c

HID: wacom: Don't add ghost interface as shared data

2017-04-08 09:30:33 +02:00

wacom_wac.c

HID: wacom: Have wacom_tpc_irq guard against possible NULL dereference

2017-06-07 12:07:47 +02:00

wacom_wac.h

Merge branches 'for-4.8/upstream-fixes', 'for-4.9/alps', 'for-4.9/hid-input', 'for-4.9/intel-ish', 'for-4.9/kye-uclogic-waltop-fixes', 'for-4.9/logitech', 'for-4.9/sony', 'for-4.9/upstream' and 'for-4.9/wacom' into for-linus

2016-10-07 09:59:48 +02:00

wacom.h

HID: wacom: power_supply: provide the actual model_name

2016-08-05 13:39:23 +02:00