linux

mirror of https://github.com/hardkernel/linux.git synced 2026-04-19 12:00:46 +09:00

Files

Eric Paris d033ce7618 netfilter: NF_HOOK_COND has wrong conditional

commit ac5aa2e333 upstream.

The NF_HOOK_COND returns 0 when it shouldn't due to what I believe to be an
error in the code as the order of operations is not what was intended.  C will
evalutate == before =.  Which means ret is getting set to the bool result,
rather than the return value of the function call.  The code says

if (ret = function() == 1)
when it meant to say:
if ((ret = function()) == 1)

Normally the compiler would warn, but it doesn't notice it because its
a actually complex conditional and so the wrong code is wrapped in an explict
set of () [exactly what the compiler wants you to do if this was intentional].
Fixing this means that errors when netfilter denies a packet get propagated
back up the stack rather than lost.

Problem introduced by commit 2249065f (netfilter: get rid of the grossness
in netfilter.h).

Signed-off-by: Eric Paris <eparis@redhat.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

2010-12-09 13:32:52 -08:00

acpi

ACPI: Fix typos

2010-09-28 21:38:19 -04:00

asm-generic

gpio: doc updates

2010-09-09 18:57:24 -07:00

crypto

crypto: skcipher - Add ablkcipher_walk interfaces

2010-05-19 14:13:07 +10:00

drm

drm/ttm: Fix two race conditions + fix busy codepaths